From: Helge Deller <deller@gmx.de>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: linux-parisc@vger.kernel.org,
James Bottomley <James.Bottomley@hansenpartnership.com>,
John David Anglin <dave.anglin@bell.net>
Subject: Re: PATCH v2] parisc: Add MAP_UNINITIALIZED define
Date: Mon, 12 Oct 2020 10:51:47 +0200 [thread overview]
Message-ID: <829bb90f-91ff-dd68-2150-f4264ff92230@gmx.de> (raw)
In-Reply-To: <18f8c87e7ebaf020a6c61dfdd0d893ba@sf-tec.de>
On 10/12/20 10:24 AM, Rolf Eike Beer wrote:
> Am 2020-10-12 08:50, schrieb Helge Deller:
>> We will not allow unitialized anon mmaps, but we need this define
>> to prevent build errors, e.g. the debian foot package.
>>
>> Suggested-by: John David Anglin <dave.anglin@bell.net>
>> Signed-off-by: Helge Deller <deller@gmx.de>
>>
>> diff --git a/arch/parisc/include/uapi/asm/mman.h
>> b/arch/parisc/include/uapi/asm/mman.h
>> index 6fd8871e4081..ab78cba446ed 100644
>> --- a/arch/parisc/include/uapi/asm/mman.h
>> +++ b/arch/parisc/include/uapi/asm/mman.h
>> @@ -25,6 +25,7 @@
>> #define MAP_STACK 0x40000 /* give out an address that is best suited
>> for process/thread stacks */
>> #define MAP_HUGETLB 0x80000 /* create a huge page mapping */
>> #define MAP_FIXED_NOREPLACE 0x100000 /* MAP_FIXED which doesn't unmap
>> underlying mapping */
>> +#define MAP_UNINITIALIZED 0 /* uninitialized anonymous mmap */
>>
>> #define MS_SYNC 1 /* synchronous memory sync */
>> #define MS_ASYNC 2 /* sync memory asynchronously */
>> diff --git a/tools/arch/parisc/include/uapi/asm/mman.h
>> b/tools/arch/parisc/include/uapi/asm/mman.h
>> index f9fd1325f5bd..506c06a6536f 100644
>> --- a/tools/arch/parisc/include/uapi/asm/mman.h
>> +++ b/tools/arch/parisc/include/uapi/asm/mman.h
>> @@ -39,6 +39,5 @@
>> #define MADV_SOFT_OFFLINE 101
>> /* MAP_32BIT is undefined on parisc, fix it for perf */
>> #define MAP_32BIT 0
>> -/* MAP_UNINITIALIZED is undefined on parisc, fix it for perf */
>> #define MAP_UNINITIALIZED 0
>> #endif
>
> Shouldn't the define itself be deleted here, too?
No, because it doesn't include arch/parisc/include/uapi/asm/mman.h
Helge
prev parent reply other threads:[~2020-10-12 8:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 21:54 [PATCH] parisc: Add MAP_UNINITIALIZED define Helge Deller
2020-10-11 11:56 ` Helge Deller
2020-10-11 13:21 ` John David Anglin
2020-10-12 6:50 ` PATCH v2] " Helge Deller
2020-10-12 8:24 ` Rolf Eike Beer
2020-10-12 8:51 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=829bb90f-91ff-dd68-2150-f4264ff92230@gmx.de \
--to=deller@gmx.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dave.anglin@bell.net \
--cc=eike-kernel@sf-tec.de \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).