From: Kars de Jong <jongk@linux-m68k.org>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: Helge Deller <deller@gmx.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org, linux-parisc@vger.kernel.org
Subject: Re: [RFC][PATCH] m68k/parisc: Convert hp_sdc_rtc driver to rtc framework
Date: Mon, 21 Jan 2019 09:45:03 +0100 [thread overview]
Message-ID: <CACz-3rjx=bcn7qK8qM_mYrW70d-OCpqO1iXS6DZVFb+G_dhvKg@mail.gmail.com> (raw)
In-Reply-To: <CACz-3rg0Jp-QO-1aunwWOFZmd4sdcjQ8cq8QwD5HE+r8t_QQ_A@mail.gmail.com>
Op di 8 jan. 2019 om 09:34 schreef Kars de Jong <jongk@linux-m68k.org>:
> Op ma 7 jan. 2019 om 22:59 schreef Finn Thain <fthain@telegraphics.com.au>:
> >
> > On Mon, 7 Jan 2019, Helge Deller wrote:
> >
> > > On 27.11.18 22:17, Finn Thain wrote:
> > > > Adding Kars to Cc.
> > >
> > > Any chance this can get tested on m68k?
> > >
> >
> > Sorry, I don't have any HP9000/300 hardware. I think that Kars does, which
> > is why I Cc'd him...
> >
>
> Yes, I do still have the hardware, but I haven't booted Linux on it
> for a long time. I planned on doing it during the holidays, but didn't
> get around to it. Maybe I can test it this weekend, but don't hold
> your breath...
I tried to test the patch this weekend. I first started with an
unpatched kernel. Unfortunately, there are hardware issues:
1. The battery of the RTC is dead.
2. There seems to be a problem which causes autovector interrupt 1 to
fire spuriously, which is the keyboard and DMA interrupt. At least,
that's what the OpenBSD kernel reports. It seems to cause the Linux
kernel to freeze.
3. The harddisk (original 200 MB Rodime RO3000T) is failing, so I
can't fully boot OpenBSD to further verify this problem.
Anyway, I don't think your patch it will work.
When running on m68k, you're passing a NULL device pointer to
devm_rtc_device_register(), which eventually gets passed to
devres.c:add_dr() and that is definitely not OK.
I think this calls for a proper platform device on the m68k side.
Kind regards,
Kars.
next prev parent reply other threads:[~2019-01-21 8:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 21:01 [RFC][PATCH] m68k/parisc: Convert hp_sdc_rtc driver to rtc framework Helge Deller
2018-11-27 21:17 ` Finn Thain
2019-01-07 7:31 ` Helge Deller
2019-01-07 21:59 ` Finn Thain
2019-01-08 8:34 ` Kars de Jong
2019-01-21 8:45 ` Kars de Jong [this message]
2019-01-26 13:47 ` Helge Deller
2019-01-28 8:35 ` Kars de Jong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACz-3rjx=bcn7qK8qM_mYrW70d-OCpqO1iXS6DZVFb+G_dhvKg@mail.gmail.com' \
--to=jongk@linux-m68k.org \
--cc=deller@gmx.de \
--cc=fthain@telegraphics.com.au \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).