From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3CAAC4338F for ; Sat, 7 Aug 2021 12:00:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 790AF60EE9 for ; Sat, 7 Aug 2021 12:00:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232113AbhHGMAq (ORCPT ); Sat, 7 Aug 2021 08:00:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230012AbhHGMAp (ORCPT ); Sat, 7 Aug 2021 08:00:45 -0400 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 708D6C0613CF; Sat, 7 Aug 2021 05:00:27 -0700 (PDT) Received: by mail-yb1-xb29.google.com with SMTP id w17so20187347ybl.11; Sat, 07 Aug 2021 05:00:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=WyWRBH02aF7TMZK2H9iKEqjuVSj2aT5mi1GkBNRCyKg=; b=QOdR5x9JTDfThKVhuyhEYPReV0+hyqKytp6bhrDU9jtJxybQG/OIAaA3oWXzAmhUeI OpdNdHL2cTWOdcoGJdjl6SMiapPShk5dqCtzePXNHkSDDTyDYEUVEMRWoeWDVMRgEvWT F3WsjtH95W2GEqcxmYbu5Nki6iHjaP/wAYl8B41Jx1LBzEzxM7r/El9yGNDidzRbvvqa Kmis+CIiKYZTjEfn/MyNVZZE/sJlnMzcMNu5e2sZtEh+M3pQUSfAAN/s+5gpulRT28gX WpDFxD9aYBck7JqESW1IHpFohPSZLTlNkFRqH4KUtyrj9Pxrh4lb4vBKQjKvBi3tS5E+ KYxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=WyWRBH02aF7TMZK2H9iKEqjuVSj2aT5mi1GkBNRCyKg=; b=FENVn+x4TjHqCmYz0t/+7EfVYf1QGqh+zYpVEYmMGPTqnHOOisyXnxzs+6hlVBhG+N QQph2pPY6TkLAa3m8sU5mMDcy4AbNmu15kNxTPMh6DRzmYDaBbUc85RmuCV1GgVPqryW EgWH6cNXsXTLSpg6B9wVdvY2oBP9UeTHGYzrneA/3AB/2K+eaIJpiLLBRcK3tG7HJVWy PmCOFC3lrqXyvRa0Wpq4I6Uqs1KnDmVexInUNu2TpoP7L058z7s7FQ5UCxjlV4esc5Xh WYznK39bNlKg0rsWYXzKfSaqIiE+k6l8K5fA5SOb3CL1CbUEZEhfI1nTa5rZz4m7xdaV hF5g== X-Gm-Message-State: AOAM532Vo5TEnmV+KE0rkq3yYrSNcJSnBO2C/YT8KQjFaTRcaDHjTde0 nUc2OVB7nPEWNSFFrrQgxPso62OY9pkddZvu+yA= X-Google-Smtp-Source: ABdhPJxo9qHswzoJFxioC74Rd4uuv/McBZ+hRPGpGsGEvfuOE6rZWY4LuFWwzY6Vg59fOtg8kqf5oNFF1j4ZtwtEzDU= X-Received: by 2002:a25:1546:: with SMTP id 67mr19373700ybv.331.1628337626600; Sat, 07 Aug 2021 05:00:26 -0700 (PDT) MIME-Version: 1.0 References: <20210807091927.1974404-1-u.kleine-koenig@pengutronix.de> In-Reply-To: <20210807091927.1974404-1-u.kleine-koenig@pengutronix.de> From: Sudip Mukherjee Date: Sat, 7 Aug 2021 12:59:50 +0100 Message-ID: Subject: Re: [PATCH v2] parisc: Make struct parisc_driver::remove() return void To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: "James E.J. Bottomley" , Helge Deller , Sascha Hauer , alsa-devel@alsa-project.org, Corey Minyard , "Martin K. Petersen" , Greg Kroah-Hartman , Dmitry Torokhov , Takashi Iwai , linux-scsi@vger.kernel.org, netdev , linux-parisc , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Jakub Kicinski , openipmi-developer@lists.sourceforge.net, Jaroslav Kysela , Jiri Slaby , "David S. Miller" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Sat, Aug 7, 2021 at 10:19 AM Uwe Kleine-K=C3=B6nig wrote: > > The caller of this function (parisc_driver_remove() in > arch/parisc/kernel/drivers.c) ignores the return value, so better don't > return any value at all to not wake wrong expectations in driver authors. > > The only function that could return a non-zero value before was > ipmi_parisc_remove() which returns the return value of > ipmi_si_remove_by_dev(). Make this function return void, too, as for all > other callers the value is ignored, too. > > Also fold in a small checkpatch fix for: > > WARNING: Unnecessary space before function pointer arguments > + void (*remove) (struct parisc_device *dev); > > Acked-by: Dmitry Torokhov (for drivers/input) > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- > changes since v1 sent with Message-Id: > 20210806093938.1950990-1-u.kleine-koenig@pengutronix.de: > > - Fix a compiler error noticed by the kernel test robot > - Add Ack for Dmitry > > arch/parisc/include/asm/parisc-device.h | 4 ++-- > drivers/char/ipmi/ipmi_si.h | 2 +- > drivers/char/ipmi/ipmi_si_intf.c | 6 +----- > drivers/char/ipmi/ipmi_si_parisc.c | 4 ++-- > drivers/char/ipmi/ipmi_si_platform.c | 4 +++- > drivers/input/keyboard/hilkbd.c | 4 +--- > drivers/input/serio/gscps2.c | 3 +-- > drivers/net/ethernet/i825xx/lasi_82596.c | 3 +-- > drivers/parport/parport_gsc.c | 3 +-- Acked-by: Sudip Mukherjee --=20 Regards Sudip