From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25DB8C433EF for ; Thu, 16 Sep 2021 19:02:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B69B61207 for ; Thu, 16 Sep 2021 19:02:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346280AbhIPTDl (ORCPT ); Thu, 16 Sep 2021 15:03:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346232AbhIPTD3 (ORCPT ); Thu, 16 Sep 2021 15:03:29 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CB91C0698FE for ; Thu, 16 Sep 2021 11:35:56 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id c8so22421389lfi.3 for ; Thu, 16 Sep 2021 11:35:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t51QwKIKWkGOiuP6SJMrhP/dJST+bSD7Qp/ejqOgA0s=; b=PYrRSLFVlXcDD2+pFS2QiDv72x9PP+CSDGgHHxrtNHys/SFAhFt/K9Dl2YKY3s46v4 n1V6egkmODP63nyS2heOSJmRcvJd8e+uQG22Bg5vVGD2JMQ2HAT6BYtwWfythdLKnTmE 1gprbKiTFCMpaERdEBSQKexI+QYMoZlOHeBbU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t51QwKIKWkGOiuP6SJMrhP/dJST+bSD7Qp/ejqOgA0s=; b=UNHIp0XR04Eca4ee8DErYaPBVo4lC96PH6/2X4kbwVNPLb1STIdHnvhqVwbQzfFOWx fxcYV6d/0nZJSmYg0AfEyu3AVP8bDpkMu36v7bPPDqbYH2/T9GGgbUwYWJRDFQ5b2BsG eD7kZ+41J7MoiQnht0DQXfBULZN999T+sUMIXj1H+kbkFNQ1IyNI/EyBRcHFyr0tugHT 656YabkclJAFBDaNmfBooaKOkQL3drqRRvZF2V4EtVoLnsB3db10qVr/2vSOflnY/TLu Y43hrpCxIK4bEbUsGebY8FjctmwEPwuSm25KG211dAsrQoLP7tTN/xWfuQnu8oICAqra FF8Q== X-Gm-Message-State: AOAM53115QWHjYyBjRuJaOXOqBFyjvfVh+yZ2rwHzZtEr3JsZF4y5rwn /NZuTvVqTAPGCUSeCjd0XNPctdc47bTO9Ojr X-Google-Smtp-Source: ABdhPJw4SlbTMScePVgSlnr84vKdkHfzVpfo1kR4XHASevYT8YoPFg/XUlLP/1MHylPoRafAYbLwjg== X-Received: by 2002:a05:6512:48f:: with SMTP id v15mr5047539lfq.690.1631817354300; Thu, 16 Sep 2021 11:35:54 -0700 (PDT) Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com. [209.85.167.47]) by smtp.gmail.com with ESMTPSA id s10sm325184lfc.28.2021.09.16.11.35.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Sep 2021 11:35:53 -0700 (PDT) Received: by mail-lf1-f47.google.com with SMTP id i25so22520818lfg.6 for ; Thu, 16 Sep 2021 11:35:53 -0700 (PDT) X-Received: by 2002:a2e:b53a:: with SMTP id z26mr5708746ljm.95.1631817352669; Thu, 16 Sep 2021 11:35:52 -0700 (PDT) MIME-Version: 1.0 References: <20210915035227.630204-1-linux@roeck-us.net> <47fcc9cc-7d2e-bc79-122b-8eccfe00d8f3@roeck-us.net> <20210915223342.GA1556394@roeck-us.net> In-Reply-To: <20210915223342.GA1556394@roeck-us.net> From: Linus Torvalds Date: Thu, 16 Sep 2021 11:35:36 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/4] Introduce and use absolute_pointer macro To: Guenter Roeck , Michael Cree Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , "James E . J . Bottomley" , Helge Deller , "David S . Miller" , Jakub Kicinski , alpha , Geert Uytterhoeven , Linux Kernel Mailing List , linux-parisc@vger.kernel.org, Netdev , Sparse Mailing-list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Wed, Sep 15, 2021 at 3:33 PM Guenter Roeck wrote: > > drivers/net/ethernet/3com/3c515.c: In function 'corkscrew_start_xmit': > drivers/net/ethernet/3com/3c515.c:1053:22: error: > cast from pointer to integer of different size > > That is a typecast from a pointer to an int, which is then sent to an > i/o port. That driver should probably be disabled for 64-bit builds. Naah. I think the Jensen actually had an ISA slot. Came with a whopping 8MB too, so the ISA DMA should work just fine. Or maybe it was EISA only? I really don't remember. It's possible that alpha should get rid of the ISA config option, and use ISA_BUS instead. That would be the proper config if there aren't actually any ISA _slots_, and it would disable the 3c515 driver. But it turns out that the compile error is easy to fix. Just make it use isa_virt_to_bus(), which that driver does elsewhere anyway. I have no way - or interest - to test that on real hardware, but I did check that if I relax the config I can at least build it cleanly on x86-64 with that change. It can't make matters worse, and it's the RightThing(tm). Since Micheal replied about that other alpha issue, maybe he knows about the ISA slot situation too? But anyway, 3c515 should compile cleanly again. > drivers/net/wan/lmc/lmc_main.c: In function 'lmc_softreset': > drivers/net/wan/lmc/lmc_main.c:1782:50: error: > passing argument 1 of 'virt_to_bus' discards 'volatile' qualifier from pointer target type > > and several other similar errors. > > patch: > https://lore.kernel.org/lkml/20210909050033.1564459-1-linux@roeck-us.net/ > Arnd sent an Ack, but it doesn't look like it was picked up. I picked it up manually now along with the arm vexpress cpufreq one. > m68k: I think these should be fixed as of the pull request this morning. > mips: > > In file included from arch/mips/include/asm/sibyte/sb1250.h:28, > from drivers/watchdog/sb_wdog.c:58: > arch/mips/include/asm/sibyte/bcm1480_scd.h:261: error: "M_SPC_CFG_CLEAR" redefined > > and similar. Patch: > > https://patchwork.kernel.org/project/linux-watchdog/patch/20210913073220.1159520-1-liu.yun@linux.dev/ > > I'll need to get Wim to push it. Ok, that hasn't hit my tree yet. > parisc: This one should be fixed as of the parisc pull this morning. So a few more remaining (mainly the suspend/resume ones), but slowly making progress. Linus