From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1307C43603 for ; Mon, 9 Dec 2019 21:23:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A572A20726 for ; Mon, 9 Dec 2019 21:23:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="tIfUwUlu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726354AbfLIVXJ (ORCPT ); Mon, 9 Dec 2019 16:23:09 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:35694 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726619AbfLIVW7 (ORCPT ); Mon, 9 Dec 2019 16:22:59 -0500 Received: by mail-pl1-f194.google.com with SMTP id s10so6332485plp.2 for ; Mon, 09 Dec 2019 13:22:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZYKN4XMxSrLNdiW1K9zMIVb1AY7QEckrYyQGFO3gO7U=; b=tIfUwUlu/aebwlAJY5I4wiUV+hL2zrAKrAhhFztgRjVtv2G7CznBy3/+nHdkAd9mFg eUi6wvK36wARtJVvf95GdIo4aA7revKeWc0izcsqcLvXLgfJW+injVOYMpEEVQBnr1kr Hq2nD5kyOsjq7ysmRBMqsg9lC5uPzecPpKZaV0IykkwR7l7ulnya8cXpm/niOgqUoNl9 9ZnW3wcUeRkuaL398+LUn72CTffQClXItu4v7VGcUKLAiNAr8KUWgn0TxA1PAQL9k/AI JDzi6aMZwe5u/p+9jdrOj/2XWEMtv+xc4rYuovd51SEiB2zhTyY4QOIozi4MXy+t7t28 D+xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZYKN4XMxSrLNdiW1K9zMIVb1AY7QEckrYyQGFO3gO7U=; b=mmhP3euFaVYMAric8DyMdiwRr+SBb8YBkCSBKQDOeSsgZZ34joM5FPok7xZqtAMIZ2 slbNpw/6V9DO0+Ar5H7mET4ERF7g4qnmeVNcJ+ypIilUfQ4wHMH9zvsmTzHsIvPZeW0a 98KztOPK664DfHiOurQAzdqBFFGnr5CKpm69ry5OJPmCy2pVRCuvBNsN4mmDq1APHSLv Tl7p8cUu2JO6POtO57mU+x1rwAkQhpFoDE1kKiBeP9UX47kDcgJrcNjxbxh8hrEsgGaw 9yQvvGisIi9ihbApeMowLluIFLMrPcDvxFtNyA2v24QSgmm9i9PfVu4fQuujltB2aDVL m2fg== X-Gm-Message-State: APjAAAVivXW0nwpfCweiKqHZJsmQlcPDkDvJEULZc0Q6a3ocY7WcEzOE lV2nYFGYcnTaNSYADzXCioyHxnzSznKqenwV23DOhA== X-Google-Smtp-Source: APXvYqxLyJ84N4sB7y2gm9HTU5F0NX0yt0sS6W9FapviadhzzQ2uydjnauwEeo2bWU2j0dESyGplK2ODB74G0M/HMSI= X-Received: by 2002:a17:902:8b86:: with SMTP id ay6mr18228675plb.223.1575926577921; Mon, 09 Dec 2019 13:22:57 -0800 (PST) MIME-Version: 1.0 References: <20191209211623.44166-1-natechancellor@gmail.com> In-Reply-To: <20191209211623.44166-1-natechancellor@gmail.com> From: Nick Desaulniers Date: Mon, 9 Dec 2019 13:22:46 -0800 Message-ID: Subject: Re: [PATCH] net: tulip: Adjust indentation in {dmfe,uli526x}_init_module To: Nathan Chancellor Cc: "David S. Miller" , Network Development , linux-parisc@vger.kernel.org, LKML , clang-built-linux Content-Type: text/plain; charset="UTF-8" Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Mon, Dec 9, 2019 at 1:16 PM Nathan Chancellor wrote: > > Clang warns: > > ../drivers/net/ethernet/dec/tulip/uli526x.c:1812:3: warning: misleading > indentation; statement is not part of the previous 'if' > [-Wmisleading-indentation] > switch (mode) { > ^ > ../drivers/net/ethernet/dec/tulip/uli526x.c:1809:2: note: previous > statement is here > if (cr6set) > ^ > 1 warning generated. > > ../drivers/net/ethernet/dec/tulip/dmfe.c:2217:3: warning: misleading > indentation; statement is not part of the previous 'if' > [-Wmisleading-indentation] > switch(mode) { > ^ > ../drivers/net/ethernet/dec/tulip/dmfe.c:2214:2: note: previous > statement is here > if (cr6set) > ^ > 1 warning generated. > > This warning occurs because there is a space before the tab on these > lines. Remove them so that the indentation is consistent with the Linux > kernel coding style and clang no longer warns. > > While we are here, adjust the default block in dmfe_init_module to have > a proper break between the label and assignment and add a space between > the switch and opening parentheses to avoid a checkpatch warning. > > Fixes: e1c3e5014040 ("[PATCH] initialisation cleanup for ULI526x-net-driver") > Link: https://github.com/ClangBuiltLinux/linux/issues/795 > Signed-off-by: Nathan Chancellor /^ \t in vim turns up a few more cases that I think should be fixed (in both files) > --- > drivers/net/ethernet/dec/tulip/dmfe.c | 7 ++++--- > drivers/net/ethernet/dec/tulip/uli526x.c | 4 ++-- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/ethernet/dec/tulip/dmfe.c b/drivers/net/ethernet/dec/tulip/dmfe.c > index 0efdbd1a4a6f..32d470d4122a 100644 > --- a/drivers/net/ethernet/dec/tulip/dmfe.c > +++ b/drivers/net/ethernet/dec/tulip/dmfe.c > @@ -2214,15 +2214,16 @@ static int __init dmfe_init_module(void) > if (cr6set) > dmfe_cr6_user_set = cr6set; > > - switch(mode) { > - case DMFE_10MHF: > + switch (mode) { > + case DMFE_10MHF: > case DMFE_100MHF: > case DMFE_10MFD: > case DMFE_100MFD: > case DMFE_1M_HPNA: > dmfe_media_mode = mode; > break; > - default:dmfe_media_mode = DMFE_AUTO; > + default: > + dmfe_media_mode = DMFE_AUTO; > break; > } > > diff --git a/drivers/net/ethernet/dec/tulip/uli526x.c b/drivers/net/ethernet/dec/tulip/uli526x.c > index b1f30b194300..117ffe08800d 100644 > --- a/drivers/net/ethernet/dec/tulip/uli526x.c > +++ b/drivers/net/ethernet/dec/tulip/uli526x.c > @@ -1809,8 +1809,8 @@ static int __init uli526x_init_module(void) > if (cr6set) > uli526x_cr6_user_set = cr6set; > > - switch (mode) { > - case ULI526X_10MHF: > + switch (mode) { > + case ULI526X_10MHF: > case ULI526X_100MHF: > case ULI526X_10MFD: > case ULI526X_100MFD: > -- > 2.24.0 > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20191209211623.44166-1-natechancellor%40gmail.com. -- Thanks, ~Nick Desaulniers