From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59BD3C432C1 for ; Tue, 24 Sep 2019 17:12:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 29C53207FD for ; Tue, 24 Sep 2019 17:12:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569345130; bh=SRE4w45g2rUmKQrrhnWYkWFb0+EjC7R6yTgfc4Pc+Es=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=MlCgOrnkjdHdLYQxiN3mK3dtfyq4XkwvSVcHsp4Kwp1uL1vg3/mozOP7t2SwhsLDX xcByiGMp+0LcMppBb41wlATy5baW8QT7V+64efBzuigakNz3SV6GQEmZsuLbZ3rBGZ eZ+gIR3Wah4d+ufwb2vZUkRvzSf2FKQ/SxL7Xc8U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394715AbfIXRMJ (ORCPT ); Tue, 24 Sep 2019 13:12:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:34704 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394283AbfIXRMJ (ORCPT ); Tue, 24 Sep 2019 13:12:09 -0400 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5F28821A4C for ; Tue, 24 Sep 2019 17:12:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569345128; bh=SRE4w45g2rUmKQrrhnWYkWFb0+EjC7R6yTgfc4Pc+Es=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Cul4lPj43R8SyZJQUrm1p46lCQuMZI9UnsJcDgpnHzZJ8uDFW8mskgD538ujFAp7r GMQjnCrwIiJv5CpFT5sD2o9WeddqpRNSJZ+ZvBu1++0hAreStOeIqgualI3wNRokzO FJFSzQhe72b1eUfPKiXabbR3dq929RWk06sPT5YY= Received: by mail-wm1-f51.google.com with SMTP id v17so890860wml.4 for ; Tue, 24 Sep 2019 10:12:08 -0700 (PDT) X-Gm-Message-State: APjAAAX5BrmSPHKHy0TgplsHbW5J+zcyKOET1VLNREJco5gzUcMuLTUV 7LtFap+VjsEtqEhsn0lGGG+L31ouqAKdNgNQZpnR9w== X-Google-Smtp-Source: APXvYqz3Q0HHqCyDvH+elSspozaob5vsw8VZ7sTVeqI9f4cRrzEBFK5bbTHm3tCuCwTdatbEuC0akEIkOQ4fshlQF84= X-Received: by 2002:a1c:3803:: with SMTP id f3mr1303822wma.161.1569345126773; Tue, 24 Sep 2019 10:12:06 -0700 (PDT) MIME-Version: 1.0 References: <20190920131907.6886-1-christian.brauner@ubuntu.com> <20190924064420.6353-1-christian.brauner@ubuntu.com> In-Reply-To: <20190924064420.6353-1-christian.brauner@ubuntu.com> From: Andy Lutomirski Date: Tue, 24 Sep 2019 10:11:55 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1] seccomp: simplify secure_computing() To: Christian Brauner Cc: Kees Cook , linux-arm-kernel , LKML , Parisc List , linux-s390 , linux-um@lists.infradead.org, Andrew Lutomirski , Oleg Nesterov , Thomas Gleixner , Will Drewry , X86 ML , Borislav Petkov Content-Type: text/plain; charset="UTF-8" Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Mon, Sep 23, 2019 at 11:44 PM Christian Brauner wrote: > > Afaict, the struct seccomp_data argument to secure_computing() is unused > by all current callers. So let's remove it. > The argument was added in [1]. It was added because having the arch > supply the syscall arguments used to be faster than having it done by > secure_computing() (cf. Andy's comment in [2]). This is not true anymore > though. > > /* References */ > [1]: 2f275de5d1ed ("seccomp: Add a seccomp_data parameter secure_computing()") > [2]: https://lore.kernel.org/r/CALCETrU_fs_At-hTpr231kpaAd0z7xJN4ku-DvzhRU6cvcJA_w@mail.gmail.com > > Signed-off-by: Christian Brauner > Cc: Andy Lutomirski > Cc: Thomas Gleixner > Cc: Kees Cook > Cc: Will Drewry > Cc: Oleg Nesterov > Cc: Borislav Petkov > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-parisc@vger.kernel.org > Cc: linux-s390@vger.kernel.org > Cc: linux-um@lists.infradead.org > Cc: x86@kernel.org Acked-by: Andy Lutomirski