From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9904BC17445 for ; Mon, 11 Nov 2019 18:09:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B5B320818 for ; Mon, 11 Nov 2019 18:09:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726951AbfKKSJF (ORCPT ); Mon, 11 Nov 2019 13:09:05 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:40280 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726845AbfKKSJF (ORCPT ); Mon, 11 Nov 2019 13:09:05 -0500 Received: by mail-ot1-f67.google.com with SMTP id m15so12001148otq.7; Mon, 11 Nov 2019 10:09:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pB6c4pFOe94ggxtiHB2kKLTOBOYOEpvnXnv9wnKmZAU=; b=luYxNq6bcrrIs2W4O7SePDvZw1OC5S0MQ7G6zJ7sw5xfflJdnihMEzrsTOQqV/S32q a0QXYP7RqbnI6I+OmlIZlrcadOAWHXz4RoYRe/taKivpl5SF2k6ovB+B1/5f/JMP4VTk MSI8Ci0xTrmkqAixhwXODH/oB9TFmsCw57Ku50KLb1zp8qsmS0kRj4cTMJPOAkp0Vjoq nQ1Bd0yXzm4t5B1AErOJwFXz+zNsxjrJ4t4AAJ1e8s1feMDIusXg/p29e8i8Sgj8gqli wQiv3vx4iFOP5vMVqoWA6IpOF+UXvlvvnHv75qvjrowOm/nOul9i4OWVBGIKzKV6takV IJsQ== X-Gm-Message-State: APjAAAUvX2rzovSYfe6TAWedBo6muyJ2GzckAFLigVv/ZrqOxFka0ndO fDc69Tbk9tjbOUwTKAbZJfxP/QF+U+nCAReRqZw= X-Google-Smtp-Source: APXvYqwz3yURFWyrc4txNYG5Aijjty7ogMGADNC5Z1wYd4gVa5brKlAgJqkxDayccnlPhvVhacX5bel06VJjIpOaGlc= X-Received: by 2002:a05:6830:2363:: with SMTP id r3mr22934879oth.39.1573495742542; Mon, 11 Nov 2019 10:09:02 -0800 (PST) MIME-Version: 1.0 References: <20191011000609.29728-1-keescook@chromium.org> <20191011000609.29728-12-keescook@chromium.org> <201911110922.17A2112B0@keescook> In-Reply-To: <201911110922.17A2112B0@keescook> From: Geert Uytterhoeven Date: Mon, 11 Nov 2019 19:08:51 +0100 Message-ID: Subject: Re: [PATCH v2 11/29] vmlinux.lds.h: Replace RODATA with RO_DATA To: Kees Cook Cc: Borislav Petkov , Rick Edgecombe , Dave Hansen , Andy Lutomirski , Arnd Bergmann , Michael Ellerman , Heiko Carstens , Will Deacon , Linux-Arch , Linux ARM , linuxppc-dev , alpha , "linux-ia64@vger.kernel.org" , linux-s390 , linux-c6x-dev@linux-c6x.org, Yoshinori Sato , Michal Simek , Parisc List , linux-xtensa@linux-xtensa.org, "the arch/x86 maintainers" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org Hi Kees, On Mon, Nov 11, 2019 at 6:23 PM Kees Cook wrote: > On Mon, Nov 11, 2019 at 05:58:06PM +0100, Geert Uytterhoeven wrote: > > On Fri, Oct 11, 2019 at 2:07 AM Kees Cook wrote: > > > There's no reason to keep the RODATA macro: replace the callers with > > > the expected RO_DATA macro. > > > > > > Signed-off-by: Kees Cook > > > --- > > > arch/alpha/kernel/vmlinux.lds.S | 2 +- > > > arch/ia64/kernel/vmlinux.lds.S | 2 +- > > > arch/microblaze/kernel/vmlinux.lds.S | 2 +- > > > arch/mips/kernel/vmlinux.lds.S | 2 +- > > > arch/um/include/asm/common.lds.S | 2 +- > > > arch/xtensa/kernel/vmlinux.lds.S | 2 +- > > > include/asm-generic/vmlinux.lds.h | 4 +--- > > > 7 files changed, 7 insertions(+), 9 deletions(-) > > > > Somehow you missed: > > > > arch/m68k/kernel/vmlinux-std.lds: RODATA > > arch/m68k/kernel/vmlinux-sun3.lds: RODATA > > Argh. I've sent a patch; sorry and thanks for catching this. For my own > cross-build testing, which defconfig targets will hit these two linker > scripts? vmlinux-sun3.lds: sun3_defconfig vmlinux-std.lds: All other classic 680x0 targets with an MMU, e.g. plain defconfig aka multi_defconfig. > > Leading to build failures in next-20191111: > > > > /opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux-ld:./arch/m68k/kernel/vmlinux.lds:29: > > syntax error > > make[1]: *** [/kisskb/src/Makefile:1075: vmlinux] Error 1 > > > > Reported-by: noreply@ellerman.id.au > > http://kisskb.ellerman.id.au/kisskb/buildresult/14022846/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds