From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B42B8C2BA83 for ; Wed, 12 Feb 2020 09:26:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93D8A20848 for ; Wed, 12 Feb 2020 09:26:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728794AbgBLJ0K (ORCPT ); Wed, 12 Feb 2020 04:26:10 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:33393 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728667AbgBLJ0J (ORCPT ); Wed, 12 Feb 2020 04:26:09 -0500 Received: by mail-oi1-f195.google.com with SMTP id q81so1410399oig.0; Wed, 12 Feb 2020 01:26:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ltz/wRnaNIZntV3wpgOwX/2s18RWheTUMisug+H5mlc=; b=Va+kQB5vCnS/bW0li1IPBKBIoWG1HdXtItKb8yb2wvWwB436jyv+qKSpyr0JmDgJG7 cYDouPUH5DY+WEgc0E19Jy83hnZu04g8FUJZxVrxnTydGhljlrpM75171H6AlnyK2vCy ITbWFN2mCK1KpApeMbJwybae/cdRC3yKwHyEZf1WN9ZjVnzNZmk/Iu+KE7xN7F4MisYB JeNBsBpoOF5ZGXxBrxNh3+cmgqc6nzkv6iuQmUOdf+WwhmQP5xSjKaG0DVyoDHawviPC A109t/t4r+0i3YW/Mj2qwD4TyyscD21KI0hakQE7OMGr9825V4mep2AZXMX5PvyzRJ4x 2gHQ== X-Gm-Message-State: APjAAAXQD5mlsIUOjNAuKY2PgV3ZNxW1uwB5+obymf8A+5Tfsv5e94Dx CxGwASR45mzDR0oOCIQ19Qfm0kWDh0b8Eay8fsE= X-Google-Smtp-Source: APXvYqxxPeZbuqaTTpT3vwX5Zpc4udI+nYPgYoBUMe8BqKyyuWPHGsnn9PAqOcBN7GrTfgHO+7CGFYqT6IDyRKLoyvo= X-Received: by 2002:aca:1a06:: with SMTP id a6mr5352368oia.148.1581499568301; Wed, 12 Feb 2020 01:26:08 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Geert Uytterhoeven Date: Wed, 12 Feb 2020 10:25:57 +0100 Message-ID: Subject: Re: [PATCH v2] asm-generic: Fix unistd_32.h generation format To: Max Filippov Cc: Michal Simek , LKML , Michal Simek , git@xilinx.com, Arnd Bergmann , Andrew Morton , Stefan Asserhall , Chris Zankel , "David S. Miller" , Fenghua Yu , Helge Deller , Ivan Kokshaysky , "James E.J. Bottomley" , Matt Turner , Rich Felker , Richard Henderson , Tony Luck , Yoshinori Sato , "open list:ALPHA PORT" , "open list:IA64 (Itanium) PL..." , "open list:M68K ARCHITECTURE" , "open list:PARISC ARCHITECTURE" , "open list:SUPERH" , "open list:TENSILICA XTENSA PORT (xtensa)" , "open list:SPARC + UltraSPAR..." Content-Type: text/plain; charset="UTF-8" Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org Hi Max, On Wed, Feb 12, 2020 at 10:23 AM Max Filippov wrote: > On Wed, Feb 12, 2020 at 1:16 AM Michal Simek wrote: > > > > Generated files are also checked by sparse that's why add newline > > to remove sparse (C=1) warning. > > > > The issue was found on Microblaze and reported like this: > > ./arch/microblaze/include/generated/uapi/asm/unistd_32.h:438:45: > > warning: no newline at end of file > > > > Signed-off-by: Michal Simek > > Reviewed-by: Stefan Asserhall > > --- a/arch/m68k/kernel/syscalls/syscallhdr.sh > > +++ b/arch/m68k/kernel/syscalls/syscallhdr.sh > > @@ -33,4 +33,5 @@ grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | ( > > printf "#endif\n" > > printf "\n" > > printf "#endif /* %s */\n" "${fileguard}" > > Here there's already \n at the end, so no need for another one? Thanks! I completely missed that. So I did fix the original while applying ;-) > > + printf "\n" > > ) > "$out" Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds