From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9784BC47E49 for ; Mon, 4 Nov 2019 09:53:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 75B1D222D3 for ; Mon, 4 Nov 2019 09:53:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727500AbfKDJxu convert rfc822-to-8bit (ORCPT ); Mon, 4 Nov 2019 04:53:50 -0500 Received: from mail-ot1-f66.google.com ([209.85.210.66]:37603 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726633AbfKDJxt (ORCPT ); Mon, 4 Nov 2019 04:53:49 -0500 Received: by mail-ot1-f66.google.com with SMTP id d5so1808003otp.4; Mon, 04 Nov 2019 01:53:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=KliwOsaW5hNOlzjps3zd+1fC4WckuXEun2JezrBsl8M=; b=VT4iPDigdyJQyY+eGSEBG2z95byYx+O72g1TWexezzCHEDkvUNFlkg4blTiZW7RrVw hFTvX8Fh3YS3PgeysvD64rpU66LFNe0ESLuQthk4M/gtbvNeqY14v1aJQKDJS5FmAU0t co6HVuJPCQb6GZ9i7gFZbNRe6B0WmPQ40s9MEWuLf5yDTTVm7PGyJ+69vtGLxSe/DZ1D jiW03HC6MneDPJAJ/Wf7qc5+IUGuYlFIuPisg27PfM/D3TIybtr7+aB2qL5tPR82Um70 MwhtSmE/KagZYuxbQNq/dl8taRjDaG+rsd/WxKjbMO30Vjx5nz3QAInVjLhWJD4H55C/ US9A== X-Gm-Message-State: APjAAAWojAaNQobj/aNkU0uZZUivF4zLZ/J3/IvYrc9M8jYO1vu9ey/6 zUq5upExNYr84e2+Rq2sL70a3GaAcLziZhzF9rUJUQ== X-Google-Smtp-Source: APXvYqx7SaMbfn6eTvQqNR3qc8KtXh3qCjyaO/t3VTJ32GC2iIHqF0HiXvHrmlIBpl/gTi7AjGyf/NSZNGOTan5JhFg= X-Received: by 2002:a9d:73cd:: with SMTP id m13mr18480198otk.145.1572861228733; Mon, 04 Nov 2019 01:53:48 -0800 (PST) MIME-Version: 1.0 References: <1572850587-20314-1-git-send-email-rppt@kernel.org> <1572850587-20314-6-git-send-email-rppt@kernel.org> <20191104094748.GB23288@rapoport-lnx> In-Reply-To: <20191104094748.GB23288@rapoport-lnx> From: Geert Uytterhoeven Date: Mon, 4 Nov 2019 10:53:37 +0100 Message-ID: Subject: Re: [PATCH v3 05/13] m68k: mm: use pgtable-nopXd instead of 4level-fixup To: Mike Rapoport Cc: Linux MM , Andrew Morton , Anton Ivanov , Arnd Bergmann , "David S. Miller" , Greentime Hu , Greg Ungerer , Helge Deller , "James E.J. Bottomley" , Jeff Dike , "Kirill A. Shutemov" , Linus Torvalds , Mark Salter , Matt Turner , Michal Simek , Peter Rosin , Richard Weinberger , Rolf Eike Beer , Russell King , Sam Creasey , Vincent Chen , Vineet Gupta , alpha , Linux-Arch , Linux ARM , linux-c6x-dev@linux-c6x.org, Linux Kernel Mailing List , linux-m68k , Parisc List , linux-um@lists.infradead.org, sparclinux , Mike Rapoport Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org Hi Mike, On Mon, Nov 4, 2019 at 10:48 AM Mike Rapoport wrote: > On Mon, Nov 04, 2019 at 09:53:34AM +0100, Geert Uytterhoeven wrote: > > On Mon, Nov 4, 2019 at 7:57 AM Mike Rapoport wrote: > > > From: Mike Rapoport > > > m68k has two or three levels of page tables and can use appropriate > > > pgtable-nopXd and folding of the upper layers. > > > > > > Replace usage of include/asm-generic/4level-fixup.h and explicit > > > definitions of __PAGETABLE_PxD_FOLDED in m68k with > > > include/asm-generic/pgtable-nopmd.h for two-level configurations and with > > > include/asm-generic/pgtable-nopud.h for three-lelve configurations and > > > adjust page table manipulation macros and functions accordingly. > > > > > > Signed-off-by: Mike Rapoport > > > Acked-by: Greg Ungerer > > > > Thanks for your patch! > > > > The build error reported for v1 by kbuild test robot when building for > > sun3x is still there (m68k defconfig or sun3x_defconfig): > > > > arch/m68k/sun3x/dvma.c: In function ‘dvma_map_cpu’: > > arch/m68k/sun3x/dvma.c:98:33: error: passing argument 2 of > > ‘pmd_alloc’ from incompatible pointer type > > [-Werror=incompatible-pointer-types] > > if((pmd = pmd_alloc(&init_mm, pgd, vaddr)) == NULL) { > > ^~~ > > In file included from arch/m68k/sun3x/dvma.c:17: > > include/linux/mm.h:1875:61: note: expected ‘pud_t *’ {aka ‘struct > > *’} but argument is of type ‘pgd_t *’ {aka ‘struct > > *’} > > static inline pmd_t *pmd_alloc(struct mm_struct *mm, pud_t *pud, > > unsigned long address) > > ~~~~~~~^~~ > > The initial report was against older mmotm (base: > git://git.cmpxchg.org/linux-mmotm.git master) and I presumed this was the > cause of the error. Will fix in v4. OK, thanks! My tree is based on m68k/master, which does not include the mmotm tree, and should be fairly similar to plain v5.4-rc6. > > This indeed boots fine on ARAnyM, which emulates on 68040. > > It would be good to have some boot testing on '020/030, too. > > To be honest, I have no idea how to to that :) Sure. This was more a request for the fellow m68k users. But don't worry too much about it. If it breaks '020/'030, we can fix that later. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds