From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Michal Simek <monstr@monstr.eu>,
git@xilinx.com, Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
Stefan Asserhall <stefan.asserhall@xilinx.com>,
Chris Zankel <chris@zankel.net>,
"David S. Miller" <davem@davemloft.net>,
Fenghua Yu <fenghua.yu@intel.com>, Helge Deller <deller@gmx.de>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Matt Turner <mattst88@gmail.com>,
Max Filippov <jcmvbkbc@gmail.com>, Rich Felker <dalias@libc.org>,
Richard Henderson <rth@twiddle.net>,
Tony Luck <tony.luck@intel.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
alpha <linux-alpha@vger.kernel.org>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
Parisc List <linux-parisc@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
linux-xtensa@linux-xtensa.org,
sparclinux <sparclinux@vger.kernel.org>
Subject: Re: [PATCH v2] asm-generic: Fix unistd_32.h generation format
Date: Wed, 12 Feb 2020 10:23:07 +0100 [thread overview]
Message-ID: <CAMuHMdXt1CUqRjOyz9i0uVzQUJJU3UsFGzDaoTBcWVF=qTH48g@mail.gmail.com> (raw)
In-Reply-To: <dcdd615f77dacf8a98e18950b66fb5a675277f38.1581498987.git.michal.simek@xilinx.com>
Hi Michal,
On Wed, Feb 12, 2020 at 10:16 AM Michal Simek <michal.simek@xilinx.com> wrote:
> Generated files are also checked by sparse that's why add newline
> to remove sparse (C=1) warning.
>
> The issue was found on Microblaze and reported like this:
> ./arch/microblaze/include/generated/uapi/asm/unistd_32.h:438:45:
> warning: no newline at end of file
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> Reviewed-by: Stefan Asserhall <stefan.asserhall@xilinx.com>
Thanks for your patch!
> arch/alpha/kernel/syscalls/syscallhdr.sh | 1 +
> arch/ia64/kernel/syscalls/syscallhdr.sh | 1 +
> arch/m68k/kernel/syscalls/syscallhdr.sh | 1 +
Bummer, I had noticed that before
https://lore.kernel.org/lkml/CAMuHMdVsBwL9vcqejfc47GN793wMXdQ=SwEsSUP1fbpMt-OoWw@mail.gmail.com/
and even claimed I fixed it while applying
https://lore.kernel.org/lkml/CAMuHMdW6JiponxLiGNEXUX4xJk3hK4b8dTOCNvVBr7s2LyfhJw@mail.gmail.com/
but something must have gone wrong...
> arch/microblaze/kernel/syscalls/syscallhdr.sh | 1 +
> arch/parisc/kernel/syscalls/syscallhdr.sh | 1 +
> arch/sh/kernel/syscalls/syscallhdr.sh | 1 +
> arch/sparc/kernel/syscalls/syscallhdr.sh | 1 +
> arch/xtensa/kernel/syscalls/syscallhdr.sh | 1 +
> 8 files changed, 8 insertions(+)
>
> diff --git a/arch/alpha/kernel/syscalls/syscallhdr.sh b/arch/alpha/kernel/syscalls/syscallhdr.sh
> index e5b99bd2e5e7..524c69fbcab7 100644
> --- a/arch/alpha/kernel/syscalls/syscallhdr.sh
> +++ b/arch/alpha/kernel/syscalls/syscallhdr.sh
> @@ -33,4 +33,5 @@ grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | (
> printf "#endif\n"
> printf "\n"
> printf "#endif /* %s */" "${fileguard}"
> + printf "\n"
Why not add the "\n" to the end of the previous line?
Anyway,
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2020-02-12 9:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 9:16 [PATCH v2] asm-generic: Fix unistd_32.h generation format Michal Simek
2020-02-12 9:23 ` Geert Uytterhoeven [this message]
2020-02-12 9:23 ` Max Filippov
2020-02-12 9:25 ` Geert Uytterhoeven
2020-02-12 9:27 ` Michal Simek
2020-02-12 9:32 ` Geert Uytterhoeven
2020-02-12 9:37 ` Michal Simek
2020-02-12 9:40 ` Geert Uytterhoeven
2020-02-12 9:42 ` Michal Simek
2020-02-12 9:57 ` Geert Uytterhoeven
2020-02-12 9:26 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdXt1CUqRjOyz9i0uVzQUJJU3UsFGzDaoTBcWVF=qTH48g@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=chris@zankel.net \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=fenghua.yu@intel.com \
--cc=git@xilinx.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jcmvbkbc@gmail.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=mattst88@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=rth@twiddle.net \
--cc=sparclinux@vger.kernel.org \
--cc=stefan.asserhall@xilinx.com \
--cc=tony.luck@intel.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).