From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5618C7EE29 for ; Fri, 2 Jun 2023 14:51:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236242AbjFBOvC (ORCPT ); Fri, 2 Jun 2023 10:51:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230430AbjFBOvB (ORCPT ); Fri, 2 Jun 2023 10:51:01 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 095F9E40; Fri, 2 Jun 2023 07:50:58 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C92851063; Fri, 2 Jun 2023 07:51:43 -0700 (PDT) Received: from FVFF77S0Q05N.cambridge.arm.com (FVFF77S0Q05N.cambridge.arm.com [10.1.38.135]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 628663F7BD; Fri, 2 Jun 2023 07:50:52 -0700 (PDT) Date: Fri, 2 Jun 2023 15:50:47 +0100 From: Mark Rutland To: Peter Zijlstra Cc: Linus Torvalds , Helge Deller , Masahiro Yamada , Arnd Bergmann , Jonathan Corbet , Will Deacon , Boqun Feng , Catalin Marinas , dennis@kernel.org, Tejun Heo , Christoph Lameter , Heiko Carstens , gor@linux.ibm.com, Alexander Gordeev , borntraeger@linux.ibm.com, Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Joerg Roedel , suravee.suthikulpanit@amd.com, Robin Murphy , David Woodhouse , Baolu Lu , Herbert Xu , "David S . Miller" , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, iommu@lists.linux.dev, Linux-Arch , linux-crypto@vger.kernel.org, Stephen Rothwell , Michael Ellerman , "James E . J . Bottomley" , linux-parisc@vger.kernel.org, John David Anglin , Sam James Subject: Re: [PATCH v2 07/12] parisc/percpu: Work around the lack of __SIZEOF_INT128__ Message-ID: References: <20230531130833.635651916@infradead.org> <20230531132323.722039569@infradead.org> <70a69deb-7ad4-45b2-8e13-34955594a7ce@app.fastmail.com> <20230601101409.GS4253@hirez.programming.kicks-ass.net> <14c50e58-fecc-e96a-ee73-39ef4e4617c7@gmx.de> <20230602143912.GI620383@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230602143912.GI620383@hirez.programming.kicks-ass.net> Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Fri, Jun 02, 2023 at 04:39:12PM +0200, Peter Zijlstra wrote: > On Thu, Jun 01, 2023 at 09:29:18AM -0400, Linus Torvalds wrote: > > > Right now we have that "minimum gcc version" in a somewhat annoying > > place: it's in the ./scripts/min-tool-version.sh file as a shell > > script. > > Something like so then? > > --- > Subject: parisc: Raise minimal GCC version > From: Peter Zijlstra > Date: Fri Jun 2 16:33:54 CEST 2023 > > With 64bit builds depending on __SIZEOF_INT128__ raise the parisc > minimum compiler version to gcc-11.0.0. > > All other 64bit architectures provide this from GCC-5.1.0 (and > probably before), except hppa64 which only started advertising this > with GCC-11. > > Signed-off-by: Peter Zijlstra (Intel) > --- > scripts/min-tool-version.sh | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > --- a/scripts/min-tool-version.sh > +++ b/scripts/min-tool-version.sh > @@ -17,7 +17,11 @@ binutils) > echo 2.25.0 > ;; > gcc) > - echo 5.1.0 > + if [ "$SRCARCH" = parisc ]; then > + echo 11.0.0 > + else > + echo 5.1.0 > + fi > ;; > llvm) > if [ "$SRCARCH" = s390 ]; then I gave this a spin and it looks good to me: [mark@lakrids:~/src/linux]% usekorg 10.3.0 make ARCH=arm64 CROSS_COMPILE=aarch64-linux- defconfig HOSTCC scripts/basic/fixdep HOSTCC scripts/kconfig/conf.o HOSTCC scripts/kconfig/confdata.o HOSTCC scripts/kconfig/expr.o LEX scripts/kconfig/lexer.lex.c YACC scripts/kconfig/parser.tab.[ch] HOSTCC scripts/kconfig/lexer.lex.o HOSTCC scripts/kconfig/menu.o HOSTCC scripts/kconfig/parser.tab.o HOSTCC scripts/kconfig/preprocess.o HOSTCC scripts/kconfig/symbol.o HOSTCC scripts/kconfig/util.o HOSTLD scripts/kconfig/conf *** Default configuration is based on 'defconfig' # # configuration written to .config # [mark@lakrids:~/src/linux]% usekorg 10.3.0 make ARCH=parisc CROSS_COMPILE=hppa64-linux- generic-64bit_defconfig *** *** C compiler is too old. *** Your GCC version: 10.3.0 *** Minimum GCC version: 11.0.0 *** scripts/Kconfig.include:44: Sorry, this C compiler is not supported. make[1]: *** [scripts/kconfig/Makefile:94: generic-64bit_defconfig] Error 1 make: *** [Makefile:692: generic-64bit_defconfig] Error 2 [mark@lakrids:~/src/linux]% usekorg 11.3.0 make ARCH=parisc CROSS_COMPILE=hppa64-linux- generic-64bit_defconfig # # configuration written to .config # FWIW: Tested-by: Mark Rutland Mark.