From: John David Anglin <dave.anglin@bell.net>
To: Helge Deller <deller@gmx.de>,
linux-parisc@vger.kernel.org,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH] parisc: Improve alternative live patching
Date: Thu, 8 Nov 2018 19:11:34 -0500 [thread overview]
Message-ID: <a0963ae2-457c-d54e-9c54-b1d7c4248e94@bell.net> (raw)
In-Reply-To: <20181108220356.GA16610@ls3530.dellerweb.de>
On 2018-11-08 5:03 p.m., Helge Deller wrote:
> static inline int arch_spin_is_locked(arch_spinlock_t *x)
> {
> - volatile unsigned int *a = __ldcw_align(x);
> + volatile unsigned int *a;
> +
> + if (asm_online_cpus() == 1)
> + return 1;
I think the return value should be 0 (unlocked) when asm_online_cpus() == 1.
Dave
--
John David Anglin dave.anglin@bell.net
next prev parent reply other threads:[~2018-11-09 0:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 22:03 [PATCH] parisc: Improve alternative live patching Helge Deller
2018-11-09 0:11 ` John David Anglin [this message]
2018-11-09 7:25 ` Helge Deller
2018-11-09 7:54 ` Helge Deller
2018-11-09 15:43 ` John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0963ae2-457c-d54e-9c54-b1d7c4248e94@bell.net \
--to=dave.anglin@bell.net \
--cc=James.Bottomley@HansenPartnership.com \
--cc=deller@gmx.de \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).