From: Helge Deller <deller@gmx.de>
To: John David Anglin <dave.anglin@bell.net>,
Mikulas Patocka <mpatocka@redhat.com>
Cc: linux-parisc@vger.kernel.org
Subject: Re: [PATCH][RFC] parisc: Use per-pagetable spinlock (v2)
Date: Thu, 2 May 2019 18:14:10 +0200 [thread overview]
Message-ID: <a98ef81b-cd8e-b81d-df24-8c508e8a01b0@gmx.de> (raw)
In-Reply-To: <3595abed-26ea-9aff-60ef-e0893bf07af2@bell.net>
On 02.05.19 16:34, John David Anglin wrote:
> On 2019-05-02 9:43 a.m., Mikulas Patocka wrote:
>> My obeservation is:
>>
>> CONFIG_FLATMEM_MANUAL=y - doesn't compile. With the Helge's patch, it
>> compiles and works - but it only sees the first 1GiB of memory.
> I didn't test FLATMEM.
It should compile now if you check out the for-next branch again.
And it only sees 1GiB of memory, which is correct for FLATMEM.
Instead it tells you to turn on CONFIG_SPARSEMEM:
[0.000000] Large gap in memory detected (786432 pages). Consider turning on CONFIG_SPARSEMEM
[0.000000] Memory Ranges:
[0.000000] 0) Start 0x0000000000000000 End 0x000000003fffffff Size 1024 MB
[0.000000] Total Memory: 1024 MB
..
>> CONFIG_SPARSEMEM_MANUAL=y, CONFIG_SPARSEMEM_VMEMMAP=n - works.
>> CONFIG_SPARSEMEM_MANUAL=y, CONFIG_SPARSEMEM_VMEMMAP=y - hangs on boot.
> I thought I selected CONFIG_SPARSEMEM_VMEMMAP but will check. Have multiple
> builds with original SPARSEMEM patch that were okay.
It sometimes hung for me too.
I think my VMEMMAP patch overwrites other memory and thus only sometimes crashes the machine...
By the way, I've rebased my for-next tree, fixed a few small issues and dropped the VMEMMAP patch for now.
Please give it a new try:
https://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git/log/?h=for-next
In addition I addded a for-next-testing branch for further testing of the remaining patches (VMEMMAP, JUMP_LABEL, ...).
Helge
next prev parent reply other threads:[~2019-05-02 16:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-28 17:34 [PATCH][RFC] parisc: Use per-pagetable spinlock (v2) Helge Deller
2019-05-01 14:22 ` Mikulas Patocka
2019-05-01 14:34 ` Helge Deller
2019-05-01 16:21 ` Mikulas Patocka
2019-05-02 1:27 ` John David Anglin
2019-05-02 13:43 ` Mikulas Patocka
2019-05-02 14:34 ` John David Anglin
2019-05-02 16:14 ` Helge Deller [this message]
2019-05-02 17:40 ` Mikulas Patocka
2019-05-03 11:58 ` John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a98ef81b-cd8e-b81d-df24-8c508e8a01b0@gmx.de \
--to=deller@gmx.de \
--cc=dave.anglin@bell.net \
--cc=linux-parisc@vger.kernel.org \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).