From: Helge Deller <deller@gmx.de>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>,
linux-parisc <linux-parisc@vger.kernel.org>
Subject: Re: [PATCH 1/2] parisc: avoid needless empty lines inside register dump
Date: Tue, 4 Aug 2020 16:19:44 +0200 [thread overview]
Message-ID: <b0b6d3c4-e42e-83c4-47eb-1020fedc6747@gmx.de> (raw)
In-Reply-To: <5385100.WkMxZrnbov@daneel.sf-tec.de>
On 22.06.20 20:51, Rolf Eike Beer wrote:
> Date: Sat, 20 Jun 2020 23:03:51 +0200
>
> Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
Actually, I like those empty lines, because they mark a barrier
between the general registers vs. float registers vs. backtrace.
That said, I'd prefer to not apply this patch, but if more people
here on the list think it's better to remove those, I'm fine to take it.
Helge
> ---
> arch/parisc/kernel/traps.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/arch/parisc/kernel/traps.c b/arch/parisc/kernel/traps.c
> index 5400e23a77a1..e6a0bfdf5c26 100644
> --- a/arch/parisc/kernel/traps.c
> +++ b/arch/parisc/kernel/traps.c
> @@ -80,7 +80,6 @@ static void print_gr(char *level, struct pt_regs *regs)
> int i;
> char buf[64];
>
> - printk("%s\n", level);
> printk("%s YZrvWESTHLNXBCVMcbcbcbcbOGFRQPDI\n", level);
> printbinary(buf, regs->gr[0], 32);
> printk("%sPSW: %s %s\n", level, buf, print_tainted());
> @@ -105,11 +104,9 @@ static void print_fr(char *level, struct pt_regs *regs)
> "fldd 0(%1),%%fr0 \n\t"
> : "=m" (s) : "r" (&s) : "r0");
>
> - printk("%s\n", level);
> printk("%s VZOUICununcqcqcqcqcqcrmunTDVZOUI\n", level);
> printbinary(buf, s.sw[0], 32);
> - printk("%sFPSR: %s\n", level, buf);
> - printk("%sFPER1: %08x\n", level, s.sw[1]);
> + printk("%sFPSR: %s FPER1: %08x\n", level, buf, s.sw[1]);
>
> /* here we'll print fr0 again, tho it'll be meaningless */
> for (i = 0; i < 32; i += 4)
> @@ -137,7 +134,6 @@ void show_regs(struct pt_regs *regs)
>
> cr30 = mfctl(30);
> cr31 = mfctl(31);
> - printk("%s\n", level);
> printk("%sIASQ: " RFMT " " RFMT " IAOQ: " RFMT " " RFMT "\n",
> level, regs->iasq[0], regs->iasq[1], regs->iaoq[0], regs->iaoq[1]);
> printk("%s IIR: %08lx ISR: " RFMT " IOR: " RFMT "\n",
>
prev parent reply other threads:[~2020-08-04 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 18:51 [PATCH 1/2] parisc: avoid needless empty lines inside register dump Rolf Eike Beer
2020-06-22 18:52 ` [PATCH 2/2] parisc: make the log level string for register dumps const Rolf Eike Beer
2020-08-01 12:03 ` [PATCH 1/2] parisc: avoid needless empty lines inside register dump Rolf Eike Beer
2020-08-04 14:19 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0b6d3c4-e42e-83c4-47eb-1020fedc6747@gmx.de \
--to=deller@gmx.de \
--cc=eike-kernel@sf-tec.de \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).