From: Helge Deller <deller@gmx.de>
To: John David Anglin <dave.anglin@bell.net>,
linux-parisc@vger.kernel.org,
James Bottomley <James.Bottomley@hansenpartnership.com>
Subject: Re: [PATCH] Rename LEVEL to PA_ASM_LEVEL to avoid name clash with DRBD code
Date: Mon, 6 May 2019 00:07:40 +0200 [thread overview]
Message-ID: <cf0af76b-34d5-4299-53be-46aa7b8c2372@gmx.de> (raw)
In-Reply-To: <eb66a85f-f5e7-d9ee-4a8d-8cd2759fb9f6@bell.net>
On 06.05.19 00:03, John David Anglin wrote:
> On 2019-05-05 5:54 p.m., Helge Deller wrote:
>> LEVEL is a very common word, and now after many years it suddenly
>> clashed with another LEVEL define in the DRBD code.
>> Rename it to PA_ASM_LEVEL instead.
> I'm sure we used it first ;-)
Yes, we did.
LEVEL is #defined in both:
- drivers/block/drbd/drbd_vli.h (since year 2009)
- arch/parisc/include/asm/assembly.h (*earlier* than year 2005).
Helge
prev parent reply other threads:[~2019-05-05 22:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 21:54 [PATCH] Rename LEVEL to PA_ASM_LEVEL to avoid name clash with DRBD code Helge Deller
2019-05-05 22:03 ` John David Anglin
2019-05-05 22:07 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf0af76b-34d5-4299-53be-46aa7b8c2372@gmx.de \
--to=deller@gmx.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dave.anglin@bell.net \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).