From: Dave Hansen <dave.hansen@intel.com>
To: Luis Chamberlain <mcgrof@kernel.org>,
keescook@chromium.org, yzaikin@google.com, ebiederm@xmission.com,
arnd@arndb.de, bp@alien8.de,
James.Bottomley@HansenPartnership.com, deller@gmx.de,
tglx@linutronix.de, mingo@redhat.com,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
luto@kernel.org, peterz@infradead.org, brgerst@gmail.com,
christophe.jaillet@wanadoo.fr, kirill.shutemov@linux.intel.com,
jroedel@suse.de
Cc: j.granados@samsung.com, akpm@linux-foundation.org,
willy@infradead.org, linux-parisc@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] signal: move show_unhandled_signals sysctl to its own file
Date: Tue, 23 May 2023 07:16:55 -0700 [thread overview]
Message-ID: <d0fe7a6f-8cd9-0b81-758a-f3b444e74bab@intel.com> (raw)
In-Reply-To: <20230522210814.1919325-3-mcgrof@kernel.org>
On 5/22/23 14:08, Luis Chamberlain wrote:
> --- a/arch/x86/kernel/umip.c
> +++ b/arch/x86/kernel/umip.c
> @@ -12,6 +12,7 @@
> #include <asm/insn.h>
> #include <asm/insn-eval.h>
> #include <linux/ratelimit.h>
> +#include <linux/signal.h>
Oh, so this is actually fixing a bug: umip.c uses
'show_unhandled_signals' but it doesn't explicitly include
linux/signal.h where 'show_unhandled_signals' is declared.
It doesn't actually have anything to do with moving the
show_unhandled_signals sysctl, right?
If that's the case, it would be nice to have this in its own patch.
next prev parent reply other threads:[~2023-05-23 14:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 21:08 [PATCH 0/2] kernel/sysctl.c: remove to major base directories Luis Chamberlain
2023-05-22 21:08 ` [PATCH 1/2] sysctl: remove empty dev table Luis Chamberlain
2023-05-22 21:08 ` [PATCH 2/2] signal: move show_unhandled_signals sysctl to its own file Luis Chamberlain
2023-05-23 14:16 ` Dave Hansen [this message]
2023-05-24 7:30 ` Luis Chamberlain
2023-05-25 18:45 ` Luis Chamberlain
2023-05-25 18:52 ` Dave Hansen
2023-05-25 23:04 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0fe7a6f-8cd9-0b81-758a-f3b444e74bab@intel.com \
--to=dave.hansen@intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dave.hansen@linux.intel.com \
--cc=deller@gmx.de \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=j.granados@samsung.com \
--cc=jroedel@suse.de \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mcgrof@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).