Linux-parisc archive on lore.kernel.org
 help / color / Atom feed
From: Amit Kachhap <Amit.Kachhap@arm.com>
To: Will Deacon <will@kernel.org>
Cc: Mark Rutland <Mark.Rutland@arm.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	"deller@gmx.de" <deller@gmx.de>, "duwe@suse.de" <duwe@suse.de>,
	"James.Bottomley@HansenPartnership.com" 
	<James.Bottomley@HansenPartnership.com>,
	James Morse <James.Morse@arm.com>,
	"jeyu@kernel.org" <jeyu@kernel.org>,
	"jpoimboe@redhat.com" <jpoimboe@redhat.com>,
	"jthierry@redhat.com" <jthierry@redhat.com>,
	"linux-parisc@vger.kernel.org" <linux-parisc@vger.kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>,
	"svens@stackframe.org" <svens@stackframe.org>,
	"takahiro.akashi@linaro.org" <takahiro.akashi@linaro.org>
Subject: Re: [PATCHv2 0/8] arm64: ftrace cleanup + FTRACE_WITH_REGS
Date: Mon, 4 Nov 2019 13:03:51 +0000
Message-ID: <d9b738fa-b7c5-f1b2-3878-d7afa4ba7ba5@arm.com> (raw)
In-Reply-To: <20191104125637.GB24108@willie-the-truck>



On 11/4/19 6:26 PM, Will Deacon wrote:
> On Sat, Nov 02, 2019 at 05:42:25PM +0530, Amit Daniel Kachhap wrote:
>> On 10/29/19 10:28 PM, Mark Rutland wrote:
>>> This series is a reworked version of Torsten's FTRACE_WITH_REGS series
>>> [1]. I've tried to rework the existing code in preparatory patches so
>>> that the patchable-function-entry bits slot in with fewer surprises.
>>> This version is based on v5.4-rc3, and can be found in my
>>> arm64/ftrace-with-regs branch [2].
>>>
>>> Patch 1 adds an (optional) ftrace_init_nop(), which the core code uses
>>> to initialize callsites. This allows us to avoid a synthetic MCOUNT_ADDR
>>> symbol, and more cleanly separates the one-time initialization of the
>>> callsite from dynamic NOP<->CALL modification. Architectures which don't
>>> implement this get the existing ftrace_make_nop() with MCOUNT_ADDR.
>>>
>>> Recently parisc gained ftrace support using patchable-function-entry.
>>> Patch 2 makes the handling of module callsite locations common in
>>> kernel/module.c with a new FTRACE_CALLSITE_SECTION definition, and
>>> removed the newly redundant bits from arch/parisc.
>>>
>>> Patches 3 and 4 move the module PLT initialization to module load time,
>>> which simplifies runtime callsite modification. This also means that we
>>> don't transitently mark the module text RW, and will allow for the
>>> removal of module_disable_ro().
>>>
>>> Patches 5 and 6 add some trivial infrastructure, with patch 7 finally
>>> adding FTRACE_WITH_REGS support. Additional work will be required for
>>> livepatching (e.g. implementing reliable stack trace), which is
>>> commented as part of patch 7.
>>>
>>> Patch 8 is a trivial cleanup atop of the rest of the series, making the
>>> code easier to read and less susceptible to config-specific breakage.
>> I tested the whole series with my latest in-kernel ptrauth patches [1]
>> and graph_tracer/function_graph_tracer works fine, So for the whole series,
>> Tested-by: Amit Daniel Kachhap <amit.kachhap@arm.com>
>>
>> Also I gave few minor comments in the individual patches. With those
>> comments,
>> Signed-off-by: Amit Daniel Kachhap <amit.kachhap@arm.com>
Oops sorry I meant,
Reviewed-off-by: Amit Daniel Kachhap <amit.kachhap@arm.com>
>
> I don't think this means what you think it means. Please read:
Thanks for pointing it.
>
> Documentation/process/submitting-patches.rst
>
> Will
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

  reply index

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29 16:58 Mark Rutland
2019-10-29 16:58 ` [PATCHv2 1/8] ftrace: add ftrace_init_nop() Mark Rutland
2019-10-30 15:00   ` Miroslav Benes
2019-11-02 12:19   ` Amit Daniel Kachhap
2019-11-04 13:11     ` Steven Rostedt
2019-11-05  6:59       ` Amit Kachhap
2019-11-04 13:36     ` Mark Rutland
2019-11-05  6:47       ` Amit Kachhap
2019-11-06 14:15         ` Mark Rutland
2019-11-07  4:40           ` Amit Kachhap
2019-11-04 13:16   ` Steven Rostedt
2019-11-04 13:38     ` Mark Rutland
2019-11-04 13:53       ` Steven Rostedt
2019-10-29 16:58 ` [PATCHv2 2/8] module/ftrace: handle patchable-function-entry Mark Rutland
2019-10-30 15:03   ` Torsten Duwe
2019-10-31  9:02     ` Mark Rutland
2019-10-31 11:42       ` Torsten Duwe
2019-10-31 13:00         ` Mark Rutland
2019-11-04 13:28           ` Steven Rostedt
2019-11-04 14:00             ` Mark Rutland
2019-11-04 13:25   ` Steven Rostedt
2019-11-04 15:51   ` Mark Rutland
2019-11-04 20:58     ` Helge Deller
2019-11-05  8:59   ` Miroslav Benes
2019-10-29 16:58 ` [PATCHv2 3/8] arm64: module: rework special section handling Mark Rutland
2019-10-30 15:25   ` Miroslav Benes
2019-10-29 16:58 ` [PATCHv2 4/8] arm64: module/ftrace: intialize PLT at load time Mark Rutland
2019-11-02 12:20   ` Amit Daniel Kachhap
2019-11-04 13:55     ` Mark Rutland
2019-10-29 16:58 ` [PATCHv2 5/8] arm64: insn: add encoder for MOV (register) Mark Rutland
2019-10-29 16:58 ` [PATCHv2 6/8] arm64: asm-offsets: add S_FP Mark Rutland
2019-10-29 16:58 ` [PATCHv2 7/8] arm64: implement ftrace with regs Mark Rutland
2019-11-02 12:21   ` Amit Daniel Kachhap
2019-11-04 13:51     ` Mark Rutland
     [not found]   ` <CANW9uyug8WKN2fR-FmcW-C_OO_OQ_AvukM+BR7wqiJ9eFQMO9Q@mail.gmail.com>
2019-11-15  7:45     ` Torsten Duwe
2019-11-15 13:59     ` Mark Rutland
2019-10-29 16:58 ` [PATCHv2 8/8] arm64: ftrace: minimize ifdeffery Mark Rutland
2019-10-30 17:02 ` [PATCHv2 0/8] arm64: ftrace cleanup + FTRACE_WITH_REGS Torsten Duwe
2019-10-31 17:16 ` Torsten Duwe
2019-11-01  9:08   ` Mark Rutland
2019-11-01 15:39 ` Sven Schnelle
2019-11-01 16:28   ` Mark Rutland
2019-11-02 12:12 ` Amit Daniel Kachhap
2019-11-04 12:56   ` Will Deacon
2019-11-04 13:03     ` Amit Kachhap [this message]
2019-11-04 14:04       ` Mark Rutland
2019-11-05  7:06         ` Amit Kachhap
2019-11-07 11:31 ` Catalin Marinas

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9b738fa-b7c5-f1b2-3878-d7afa4ba7ba5@arm.com \
    --to=amit.kachhap@arm.com \
    --cc=Catalin.Marinas@arm.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=James.Morse@arm.com \
    --cc=Mark.Rutland@arm.com \
    --cc=deller@gmx.de \
    --cc=duwe@suse.de \
    --cc=jeyu@kernel.org \
    --cc=jpoimboe@redhat.com \
    --cc=jthierry@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=svens@stackframe.org \
    --cc=takahiro.akashi@linaro.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-parisc archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-parisc/0 linux-parisc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-parisc linux-parisc/ https://lore.kernel.org/linux-parisc \
		linux-parisc@vger.kernel.org
	public-inbox-index linux-parisc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-parisc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git