Linux-parisc archive on lore.kernel.org
 help / color / Atom feed
From: Helge Deller <deller@gmx.de>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
	Guenter Roeck <linux@roeck-us.net>
Cc: linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] parisc: Regenerate parisc defconfigs
Date: Fri, 27 Mar 2020 00:01:19 +0100
Message-ID: <f0825acd-d875-fa39-4659-b54d259f8b1c@gmx.de> (raw)
In-Reply-To: <1585262834.3581.8.camel@HansenPartnership.com>

On 26.03.20 23:47, James Bottomley wrote:
> On Thu, 2020-03-26 at 23:19 +0100, Helge Deller wrote:
>> * Guenter Roeck <linux@roeck-us.net>:
>>> On Mon, Feb 03, 2020 at 10:31:22PM +0100, Helge Deller wrote:
>>>> Regenerate the 32- and 64-bit defconfigs and drop the outdated
>>>> specific
>>>> machine defconfigs for the 712, A500, B160, C3000 and C8000
>>>> workstations.
>>>> ---
>>>>  arch/parisc/configs/712_defconfig           | 181 --------------
>>>> -
>>>>  arch/parisc/configs/a500_defconfig          | 177 --------------
>>>> -
>>>>  arch/parisc/configs/defconfig               | 206 --------------
>>>> ---
>>>
>>> Since the removal of arch/parisc/configs/defconfig, "make
>>> ARCH=parisc
>>> defconfig" results in an endless recursive make loop.
>>
>> Can you please test the patch below?
>> Helge
>>
>> ----
>> [PATCH] parisc: Fix defconfig selection
>>
>> Fix the recursive loop when running "make ARCH=parisc defconfig".
>>
>> Fixes: 84669923e1ed ("parisc: Regenerate parisc defconfigs")
>> Noticed-by: Guenter Roeck <linux@roeck-us.net>
>> Signed-off-by: Helge Deller <deller@gmx.de>
>>
>> diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig
>> index 71034b54d74e..3801a2ef9bca 100644
>> --- a/arch/parisc/Kconfig
>> +++ b/arch/parisc/Kconfig
>> @@ -79,6 +79,11 @@ config MMU
>>  config STACK_GROWSUP
>>  	def_bool y
>>
>> +config ARCH_DEFCONFIG
>> +	string
>> +	default "arch/parisc/configs/generic-32bit_defconfig" if
>> !64BIT
>> +	default "arch/parisc/configs/generic-64bit_defconfig" if
>> 64BIT
>> +
>>  config GENERIC_LOCKBREAK
>>  	bool
>>  	default y
>> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
>> index dca8f2de8cf5..628cd8bb7ad8 100644
>> --- a/arch/parisc/Makefile
>> +++ b/arch/parisc/Makefile
>> @@ -34,6 +34,13 @@ CC_ARCHES	= hppa hppa2.0 hppa1.1
>>  LD_BFD		:= elf32-hppa-linux
>>  endif
>>
>> +# select defconfig based on actual architecture
>> +ifeq ($(shell uname -m),parisc64)
>
> This won't work for cross builds.  You should be able to use
> $(CONFIG_64BIT) here, though.

I don't think so... CONFIG_64BIT is set in the config itself.

I'm using crossbuilds, and "make ARCH=parisc defconfig" does work
in the sense that it auto-selects 32bit then:

[deller@ls3530 linux-2.6]$ uname -m
x86_64
[deller@ls3530 test]$ make ARCH=parisc defconfig
make: Entering directory '/home/cvs/LINUX/git-kernel/linux-2.6'
make[1]: Entering directory '/home/cvs/LINUX/git-kernel/test'
  GEN     Makefile
  ....
  HOSTLD  scripts/kconfig/conf
*** Default configuration is based on 'generic-32bit_defconfig'
#
# configuration written to .config
#


If you want the 64bit defconfig you can run
make ARCH=parisc generic-64bit_defconfig

Helge

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26 20:20 Guenter Roeck
2020-03-26 22:19 ` Helge Deller
2020-03-26 22:47   ` James Bottomley
2020-03-26 23:01     ` Helge Deller [this message]
2020-03-27  6:43   ` Guenter Roeck
2020-03-27 12:28     ` John David Anglin
2020-03-27 14:24       ` Guenter Roeck
  -- strict thread matches above, loose matches on Subject: below --
2020-02-03 21:28 Helge Deller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0825acd-d875-fa39-4659-b54d259f8b1c@gmx.de \
    --to=deller@gmx.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-parisc archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-parisc/0 linux-parisc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-parisc linux-parisc/ https://lore.kernel.org/linux-parisc \
		linux-parisc@vger.kernel.org
	public-inbox-index linux-parisc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-parisc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git