From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Moritz Fischer <mdf@kernel.org>, netdev@vger.kernel.org
Cc: davem@davemloft.net, linux-parisc@vger.kernel.org,
linux-kernel@vger.kernel.org, lucyyan@google.com
Subject: Re: [PATCH/RFC net] net: dec: tulip: de2104x: Add shutdown handler to stop NIC
Date: Thu, 22 Oct 2020 16:04:16 -0700 [thread overview]
Message-ID: <f1ff32ec2970f1ee808e2da946e6514e71694e71.camel@HansenPartnership.com> (raw)
In-Reply-To: <20201022220636.609956-1-mdf@kernel.org>
On Thu, 2020-10-22 at 15:06 -0700, Moritz Fischer wrote:
> The driver does not implement a shutdown handler which leads to
> issues
> when using kexec in certain scenarios. The NIC keeps on fetching
> descriptors which gets flagged by the IOMMU with errors like this:
>
> DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr fffff000
> DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr fffff000
> DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr fffff000
> DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr fffff000
> DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr fffff000
>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> ---
>
> Hi all,
>
> I'm not sure if this is the proper way for a shutdown handler,
> I've tried to look at a bunch of examples and couldn't find a
> specific
> solution, in my tests on hardware this works, though.
>
> Open to suggestions.
>
> Thanks,
> Moritz
>
> ---
> drivers/net/ethernet/dec/tulip/de2104x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c
> b/drivers/net/ethernet/dec/tulip/de2104x.c
> index f1a2da15dd0a..372c62c7e60f 100644
> --- a/drivers/net/ethernet/dec/tulip/de2104x.c
> +++ b/drivers/net/ethernet/dec/tulip/de2104x.c
> @@ -2185,6 +2185,7 @@ static struct pci_driver de_driver = {
> .id_table = de_pci_tbl,
> .probe = de_init_one,
> .remove = de_remove_one,
> + .shutdown = de_remove_one,
This doesn't look right: shutdown is supposed to turn off the device
without disturbing the tree or causing any knock on effects (I think
that rule is mostly because you don't want anything in userspace
triggering since it's likely to be nearly dead). Remove removes the
device from the tree and cleans up everything. I think the function
you want that's closest to what shutdown needs is de_close(). That
basically just turns off the chip and frees the interrupt ... you'll
have to wrapper it to call it from the pci_driver, though.
James
next prev parent reply other threads:[~2020-10-22 23:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 22:06 [PATCH/RFC net] net: dec: tulip: de2104x: Add shutdown handler to stop NIC Moritz Fischer
2020-10-22 23:04 ` James Bottomley [this message]
2020-10-23 0:15 ` Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1ff32ec2970f1ee808e2da946e6514e71694e71.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=lucyyan@google.com \
--cc=mdf@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).