From: Bitao Hu <yaoma@linux.alibaba.com>
To: Thomas Gleixner <tglx@linutronix.de>,
dianders@chromium.org, liusong@linux.alibaba.com,
akpm@linux-foundation.org, pmladek@suse.com,
kernelfans@gmail.com, deller@gmx.de, npiggin@gmail.com,
tsbogend@alpha.franken.de, James.Bottomley@HansenPartnership.com,
jan.kiszka@siemens.com
Cc: linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
yaoma@linux.alibaba.com
Subject: Re: [PATCHv12 1/4] genirq: Provide a snapshot mechanism for interrupt statistics
Date: Wed, 10 Apr 2024 14:45:02 +0800 [thread overview]
Message-ID: <f3c7ef07-8fad-4ef6-9095-16e4bd734477@linux.alibaba.com> (raw)
In-Reply-To: <87frvu7t85.ffs@tglx>
Hi,
On 2024/4/9 17:58, Thomas Gleixner wrote:
>
> This does not apply anymore.
OK, I will update this patch based on the latest kernel code.
>
> Also can you please split this apart to convert kstat_irqs to a struct
> with just the count in it and then add the snapshot mechanics on top.
>
OK, I will split this patch into two. The changelog for the first patch
will be as follows.
genirq: Convert kstat_irqs to a struct
The irq_desc::kstat_irqs member is a per-CPU variable of type int, and
it is only capable of counting. The snapshot mechanism for interrupt
statistics will be added soon, which requires an additional variable to
store snapshot. To facilitate expansion, convert kstat_irqs here to
a struct containing only the count.
By the way, what do you think of my reason for using printk() instead of
pr_crit()? Should I change this part of the code in v13?
Besides, are there any other issues with this set of patches? I hope we
can resolve all points of contention in v13.
Best Regards,
Bitao Hu
next prev parent reply other threads:[~2024-04-10 6:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 12:52 [PATCHv12 0/4] *** Detect interrupt storm in softlockup *** Bitao Hu
2024-03-06 12:52 ` [PATCHv12 1/4] genirq: Provide a snapshot mechanism for interrupt statistics Bitao Hu
2024-04-09 9:58 ` Thomas Gleixner
2024-04-10 6:45 ` Bitao Hu [this message]
2024-04-10 14:17 ` Thomas Gleixner
2024-03-06 12:52 ` [PATCHv12 2/4] genirq: Avoid summation loops for /proc/interrupts Bitao Hu
2024-03-06 12:52 ` [PATCHv12 3/4] watchdog/softlockup: low-overhead detection of interrupt storm Bitao Hu
2024-03-06 12:52 ` [PATCHv12 4/4] watchdog/softlockup: report the most frequent interrupts Bitao Hu
2024-03-23 20:43 ` Thomas Gleixner
2024-03-25 9:47 ` Bitao Hu
2024-04-01 16:41 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3c7ef07-8fad-4ef6-9095-16e4bd734477@linux.alibaba.com \
--to=yaoma@linux.alibaba.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=deller@gmx.de \
--cc=dianders@chromium.org \
--cc=jan.kiszka@siemens.com \
--cc=kernelfans@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=liusong@linux.alibaba.com \
--cc=npiggin@gmail.com \
--cc=pmladek@suse.com \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).