Re: [PATCH 6.1 00/42] 6.1.32-rc1 review - Greg Kroah-Hartman

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: stable@vger.kernel.org, patches@lists.linux.dev,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org,
	patches@kernelci.org, lkft-triage@lists.linaro.org,
	pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com,
	sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de
Subject: Re: [PATCH 6.1 00/42] 6.1.32-rc1 review
Date: Thu, 1 Jun 2023 15:33:05 +0100	[thread overview]
Message-ID: <2023060142-gizzard-helium-18f0@gregkh> (raw)
In-Reply-To: <2023060101-coconut-smugness-4c7a@gregkh>

On Thu, Jun 01, 2023 at 03:26:27PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Jun 01, 2023 at 07:41:08PM +0530, Naresh Kamboju wrote:
> > On Thu, 1 Jun 2023 at 18:57, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > This is the start of the stable review cycle for the 6.1.32 release.
> > > There are 42 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Sat, 03 Jun 2023 13:19:19 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > >         https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.32-rc1.gz
> > > or in the git tree and branch at:
> > >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> > 
> > 
> > Following build errors noticed on 6.1 and 5.15.
> > 
> > drivers/dma/at_xdmac.c: In function 'atmel_xdmac_resume':
> > drivers/dma/at_xdmac.c:2049:9: error: implicit declaration of function
> > 'pm_runtime_get_noresume' [-Werror=implicit-function-declaration]
> >  2049 |         pm_runtime_get_noresume(atxdmac->dev);
> >       |         ^~~~~~~~~~~~~~~~~~~~~~~
> > drivers/dma/at_xdmac.c:2049:40: error: 'struct at_xdmac' has no member
> > named 'dev'
> >  2049 |         pm_runtime_get_noresume(atxdmac->dev);
> >       |                                        ^~
> > cc1: some warnings being treated as errors
> > 
> > reported link:
> > https://lore.kernel.org/stable/CA+G9fYswtPyrYJbwcGFhc5o7mkRmWZEWCCeSjmR64M+N-odQhQ@mail.gmail.com/
> > 
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> 
> Ah, the .h file was added by 650b0e990cbd ("dmaengine: at_xdmac: add
> runtime pm support"), which isn't needed here.  I'll go add it by hand
> and push out some -rc2 releases for this and 5.15.y, thanks!

No, wait, that series seems really odd.  Sasha, I've dropped the patches
for this driver in 5.15.y and 6.1.y as the backports shouldn't be
calling pm_runtime_* stuff as the main pm_runtime logic has not been
added to the driver there yet.  And the 6.1.y patch seemed really odd,
only 2 lines in the 6.1.y version, and loads of lines in the 5.15.y
version.

thanks,

greg k-h