linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Rob Herring <robh@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: PCI: uniphier: Convert uniphier-pcie.txt to json-schema
Date: Tue, 29 Mar 2022 19:54:49 +0900	[thread overview]
Message-ID: <00796c28-7485-8710-b76b-ac94e3358387@socionext.com> (raw)
In-Reply-To: <YkHg0UeS9kPOW6Kf@robh.at.kernel.org>

Hi Rob,

Thank you for reviewing.

On 2022/03/29 1:22, Rob Herring wrote:
> On Mon, Mar 28, 2022 at 11:11:38AM +0900, Kunihiko Hayashi wrote:
>> Convert the file into a JSON description at the yaml format.
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>>   .../bindings/pci/socionext,uniphier-pcie.yaml | 100 ++++++++++++++++++
>>   .../devicetree/bindings/pci/uniphier-pcie.txt |  82 --------------
>>   MAINTAINERS                                   |   2 +-
>>   3 files changed, 101 insertions(+), 83 deletions(-)
>>   create mode 100644
> Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
>>   delete mode 100644 Documentation/devicetree/bindings/pci/uniphier-pcie.
> txt

[snip]

>> +properties:
>> +  compatible:
>> +    enum:
>> +      - socionext,uniphier-pcie
>> +
>> +  reg:
>> +    minItems: 3
>> +    maxItems: 4
>> +
>> +  reg-names:
>> +    oneOf:
>> +      - items:
>> +          - const: dbi
>> +          - const: link
>> +          - const: config
>> +      - items:
>> +          - const: dbi
>> +          - const: link
>> +          - const: config
>> +          - const: atu
> 
> You can have just the 2nd list plus 'minItems: 3' to do the same thing.

I see. I'll rewrite it that way.

Thank you,

---
Best Regards
Kunihiko Hayashi

      reply	other threads:[~2022-03-29 10:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28  2:11 [PATCH] dt-bindings: PCI: uniphier: Convert uniphier-pcie.txt to json-schema Kunihiko Hayashi
2022-03-28 12:51 ` Rob Herring
2022-03-28 16:23   ` Rob Herring
2022-03-29 10:55     ` Kunihiko Hayashi
2022-03-28 16:22 ` Rob Herring
2022-03-29 10:54   ` Kunihiko Hayashi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00796c28-7485-8710-b76b-ac94e3358387@socionext.com \
    --to=hayashi.kunihiko@socionext.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).