From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Marek Szyprowski'" <m.szyprowski@samsung.com>,
<linux-pci@vger.kernel.org>, <linux-samsung-soc@vger.kernel.org>,
<linux-phy@lists.infradead.org>
Cc: "'Jingoo Han'" <jingoohan1@gmail.com>,
"'Lorenzo Pieralisi'" <lpieralisi@kernel.org>,
"'Rob Herring'" <robh@kernel.org>,
"'Krzysztof Wilczyński'" <kw@linux.com>,
"'Bjorn Helgaas'" <bhelgaas@google.com>,
"'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
"'Alim Akhtar'" <alim.akhtar@samsung.com>,
"'Kishon Vijay Abraham I'" <kishon@ti.com>,
"'Vinod Koul'" <vkoul@kernel.org>
Subject: RE: [PATCH 2/2] PCI: dwc: exynos: Correct generic PHY usage
Date: Wed, 29 Jun 2022 11:57:41 +0900 [thread overview]
Message-ID: <015b01d88b63$ff715430$fe53fc90$@samsung.com> (raw)
In-Reply-To: <20220628220409.26545-2-m.szyprowski@samsung.com>
> The proper initialization for generic PHYs is to call first phy_init(),
> then phy_power_on().
>
> While touching this, lets remove the phy_reset() call. It is just a left-
> over from the obsoleted Exynos5440 support and current exynos-pcie PHY
> driver doesn't even support this function. It is also rarely used by other
> drivers.
>
> Reported-by: Bjorn Helgaas <helgaas@kernel.org>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Chanho Park <chanho61.park@samsung.com>
Best Regards,
Chanho Park
next prev parent reply other threads:[~2022-06-29 2:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220628220437eucas1p2c478751458323f93a71050c4a949f12e@eucas1p2.samsung.com>
2022-06-28 22:04 ` [PATCH 1/2] phy: samsung: phy-exynos-pcie: sanitize init/power_on callbacks Marek Szyprowski
[not found] ` <CGME20220628220441eucas1p2098d46abc47ec1888781fdc5319dec67@eucas1p2.samsung.com>
2022-06-28 22:04 ` [PATCH 2/2] PCI: dwc: exynos: Correct generic PHY usage Marek Szyprowski
2022-06-29 2:57 ` Chanho Park [this message]
2022-06-29 6:05 ` Krzysztof Kozlowski
2022-06-29 2:57 ` [PATCH 1/2] phy: samsung: phy-exynos-pcie: sanitize init/power_on callbacks Chanho Park
2022-06-29 6:04 ` Krzysztof Kozlowski
2022-07-05 6:25 ` Vinod Koul
2022-07-12 20:12 ` Bjorn Helgaas
2022-07-15 11:35 ` Vinod Koul
2022-07-15 22:43 ` Bjorn Helgaas
2022-07-15 23:12 ` Bjorn Helgaas
2022-07-15 11:35 ` Vinod Koul
2022-07-15 23:21 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='015b01d88b63$ff715430$fe53fc90$@samsung.com' \
--to=chanho61.park@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=bhelgaas@google.com \
--cc=jingoohan1@gmail.com \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).