From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DF77C43613 for ; Wed, 16 Jan 2019 10:14:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5512F20859 for ; Wed, 16 Jan 2019 10:14:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=synopsys.com header.i=@synopsys.com header.b="mAulv6P3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389383AbfAPKO3 (ORCPT ); Wed, 16 Jan 2019 05:14:29 -0500 Received: from smtprelay4.synopsys.com ([198.182.47.9]:45178 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389387AbfAPKO2 (ORCPT ); Wed, 16 Jan 2019 05:14:28 -0500 Received: from mailhost.synopsys.com (mailhost2.synopsys.com [10.13.184.66]) by smtprelay.synopsys.com (Postfix) with ESMTP id 2328524E225D; Wed, 16 Jan 2019 02:14:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1547633668; bh=TytxvOXuo/tuBlJS9CnVveu34zZ1C+NigWh+qIVahww=; h=From:To:Cc:Subject:Date:In-Reply-To:References:In-Reply-To: References:From; b=mAulv6P3K9DXSwANBCoRN0SLbTs2Hak59m/sAR+FvxTcpWEfnuoFxG4yRhujb4dKJ uodD8IzouHJliFRN4O/T78SwwuJBVkL5aOSKK0HXbGAK6pjy1xECiVkXTwwK/hikp+ nMeWdqkCO75+ESsQNHKDFaeMv/9wy3eF9iR52nwCZWtA9NhbW3DBcbH9W+4As0o4OU 4mbvImRfbPs8RHHEOhuf8oYCWTv7Oii23BL0VjDccs/92jVIky50ezywuK3Ha5Xcca nPwXikmXXMQvyMYRTSKleKyUcX66wCbxjeyEZwnYypZhZCOebi0HreoiCm04XtqywL CX/9BxxYPWsLw== Received: from de02.synopsys.com (germany.internal.synopsys.com [10.225.17.21]) by mailhost.synopsys.com (Postfix) with ESMTP id E1C8F4E53; Wed, 16 Jan 2019 02:14:27 -0800 (PST) Received: from de02dwia024.internal.synopsys.com (de02dwia024.internal.synopsys.com [10.225.19.81]) by de02.synopsys.com (Postfix) with ESMTP id 9B14A3F698; Wed, 16 Jan 2019 11:14:26 +0100 (CET) From: Gustavo Pimentel To: linux-pci@vger.kernel.org Cc: Gustavo Pimentel , Lorenzo Pieralisi , Joao Pinto , Jingoo Han Subject: [PATCH 9/9] PCI: dwc: Add pcie port pointer validation Date: Wed, 16 Jan 2019 11:14:22 +0100 Message-Id: <0164f622c6d16755d006ae090fba65cff24cfeb2.1547631485.git.gustavo.pimentel@synopsys.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Add pcie port pointer validation to avoid a potencial crash accessing a null pointer reported by coverity scan. Warning generated by coverity: "Dereferencing a pointer that might be null "data" when calling "irq_data_get_irq_chip_data". Signed-off-by: Gustavo Pimentel Cc: Lorenzo Pieralisi Cc: Joao Pinto Cc: Jingoo Han --- drivers/pci/controller/dwc/pcie-designware-host.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c index 45ff5e4..419a56b 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -256,9 +256,14 @@ static void dw_pcie_irq_domain_free(struct irq_domain *domain, unsigned int virq, unsigned int nr_irqs) { struct irq_data *d = irq_domain_get_irq_data(domain, virq); - struct pcie_port *pp = irq_data_get_irq_chip_data(d); + struct pcie_port *pp; unsigned long flags; + if (!d) + return; + + pp = irq_data_get_irq_chip_data(d); + raw_spin_lock_irqsave(&pp->lock, flags); bitmap_release_region(pp->msi_irq_in_use, d->hwirq, -- 2.7.4