From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A47CC433DB for ; Fri, 29 Jan 2021 03:48:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22CE664DBD for ; Fri, 29 Jan 2021 03:48:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231891AbhA2Dsx (ORCPT ); Thu, 28 Jan 2021 22:48:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231883AbhA2Dsq (ORCPT ); Thu, 28 Jan 2021 22:48:46 -0500 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D390C061756 for ; Thu, 28 Jan 2021 19:48:06 -0800 (PST) Received: by mail-lf1-x132.google.com with SMTP id h7so10591064lfc.6 for ; Thu, 28 Jan 2021 19:48:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+RVbZgfsU27MnyOS7YMT70ViFp1xQVbbYZs5V2e2hgg=; b=Fh7O3vXfH2iyqKhFBJuNYwWj1cljAskTJd0ZxeD+aoLIIjHmBRtoySBKBp1E0FLDWP kITiBmszAx6GIN0SHoOYCzS5pH5loF6qJ+2jm3nCJ7ZDNvjbh7hQs3jN+C3ZfhZRJiSh 9tuDkf+eI641lWLqh51GW3234PKeaV+3mWD+0V0Dp7pQxqzYWcskc1x8PDAvYqPnlFsb 2ivbZlxVaY3XWoPg6j6BmF7rsNvcchB+hgXHXvDgK6Sm+b9Fg7lVhSUVxdXdm+sjzPJs G+P2hjitkYuhWmcS7fulRqjsmXUFO39+dRKIckj/3KFzh3NUoNeLKcTmd8Yy8xX1qcPO uPZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+RVbZgfsU27MnyOS7YMT70ViFp1xQVbbYZs5V2e2hgg=; b=GACsLBJurdB3dwY8z0w9mplSi2tVlAMZnXSSR1GXHhkhNJHZJIcE8GjkCH8LCqDuFQ Jo+BdblOEXV1DAtWLP63Q4je+8gAWOCUGlqmbSYbVNWsDAw9KsQ4QMJ+5oLpptgRBG4h oBclkeCldocc4EBhPTeVPJGO9DPWMJStnF6NGaw41/t0wcjEPbX5UqlU3LJoS0fMRyJ7 LSQZ2OEBrhaMzheRkN8LjgVQDwWI7MrYy3p4y0UFqbPvlmavrMipERKKZwyqu2Sm9tq/ JeMXWtsPbLrQLsgzvMFkU94kLmtUwa6UeozEz0OKsjI8hvUoFIkywH+Jjmpm0Wwh4IQp miyQ== X-Gm-Message-State: AOAM533n5Yt16ZFfNtX1kxe+gF1OKRvdzqjBslHZGvrQgKcit4P5m/zN c4hvatsxkvRV0enP5FMpkei0R8SQK7Cyfyv/ X-Google-Smtp-Source: ABdhPJyGfnobprraIQMymppd5iwvMRH9pIQIdu4gNIuVIs3aKuPqxYiCW7vk3XbQ4sB63jvq6mLAHg== X-Received: by 2002:ac2:5f41:: with SMTP id 1mr1125071lfz.65.1611892084715; Thu, 28 Jan 2021 19:48:04 -0800 (PST) Received: from [192.168.1.211] ([94.25.229.83]) by smtp.gmail.com with ESMTPSA id t2sm1880821lfl.141.2021.01.28.19.48.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jan 2021 19:48:04 -0800 (PST) Subject: Re: [PATCH v2 4/5] arm64: dtb: qcom: qrb5165-rb5: add bridge@0,0 to power up qca6391 chip To: Rob Herring Cc: Andy Gross , Bjorn Andersson , Arnd Bergmann , Greg Kroah-Hartman , Stanimir Varbanov , Lorenzo Pieralisi , Bjorn Helgaas , linux-arm-msm , Manivannan Sadhasivam , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , PCI References: <20210128175225.3102958-1-dmitry.baryshkov@linaro.org> <20210128175225.3102958-5-dmitry.baryshkov@linaro.org> From: Dmitry Baryshkov Message-ID: <05758918-1ac1-eaae-a634-8b5ab4b7d944@linaro.org> Date: Fri, 29 Jan 2021 06:48:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 28/01/2021 22:21, Rob Herring wrote: > On Thu, Jan 28, 2021 at 11:52 AM Dmitry Baryshkov > wrote: >> >> If QCA6391 chip (connected to PCIe0) is not powered at the PCIe probe >> time, PCIe0 bus probe will timeout and the device will not be detected. >> So use qca6391 as pcie0's bridge power-domain. This allows us to make >> sure that QCA6391 chip is powered on before PCIe0 probe happens. >> >> Signed-off-by: Dmitry Baryshkov >> --- >> arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts >> index 2b0c1cc9333b..b39a9729395f 100644 >> --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts >> +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts >> @@ -581,6 +581,18 @@ &pcie0 { >> wake-gpio = <&tlmm 81 GPIO_ACTIVE_HIGH>; >> pinctrl-names = "default"; >> pinctrl-0 = <&pcie0_default_state>; >> + >> + bridge@0,0 { >> + compatible = "pci17cb,010b"; >> + reg = <0 0 0 0 0>; >> + >> + #address-cells = <3>; >> + #size-cells = <2>; >> + #interrupt-cells = <1>; >> + >> + /* Power on QCA639x chip sitting behind this bridge. */ >> + power-domains = <&qca6391>; > > This all must be in a child node of the bridge representing the wifi > device. Ack > And all the regulators in the &qca6391 node should just be in > the child node here. The indirection is pointless from a DT > perspective. It is not an indirection. The qca6391 node is shared between WiFi sitting on PCIe and BT sitting on serial port. One can not say that BT is powered by WiFi or vice versa. Thus there is a need for separate 'power domain' node. -- With best wishes Dmitry