From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78288C3A5A1 for ; Wed, 28 Aug 2019 18:43:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 554D62080F for ; Wed, 28 Aug 2019 18:43:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726400AbfH1SnO (ORCPT ); Wed, 28 Aug 2019 14:43:14 -0400 Received: from smtprelay0031.hostedemail.com ([216.40.44.31]:42354 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726515AbfH1SnO (ORCPT ); Wed, 28 Aug 2019 14:43:14 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id 128C5181D33FB; Wed, 28 Aug 2019 18:43:13 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: turn77_73231392da913 X-Filterd-Recvd-Size: 2909 Received: from XPS-9350.home (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf15.hostedemail.com (Postfix) with ESMTPA; Wed, 28 Aug 2019 18:43:11 +0000 (UTC) Message-ID: <082d21ef9effc015de671ff51d689dab740cea16.camel@perches.com> Subject: Re: [PATCH v2] x86/PCI: Add missing log facility and move to use pr_ macros in pcbios.c From: Joe Perches To: Krzysztof Wilczynski Cc: Krzysztof Wilczynski , Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 28 Aug 2019 11:43:09 -0700 In-Reply-To: <1567017627.3507.0@gmail.com> References: <20190825182557.23260-1-kw@linux.com> <20190828175120.22164-1-kw@linux.com> <1567017627.3507.0@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.32.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, 2019-08-28 at 20:40 +0200, Krzysztof Wilczynski wrote: > Hello Joe, > > Thank you for feedback. > [...] > > > Move to pr_debug() over using DBG() from > > > arch/x86/include/asm/pci_x86.h. > > > > You might also consider the checkpatch output for this patch. > > > > arch/x86/pci/pcbios.c:116: WARNING: line over 80 characters > > arch/x86/pci/pcbios.c:116: WARNING: Prefer using '"%s...", __func__' > > to using 'bios32_service', this function's name, in a string > > arch/x86/pci/pcbios.c:119: WARNING: Prefer using '"%s...", __func__' > > to using 'bios32_service', this function's name, in a string > > arch/x86/pci/pcbios.c:391: WARNING: line over 80 characters > > Good point. > > The lines over 80 characters wide would be taken care of when > moving to using the pr_ macros as the line length will now be > shorter contrary to when the e.g., printk(KERNEL_INFO ...), > etc., was used. Not really, those were the warnings checkpatch emits on your actual patch. > The other warnings I am going to address in v3. I was thinking > of replacing the following: > > pr_warn("bios32_service(0x%lx): not present\n", service); > > With something that looks like this: > > pr_warn("BIOS32 Service(0x%lx): not present\n", service); > > Using "bios32_service" name directly or even moving to __func__ > feels a lot like an implementation detail is exposed to the > end user. I am not sure how useful that could be. Also, > we are already using log lines starting with "BIOS32", thus > it seemed like following them would be the most sensible > choice, especially to keep messages consistent. > > What do you think? Fine with me, your patch, your choices.