linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yicong Yang <yangyicong@hisilicon.com>
To: "Krzysztof Wilczyński" <kw@linux.com>
Cc: <bhelgaas@google.com>, <linux-pci@vger.kernel.org>,
	<linuxarm@huawei.com>, <prime.zeng@huawei.com>
Subject: Re: [PATCH] PCI/AER: Use consistent format when print PCI device
Date: Mon, 29 Mar 2021 18:54:12 +0800	[thread overview]
Message-ID: <09488bb3-69f3-706f-69b1-9c538ff6adf2@hisilicon.com> (raw)
In-Reply-To: <YF20lDlJlikTKNkI@rocinante>

On 2021/3/26 18:16, Krzysztof Wilczyński wrote:
> Hi Yicong,
> 
>> We use format domain:bus:slot.function when print
>> PCI device. Use consistent format in AER messages.
> 
> A small nitpick: the commit message and in the subject line it should
> probably use "printing" rather than "print".  But I suppose whoever is
> going be applying this patch can fix this, so probably no need to send
> another version, unless you really want to do it.
> 

sorry for the late reply. it's ok for me to get this fixed in a v2 one. :)

> [...]
>> -			pr_err("AER recover: Can not find pci_dev for %04x:%02x:%02x:%x\n",
>> +			pr_err("AER recover: Can not find pci_dev for %04x:%02x:%02x.%x\n",
>>  			       entry.domain, entry.bus,
>>  			       PCI_SLOT(entry.devfn), PCI_FUNC(entry.devfn));
> [...]
>> -		pr_err("AER recover: Buffer overflow when recovering AER for %04x:%02x:%02x:%x\n",
>> +		pr_err("AER recover: Buffer overflow when recovering AER for %04x:%02x:%02x.%x\n",
>>  		       domain, bus, PCI_SLOT(devfn), PCI_FUNC(devfn));
> 
> Seems like a good idea!  This BDF-like notation is used at few other
> places.  Nice catch.
> 
> Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
> 

thanks.

Yicong

      reply	other threads:[~2021-03-29 10:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26  9:47 Yicong Yang
2021-03-26 10:16 ` Krzysztof Wilczyński
2021-03-29 10:54   ` Yicong Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09488bb3-69f3-706f-69b1-9c538ff6adf2@hisilicon.com \
    --to=yangyicong@hisilicon.com \
    --cc=bhelgaas@google.com \
    --cc=kw@linux.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=prime.zeng@huawei.com \
    --subject='Re: [PATCH] PCI/AER: Use consistent format when print PCI device' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).