From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 346EFC433EF for ; Fri, 12 Nov 2021 15:05:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A94D61056 for ; Fri, 12 Nov 2021 15:05:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233510AbhKLPIj (ORCPT ); Fri, 12 Nov 2021 10:08:39 -0500 Received: from mo4-p02-ob.smtp.rzone.de ([81.169.146.168]:10574 "EHLO mo4-p02-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbhKLPIj (ORCPT ); Fri, 12 Nov 2021 10:08:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1636729547; s=strato-dkim-0002; d=xenosoft.de; h=In-Reply-To:References:Cc:To:From:Subject:Date:Message-ID:Cc:Date: From:Subject:Sender; bh=E7BzZWhInLQMUH9DHrzRoe2vsGIcrFnSCLNloCVDNW8=; b=ZB1RQDexu0hOtKtpSmFslxG8KVE2pMXcOdU/Q6IVZT6M/R2koT9JH9TEGE+MVTDceQ UKOEnHTsNe0ZDgc27Amto3lnnLE8Lk2q7Kd7aZEl9oCx8a9sKp8fPw98Ooz1hQzN0W2v EEtUmnREZeJzx0wILZhPfiHx6G2XPu0OQ6vSBC27L83nsMwSAYeSTJDoV8JMNqm2pb+/ A3e6KtieugtGsBYwtcOsm0WY2lot5ZjX4ML1Tj2ivGffmiMLjWwUqvtY6M28GqMqxO5O Or+2fJn/L5oodbl6wlrHs5DPLb1oQCzkh8mPA96m0QQKQUynwCn2/wnYFPOkqE80eoPD BPJQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":L2QefEenb+UdBJSdRCXu93KJ1bmSGnhMdmOod1DhGM4l4Hio94KKxRySfLxnHfJ+Dkjp5DdBJSrwuuqxvPhWL7n8tmuiQcLNMDVOHy3jXR+anA==" X-RZG-CLASS-ID: mo00 Received: from [IPV6:2a02:8109:89c0:ebfc:5949:d784:5886:5d22] by smtp.strato.de (RZmta 47.34.5 AUTH) with ESMTPSA id N03801xACF5lTyp (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Fri, 12 Nov 2021 16:05:47 +0100 (CET) Message-ID: <0baf0f26-ab82-ca19-ea9f-7f461ce32aa5@xenosoft.de> Date: Fri, 12 Nov 2021 16:05:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PASEMI] Nemo board doesn't recognize any ATA disks with the pci-v5.16 updates Content-Language: de-DE From: Christian Zigotzky To: Marc Zyngier Cc: "bhelgaas@google.com >> Bjorn Helgaas" , Alyssa Rosenzweig , lorenzo.pieralisi@arm.com, Rob Herring , Matthew Leaman , Darren Stevens , mad skateman , "R.T.Dickinson" , Christian Zigotzky , axboe@kernel.dk, damien.lemoal@opensource.wdc.com, kw@linux.com, Arnd Bergmann , robert@swiecki.net, Olof Johansson , linuxppc-dev , "linux-pci@vger.kernel.org" References: <3eedbe78-1fbd-4763-a7f3-ac5665e76a4a@xenosoft.de> <15731ad7-83ff-c7ef-e4a1-8b11814572c2@xenosoft.de> <17e37b22-5839-0e3a-0dbf-9c676adb0dec@xenosoft.de> <3b210c92-4be6-ce49-7512-bb194475eeab@xenosoft.de> <78308692-02e6-9544-4035-3171a8e1e6d4@xenosoft.de> <87mtma8udh.wl-maz@kernel.org> <87lf1t8pab.wl-maz@kernel.org> <87ilwx8ma5.wl-maz@kernel.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Am 12.11.21 um 16:01 schrieb Christian Zigotzky: > Am 12.11.21 um 15:46 schrieb Marc Zyngier: >> On Fri, 12 Nov 2021 14:15:18 +0000, >> Christian Zigotzky wrote: >>> On 12 November 2021 at 02:41 pm, Marc Zyngier wrote: >>>> On Fri, 12 Nov 2021 09:40:30 +0000, >>>> Christian Zigotzky wrote: >>>>> On 11 November 2021 at 06:39 pm, Marc Zyngier wrote: >>>>>> On Wed, 10 Nov 2021 18:07:24 +0000, >>>>>> Christian Zigotzky wrote: >>>>>>> On 09 November 2021 at 03:45 pm, Christian Zigotzky wrote: >>>>>>>> Hello, >>>>>>>> >>>>>>>> The Nemo board [1] doesn't recognize any ATA disks with the >>>>>>> pci-v5.16 updates [2]. >>>>>>>> Error messages: >>>>>>>> >>>>>>>> ata4.00: gc timeout cmd 0xec >>>>>>>> ata4.00: failed to IDENTIFY (I/O error, error_mask=0x4) >>>>>>>> ata1.00: gc timeout cmd 0xec >>>>>>>> ata1.00: failed to IDENTIFY (I/O error, error_mask=0x4) >>>>>>>> ata3.00: gc timeout cmd 0xec >>>>>>>> ata3.00: failed to IDENTIFY (I/O error, error_mask=0x4) >>>>>>>> >>>>>>>> I was able to revert the new pci-v5.16 updates [2]. After a new >>>>>>> compiling, the kernel recognize all ATA disks correctly. >>>>>>>> Could you please check the pci-v5.16 updates [2]? >>>>>>>> >>>>>>>> Please find attached the kernel config. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Christian >>>>>>>> >>>>>>>> [1] https://en.wikipedia.org/wiki/AmigaOne_X1000 >>>>>>>> [2] >>>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0c5c62ddf88c34bc83b66e4ac9beb2bb0e1887d4 >>>>>>> >>>>>>> >>>>>>> Hi All, >>>>>>> >>>>>>> Many thanks for your nice responses. >>>>>>> >>>>>>> I bisected today [1]. 0412841812265734c306ba5ef8088bcb64d5d3bd >>>>>>> (of/irq: Allow matching of an interrupt-map local to an interrupt >>>>>>> controller) [2] is the first bad commit. >>>>>> Can you please give the following hack a go and post the result >>>>>> (including the full dmesg)? >>>>>> >>>>>> Thanks, >>>>>> >>>>>>     M. >>>>>> diff --git a/drivers/of/irq.c b/drivers/of/irq.c >>>>>> index 32be5a03951f..8cf0cc9b7caf 100644 >>>>>> --- a/drivers/of/irq.c >>>>>> +++ b/drivers/of/irq.c >>>>>> @@ -156,14 +156,15 @@ int of_irq_parse_raw(const __be32 *addr, >>>>>> struct of_phandle_args *out_irq) >>>>>>           /* Now start the actual "proper" walk of the interrupt >>>>>> tree */ >>>>>>         while (ipar != NULL) { >>>>>> +        bool intc = of_property_read_bool(ipar, >>>>>> "interrupt-controller"); >>>>>> + >>>>>>             /* >>>>>>              * Now check if cursor is an interrupt-controller and >>>>>>              * if it is then we are done, unless there is an >>>>>>              * interrupt-map which takes precedence. >>>>>>              */ >>>>>>             imap = of_get_property(ipar, "interrupt-map", &imaplen); >>>>>> -        if (imap == NULL && >>>>>> -            of_property_read_bool(ipar, "interrupt-controller")) { >>>>>> +        if (imap == NULL && intc) { >>>>>>                 pr_debug(" -> got it !\n"); >>>>>>                 return 0; >>>>>>             } >>>>>> @@ -244,8 +245,14 @@ int of_irq_parse_raw(const __be32 *addr, >>>>>> struct of_phandle_args *out_irq) >>>>>>                   pr_debug(" -> imaplen=%d\n", imaplen); >>>>>>             } >>>>>> -        if (!match) >>>>>> +        if (!match) { >>>>>> +            if (intc) { >>>>>> +                pr_info("%pOF interrupt-map failed, using >>>>>> interrupt-controller\n", ipar); >>>>>> +                return 0; >>>>>> +            } >>>>>> + >>>>>>                 goto fail; >>>>>> +        } >>>>>>               /* >>>>>>              * Successfully parsed an interrrupt-map translation; >>>>>> copy new >>>>>> >>>>> The detecting of the ATA disks works with this patch! Well done! >>>>> Thanks a lot! >>>> Thanks for testing it. I'll turn that into a proper patch. >>>> >>>>     M. >>>> >>> Could you please explain your patch? >> Please refer to the commit message[1]. >> >>> I am not a developer. I work for the A-EON Linux FLS. >> I have no idea what this is, unfortunately. >> >>     M. >> >> [1] https://lore.kernel.org/r/20211112143644.434995-1-maz@kernel.org >> > FLS: First Level Support (IT customer support) > SLS: Second Level Support (administrators) > TLS: Third Level Support (developers -> you) > > I have to explain our customers why the kernel doesn't detect their > ATA disks anymore. :-D But it is fixed and I don't need to explain it. > > Thanks a lot for your help. > > - Christian Typos