From: Heiner Kallweit <hkallweit1@gmail.com>
To: Kalle Valo <kvalo@codeaurora.org>,
Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: bhelgaas@google.com, Yan-Hsuan Chuang <tony0620emma@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 3/3] PCI: Convert rtw88 power cycle quirk to shutdown quirk
Date: Fri, 26 Feb 2021 13:10:29 +0100 [thread overview]
Message-ID: <0e8ba5a4-0029-6966-e4ab-265a538f3b3d@gmail.com> (raw)
In-Reply-To: <87o8g7e20e.fsf@codeaurora.org>
On 26.02.2021 08:12, Kalle Valo wrote:
> Kai-Heng Feng <kai.heng.feng@canonical.com> writes:
>
>> Now we have a generic D3 shutdown quirk, so convert the original
>> approach to a PCI quirk.
>>
>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>> ---
>> drivers/net/wireless/realtek/rtw88/pci.c | 2 --
>> drivers/pci/quirks.c | 6 ++++++
>> 2 files changed, 6 insertions(+), 2 deletions(-)
>
> It would have been nice to CC linux-wireless also on patches 1-2. I only
> saw patch 3 and had to search the rest of patches from lkml.
>
> I assume this goes via the PCI tree so:
>
> Acked-by: Kalle Valo <kvalo@codeaurora.org>
>
To me it looks odd to (mis-)use the quirk mechanism to set a device
to D3cold on shutdown. As I see it the quirk mechanism is used to work
around certain device misbehavior. And setting a device to a D3
state on shutdown is a normal activity, and the shutdown() callback
seems to be a good place for it.
I miss an explanation what the actual benefit of the change is.
next prev parent reply other threads:[~2021-02-26 12:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 17:40 [PATCH 1/3] PCI: Introduce quirk hook after driver shutdown callback Kai-Heng Feng
2021-02-25 17:40 ` [PATCH 2/3] PCI: Set AMD Renoir USB controller to D3 when shutdown Kai-Heng Feng
2021-02-25 17:40 ` [PATCH 3/3] PCI: Convert rtw88 power cycle quirk to shutdown quirk Kai-Heng Feng
2021-02-26 7:12 ` Kalle Valo
2021-02-26 12:10 ` Heiner Kallweit [this message]
2021-02-26 12:18 ` Kai-Heng Feng
2021-02-26 13:31 ` Heiner Kallweit
2021-02-26 13:40 ` Kalle Valo
2021-02-26 18:16 ` Bjorn Helgaas
2021-03-04 6:07 ` Kai-Heng Feng
2021-03-04 16:02 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e8ba5a4-0029-6966-e4ab-265a538f3b3d@gmail.com \
--to=hkallweit1@gmail.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=kai.heng.feng@canonical.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).