From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Rob Herring <robherring2@gmail.com>,
Will Deacon <will.deacon@arm.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
srikanth t <sthokal@xilinx.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH v6 1/3] ARM: kconfig: allow PCI support to be selected with ARCH_MULTIPLATFORM
Date: Thu, 15 May 2014 15:32:46 +0200 [thread overview]
Message-ID: <10281549.JzWby2ApEY@wuerfel> (raw)
In-Reply-To: <CAL_JsqLbWL136=dGZZfzPbPdF5HjhktYwLaVfbkOoo7Tr+g9Pg@mail.gmail.com>
On Thursday 15 May 2014 08:16:16 Rob Herring wrote:
> On Thu, May 15, 2014 at 7:39 AM, Will Deacon <will.deacon@arm.com> wrote:
> > On Wed, May 14, 2014 at 03:01:35PM +0100, Rob Herring wrote:
> >> On Wed, May 7, 2014 at 11:07 AM, Will Deacon <will.deacon@arm.com> wrote:
> >> > When targetting ARCH_MULTIPLATFORM, we may include support for SoCs with
> >> > PCI-capable devices (e.g. mach-virt with virtio-pci).
> >> >
> >> > This patch allows PCI support to be selected for these SoCs by selecting
> >> > CONFIG_MIGHT_HAVE_PCI when CONFIG_ARCH_MULTIPLATFORM=y.
> >>
> >> I generally think we should select all options for multi-platform that
> >> only serve to hide other options like this.
> >>
> >> You should remove the MIGHT_HAVE_PCI selections from all the
> >> multi-platform enabled platforms as well.
> >
> > Something like the diff below?
>
> Yes, but that raises another question as to what do we do with
> PCI_DOMAINS? Probably should be a PCI host driver select, or given how
> little code it controls it could just be removed. Anyway, that's a
> problem for another day (or patch).
>
> So with the below part added:
>
> Acked-by: Rob Herring <robh@kernel.org>
I think we should also 'select PCI_DOMAINS if PCI' for multiplatform, but
I agree it doesn't have to be in this patch.
Arnd
next prev parent reply other threads:[~2014-05-15 13:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 16:07 [PATCH v6 0/3] Support for Generic PCI Host Controller Will Deacon
2014-05-07 16:07 ` [PATCH v6 1/3] ARM: kconfig: allow PCI support to be selected with ARCH_MULTIPLATFORM Will Deacon
2014-05-08 15:08 ` Stephen Warren
2014-05-08 15:15 ` Will Deacon
2014-05-08 15:38 ` Stephen Warren
2014-05-14 14:01 ` Rob Herring
2014-05-15 12:39 ` Will Deacon
2014-05-15 13:16 ` Rob Herring
2014-05-15 13:32 ` Arnd Bergmann [this message]
2014-05-07 16:07 ` [PATCH v6 2/3] PCI: ARM: add support for generic PCI host controller Will Deacon
2014-05-07 16:07 ` [PATCH v6 3/3] MAINTAINERS: add entry for generic PCI host controller driver Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10281549.JzWby2ApEY@wuerfel \
--to=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=robherring2@gmail.com \
--cc=sthokal@xilinx.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).