From: Hans de Goede <hdegoede@redhat.com>
To: "Krzysztof Wilczyński" <kw@linux.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Myron Stowe" <myron.stowe@redhat.com>,
"Juha-Pekka Heikkila" <juhapekka.heikkila@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"H . Peter Anvin" <hpa@zytor.com>,
linux-pci@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org,
"Benoit Grégoire" <benoitg@coeus.ca>,
"Hui Wang" <hui.wang@canonical.com>
Subject: Re: [PATCH v2] x86/PCI: Ignore E820 reservations for bridge windows on newer systems
Date: Thu, 14 Oct 2021 10:15:13 +0200 [thread overview]
Message-ID: <10ae4edf-277c-41cf-020a-56406213a3f4@redhat.com> (raw)
In-Reply-To: <YWdaJVhoPDrg3Tsd@rocinante>
Hi Krzysztof,
On 10/14/21 12:13 AM, Krzysztof Wilczyński wrote:
> Hi Hans,
>
> Thank you for sending the patch over!
>
> [...]
>> [ 0.000000] BIOS-e820: [mem 0x000000004bc50000-0x00000000cfffffff] reserved
>> [ 0.557473] pci_bus 0000:00: root bus resource [mem 0x65400000-0xbfffffff window]
>
> A very small nitpick: we usually remove time/date stamps from kernel ring
> buffer outputs keeping only the relevant message parts left.
Ok, I'll do a v3 fixing this.
>
> [...]
>> Old systems are defined here as BIOS year < 2018, this was chosen to
>> make sure that pci_use_e820 will not be set on the currently affected
>> systems, while at the same time also taking into account that the
>> systems for which the E820 checking was orignally added may have
>
> A tiny typo of "originally" in the sentence above.
And this.
> [...]
>> @@ -232,3 +236,9 @@ static inline void mmio_config_writel(void __iomem *pos, u32 val)
>> # define x86_default_pci_init_irq NULL
>> # define x86_default_pci_fixup_irqs NULL
>> #endif
>> +
>> +#if defined CONFIG_PCI && defined CONFIG_ACPI
>
> I know that Mika already asked about this, and you responded, so I can only
> added: brackets, let's add brackets, most definitely. :)
I've no big preference either way, so I'll move to using
parentheses for the next version.
>
> [...]
>> +/* Consumed in arch/x86/kernel/resource.c */
>> +bool pci_use_e820 = false;
>
> A small nitpick: not sure if this comment is needed as probably most people
> working with this code would use "git grep" and likes to list occurrences
> where the variables is used. But, this is highly subjective, thus there is
> probably nothing to change here.
I put it the comment there because the other use_foo flag directly above
it are all static, so it is there to explain why this one is not static.
At least that was my idea behind the comment :)
>
>> + printk(KERN_INFO "PCI: %s E820 reservations for host bridge windows\n",
>> + pci_use_e820 ? "Honoring" : "Ignoring");
>
> I know you followed the existing style, which is very much appreciated, but
> if and where possible, we should move to newer API/style and replace the
> printk() above with pr_info(). New code should not be adding old style if
> it can be helped (checkpatch.pl would warn about this too). What do yo you
> think?
Yes checkpatch complained about this, still I deliberately ignored that,
as you said I'm following the existing style here. I very much dislike
mixing styles in a single file. If we want to change this for this file
then IMHO the right thing to do would be a follow up patch changing all
the printk-s at once.
Regards,
Hans
prev parent reply other threads:[~2021-10-14 8:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 9:05 [PATCH v2] x86/PCI: Ignore E820 reservations for bridge windows on newer systems Hans de Goede
2021-10-11 13:53 ` Mika Westerberg
2021-10-11 14:04 ` Hans de Goede
2021-10-12 3:22 ` Hui Wang
2021-10-13 22:13 ` Krzysztof Wilczyński
2021-10-14 8:15 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10ae4edf-277c-41cf-020a-56406213a3f4@redhat.com \
--to=hdegoede@redhat.com \
--cc=benoitg@coeus.ca \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=hui.wang@canonical.com \
--cc=juhapekka.heikkila@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mingo@redhat.com \
--cc=myron.stowe@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).