* [PATCH] PCI: drop duplicate const in DECLARE_PCI_FIXUP_SECTION
@ 2012-09-02 21:37 Mathias Krause
2012-09-09 16:54 ` Mathias Krause
0 siblings, 1 reply; 3+ messages in thread
From: Mathias Krause @ 2012-09-02 21:37 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-pci, linux-kernel, Mathias Krause
It's redundant and makes sparse complain about it.
Signed-off-by: Mathias Krause <minipli@googlemail.com>
---
include/linux/pci.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 5faa831..aee24a8 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1472,7 +1472,7 @@ enum pci_fixup_pass {
/* Anonymous variables would be nice... */
#define DECLARE_PCI_FIXUP_SECTION(section, name, vendor, device, class, \
class_shift, hook) \
- static const struct pci_fixup const __pci_fixup_##name __used \
+ static const struct pci_fixup __pci_fixup_##name __used \
__attribute__((__section__(#section), aligned((sizeof(void *))))) \
= { vendor, device, class, class_shift, hook };
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: drop duplicate const in DECLARE_PCI_FIXUP_SECTION
2012-09-02 21:37 [PATCH] PCI: drop duplicate const in DECLARE_PCI_FIXUP_SECTION Mathias Krause
@ 2012-09-09 16:54 ` Mathias Krause
2012-09-11 0:07 ` Bjorn Helgaas
0 siblings, 1 reply; 3+ messages in thread
From: Mathias Krause @ 2012-09-09 16:54 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-pci, linux-kernel, Mathias Krause
On Sun, Sep 2, 2012 at 11:37 PM, Mathias Krause <minipli@googlemail.com> wrote:
> It's redundant and makes sparse complain about it.
>
> Signed-off-by: Mathias Krause <minipli@googlemail.com>
> ---
> include/linux/pci.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 5faa831..aee24a8 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1472,7 +1472,7 @@ enum pci_fixup_pass {
> /* Anonymous variables would be nice... */
> #define DECLARE_PCI_FIXUP_SECTION(section, name, vendor, device, class, \
> class_shift, hook) \
> - static const struct pci_fixup const __pci_fixup_##name __used \
> + static const struct pci_fixup __pci_fixup_##name __used \
> __attribute__((__section__(#section), aligned((sizeof(void *))))) \
> = { vendor, device, class, class_shift, hook };
>
> --
> 1.7.10.4
>
Ping? It's janitor work, but hey, it fixes a sparse warning.
Mathias
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: drop duplicate const in DECLARE_PCI_FIXUP_SECTION
2012-09-09 16:54 ` Mathias Krause
@ 2012-09-11 0:07 ` Bjorn Helgaas
0 siblings, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2012-09-11 0:07 UTC (permalink / raw)
To: Mathias Krause; +Cc: linux-pci, linux-kernel
On Sun, Sep 9, 2012 at 10:54 AM, Mathias Krause <minipli@googlemail.com> wrote:
> On Sun, Sep 2, 2012 at 11:37 PM, Mathias Krause <minipli@googlemail.com> wrote:
>> It's redundant and makes sparse complain about it.
>>
>> Signed-off-by: Mathias Krause <minipli@googlemail.com>
>> ---
>> include/linux/pci.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/pci.h b/include/linux/pci.h
>> index 5faa831..aee24a8 100644
>> --- a/include/linux/pci.h
>> +++ b/include/linux/pci.h
>> @@ -1472,7 +1472,7 @@ enum pci_fixup_pass {
>> /* Anonymous variables would be nice... */
>> #define DECLARE_PCI_FIXUP_SECTION(section, name, vendor, device, class, \
>> class_shift, hook) \
>> - static const struct pci_fixup const __pci_fixup_##name __used \
>> + static const struct pci_fixup __pci_fixup_##name __used \
>> __attribute__((__section__(#section), aligned((sizeof(void *))))) \
>> = { vendor, device, class, class_shift, hook };
>>
>> --
>> 1.7.10.4
>>
>
> Ping? It's janitor work, but hey, it fixes a sparse warning.
Yep, it's worth doing; I'm just slow. I applied it to my
"pci/trivial" branch. Thanks!
Bjorn
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-11 0:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-02 21:37 [PATCH] PCI: drop duplicate const in DECLARE_PCI_FIXUP_SECTION Mathias Krause
2012-09-09 16:54 ` Mathias Krause
2012-09-11 0:07 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).