From: Yijing Wang <wangyijing@huawei.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: <linux-pci@vger.kernel.org>, Hanjun Guo <guohanjun@huawei.com>,
<jiang.liu@huawei.com>, Yijing Wang <wangyijing@huawei.com>,
Paul Bolle <pebolle@tiscali.nl>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Oliver Neukum <oneukum@suse.de>,
Gu Zheng <guz.fnst@cn.fujitsu.com>
Subject: [PATCH -v4 5/6] PCI: add inspection of device change in pci_scan_single_device
Date: Thu, 1 Aug 2013 21:06:28 +0800 [thread overview]
Message-ID: <1375362389-26096-6-git-send-email-wangyijing@huawei.com> (raw)
In-Reply-To: <1375362389-26096-1-git-send-email-wangyijing@huawei.com>
Add inspection of device change in pci_scan_single_device.
If device change found, print warning. Because the new device
bind the old device driver, so for safety, we do not remove this
device.
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Cc: Paul Bolle <pebolle@tiscali.nl>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Oliver Neukum <oneukum@suse.de>
Cc: Gu Zheng <guz.fnst@cn.fujitsu.com>
Cc: linux-pci@vger.kernel.org
---
drivers/pci/probe.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index edb138c..3ac65aa 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -1389,6 +1389,8 @@ struct pci_dev *__ref pci_scan_single_device(struct pci_bus *bus, int devfn)
dev = pci_get_slot(bus, devfn);
if (dev) {
+ if (pci_serial_number_changed(dev))
+ dev_warn(&dev->dev, "device serial number changed!");
pci_dev_put(dev);
return dev;
}
--
1.7.1
next prev parent reply other threads:[~2013-08-01 13:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 13:06 [PATCH -v4 0/6] Use PCI Serial Number to identify device change Yijing Wang
2013-08-01 13:06 ` [PATCH -v4 1/6] PCI,pciehp: avoid add a device already exist before suspend during resume Yijing Wang
2013-08-02 18:52 ` Paul Bolle
2013-08-02 21:43 ` Paul Bolle
2013-08-05 3:12 ` Yijing Wang
2013-08-01 13:06 ` [PATCH -v4 2/6] PCI: introduce PCIe Device Serial Number Capability support Yijing Wang
2013-08-01 13:06 ` [PATCH -v4 3/6] PCI: Introduce Vital Product Data Serial Number capability support Yijing Wang
2013-08-01 13:06 ` [PATCH -v4 4/6] PCI: add pci_serial_number_changed() for device change identification Yijing Wang
2013-08-01 13:06 ` Yijing Wang [this message]
2013-08-01 13:06 ` [PATCH -v4 6/6] PCI,pciehp: identify device change during suspend Yijing Wang
2013-08-01 13:12 ` Yijing Wang
2013-08-02 18:42 ` Paul Bolle
2013-08-05 3:05 ` Yijing Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375362389-26096-6-git-send-email-wangyijing@huawei.com \
--to=wangyijing@huawei.com \
--cc=bhelgaas@google.com \
--cc=guohanjun@huawei.com \
--cc=guz.fnst@cn.fujitsu.com \
--cc=jiang.liu@huawei.com \
--cc=linux-pci@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=pebolle@tiscali.nl \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).