From: Rui Wang <rui.y.wang@intel.com>
To: helgaas@kernel.org, tglx@linutronix.de, rjw@rjwysocki.net,
tony.luck@intel.com
Cc: bhelgaas@google.com, linux-acpi@vger.kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
rui.y.wang@intel.com
Subject: [PATCH v2 3/5] x86/ioapic: Fix setup_res() failing to get resource
Date: Wed, 27 Jul 2016 23:44:13 +0800 [thread overview]
Message-ID: <1469634255-24101-4-git-send-email-rui.y.wang@intel.com> (raw)
In-Reply-To: <1469634255-24101-1-git-send-email-rui.y.wang@intel.com>
setup_res() doesn't actually get any resource because it mistakenly
checks the return value of acpi_dev_filter_resource_type(), which
returns 0 on success, and 1 on failure. Fix it by taking the return
value of non-zero as failing to match the specified resource type.
Signed-off-by: Rui Wang <rui.y.wang@intel.com>
---
drivers/acpi/ioapic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/ioapic.c b/drivers/acpi/ioapic.c
index 2449377..8ab6d42 100644
--- a/drivers/acpi/ioapic.c
+++ b/drivers/acpi/ioapic.c
@@ -46,7 +46,7 @@ static acpi_status setup_res(struct acpi_resource *acpi_res, void *data)
struct resource_win win;
res->flags = 0;
- if (acpi_dev_filter_resource_type(acpi_res, IORESOURCE_MEM) == 0)
+ if (acpi_dev_filter_resource_type(acpi_res, IORESOURCE_MEM))
return AE_OK;
if (!acpi_dev_resource_memory(acpi_res, res)) {
--
1.8.3.1
next prev parent reply other threads:[~2016-07-27 15:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 16:13 [PATCH 0/4] Fixing a set of bugs for ioapic hotplug Rui Wang
2016-07-26 16:13 ` [PATCH 1/4] x86/ioapic: Support hot-removal of IOAPICs present during boot Rui Wang
2016-07-26 20:19 ` Bjorn Helgaas
2016-07-26 20:46 ` Bjorn Helgaas
2016-07-27 15:44 ` [PATCH v2 0/5] Fixing a set of bugs for ioapic hotplug Rui Wang
2016-07-27 15:44 ` [PATCH v2 1/5] x86/ioapic: Change prototype of acpi_ioapic_add() Rui Wang
2016-07-27 15:44 ` [PATCH v2 2/5] x86/ioapic: Support hot-removal of IOAPICs present during boot Rui Wang
2016-07-27 17:13 ` Bjorn Helgaas
2016-07-27 15:44 ` Rui Wang [this message]
2016-07-27 15:44 ` [PATCH v2 4/5] x86/ioapic: Fix lost IOAPIC resource after hot-removal and hotadd Rui Wang
2016-07-27 15:44 ` [PATCH v2 5/5] x86/ioapic: Fix ioapic failing to request resource Rui Wang
2016-07-27 2:23 ` [PATCH 1/4] x86/ioapic: Support hot-removal of IOAPICs present during boot boot Rui Wang
2016-07-26 16:13 ` [PATCH 2/4] x86/ioapic: Fix setup_res() failing to get resource Rui Wang
2016-07-26 20:21 ` Bjorn Helgaas
2016-07-26 16:13 ` [PATCH 3/4] x86/ioapic: Fix lost ioapic resource after hot-removal and hotadd Rui Wang
2016-07-26 16:49 ` kbuild test robot
2016-07-26 20:24 ` Bjorn Helgaas
2016-07-27 2:35 ` Rui Wang
2016-07-26 16:13 ` [PATCH 4/4] x86/ioapic: Fix ioapic failing to request resource Rui Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469634255-24101-4-git-send-email-rui.y.wang@intel.com \
--to=rui.y.wang@intel.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).