From: Gabriele Paoloni <gabriele.paoloni@huawei.com>
To: <bhelgaas@google.com>, <helgaas@kernel.org>
Cc: <gabriele.paoloni@huawei.com>, <linuxarm@huawei.com>,
<linux-pci@vger.kernel.org>, <lukas@wunner.de>,
<linux-kernel@vger.kernel.org>, <mika.westerberg@linux.intel.com>,
<hch@infradead.org>, <liudongdong3@huawei.com>
Subject: [PATCH v3 2/2] PCI/portdrv: allocate MSI/MSIx vector for DPC RP service
Date: Thu, 18 May 2017 11:35:48 +0100 [thread overview]
Message-ID: <1495103748-7876-3-git-send-email-gabriele.paoloni@huawei.com> (raw)
In-Reply-To: <1495103748-7876-1-git-send-email-gabriele.paoloni@huawei.com>
From: gabriele paoloni <gabriele.paoloni@huawei.com>
Currently the MSI/MSIx vectors for the root port services are
allocated calling pcie_init_service_irqs(). At the moment these
vectors are only allocated for AER, PME, HP.
This patch allocate an MSI/MSIx vector also for DPC.
Signed-off-by: Liudongdong <liudongdong3@huawei.com>
Signed-off-by: Gabriele Paoloni <gabriele.paoloni@huawei.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
drivers/pci/pcie/portdrv_core.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c
index 4d16cf2..6a32b42 100644
--- a/drivers/pci/pcie/portdrv_core.c
+++ b/drivers/pci/pcie/portdrv_core.c
@@ -123,6 +123,31 @@ static int pcie_port_enable_irq_vec(struct pci_dev *dev, int *irqs, int mask)
nvec = max(nvec, entry + 1);
}
+ if (mask & PCIE_PORT_SERVICE_DPC) {
+ u16 reg16, pos;
+
+ /*
+ * The code below follows Section 6.2.10.1 of the PCI Express
+ * Base Specification 4.0 stating that bits 4-0 of DPC
+ * Capability Register contain a value indicating which of the
+ * MSI/MSI-X vectors assigned to the port is going to be used
+ * for DPC, where "For MSI-X, the value in this register
+ * indicates which MSI-X Table entry is used to generate the
+ * interrupt message." and "For MSI, the value in this field
+ * indicates the offset between the base Message Data and the
+ * interrupt message that is generated."
+ */
+ pos = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_DPC);
+ pci_read_config_word(dev, pos + PCI_EXP_DPC_CAP, ®16);
+ entry = reg16 & 0x1f;
+ if (entry >= nr_entries)
+ goto out_free_irqs;
+
+ irqs[PCIE_PORT_SERVICE_DPC_SHIFT] = pci_irq_vector(dev, entry);
+
+ nvec = max(nvec, entry + 1);
+ }
+
/*
* If nvec is equal to the allocated number of entries, we can just use
* what we have. Otherwise, the port has some extra entries not for the
--
2.7.4
prev parent reply other threads:[~2017-05-18 10:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 10:35 [PATCH v3 0/2] add MSI support for PCIe port services and DPC IRQ support Gabriele Paoloni
2017-05-18 10:35 ` [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services Gabriele Paoloni
2017-05-21 8:32 ` Christoph Hellwig
2017-05-21 15:00 ` Gabriele Paoloni
2017-05-22 17:44 ` Christoph Hellwig
2017-05-23 14:25 ` Gabriele Paoloni
2017-05-18 10:35 ` Gabriele Paoloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495103748-7876-3-git-send-email-gabriele.paoloni@huawei.com \
--to=gabriele.paoloni@huawei.com \
--cc=bhelgaas@google.com \
--cc=hch@infradead.org \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).