From: David Woodhouse <dwmw2@infradead.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pci <linux-pci@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] uio/uio_pci_generic: Add SR-IOV support
Date: Wed, 27 Sep 2017 13:59:22 +0100 [thread overview]
Message-ID: <1506517162.30379.2.camel@infradead.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1776 bytes --]
From: David Woodhouse <dwmw@amazon.co.uk>
Allow userspace to configure SR-IOV VFs through sysfs.
Currently, we need an in-kernel driver to permit this. But sometimes
*all* we want to do is enable the VFs so that we can assign them to
guests; we don't actually need to deal with the PF in any other way
from the host kernel. So let's make it possible to use UIO for that.
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
---
It's not entirely clear to me why we require the driver to "enable"
SR-IOV like this anyway — were there some which needed to do something
special and device-specific instead of just falling through to
pci_{en,dis}able_sriov(), such that we need to effectively whitelist
this in the driver rather than blacklisting the "problematic" ones via
PCI quirks?
drivers/uio/uio_pci_generic.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/uio/uio_pci_generic.c b/drivers/uio/uio_pci_generic.c
index a56fdf9..bd196f0 100644
--- a/drivers/uio/uio_pci_generic.c
+++ b/drivers/uio/uio_pci_generic.c
@@ -108,15 +108,27 @@ static void remove(struct pci_dev *pdev)
struct uio_pci_generic_dev *gdev = pci_get_drvdata(pdev);
uio_unregister_device(&gdev->info);
+ pci_disable_sriov(pdev);
pci_disable_device(pdev);
kfree(gdev);
}
+static int sriov_configure(struct pci_dev *pdev, int num_vfs)
+{
+ if (!num_vfs) {
+ pci_disable_sriov(pdev);
+ return 0;
+ }
+
+ return pci_enable_sriov(pdev, num_vfs);
+}
+
static struct pci_driver uio_pci_driver = {
.name = "uio_pci_generic",
.id_table = NULL, /* only dynamic id's */
.probe = probe,
.remove = remove,
+ .sriov_configure = sriov_configure,
};
module_pci_driver(uio_pci_driver);
--
2.7.4
--
dwmw2
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 4938 bytes --]
next reply other threads:[~2017-09-27 13:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 12:59 David Woodhouse [this message]
2017-09-27 22:00 ` [PATCH] uio/uio_pci_generic: Add SR-IOV support Bjorn Helgaas
2017-09-27 22:20 ` David Woodhouse
2017-09-27 23:06 ` Alexander Duyck
2017-09-28 12:22 ` Don Dutile
2017-09-28 13:46 ` David Woodhouse
2017-09-28 15:05 ` Don Dutile
2017-09-28 15:52 ` David Woodhouse
2017-09-28 16:56 ` Don Dutile
2017-10-02 12:35 ` David Woodhouse
2017-10-02 18:52 ` Don Dutile
2017-10-02 19:10 ` David Woodhouse
2017-10-02 22:02 ` Don Dutile
2017-09-28 12:12 ` Don Dutile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506517162.30379.2.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).