linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH][next] PCI: endpoint: functions/pci-epf-test: fix memory leak of buf
@ 2020-04-01 22:35 Colin King
  2020-04-03 19:51 ` Alan Mikhak
  0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2020-04-01 22:35 UTC (permalink / raw)
  To: Kishon Vijay Abraham I, Lorenzo Pieralisi, Bjorn Helgaas, linux-pci
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

In the case where data cannot be transferred using DMA the allocation
of buf leaked on the error return path. Fix this by jumping to the
label err_dma_map that kfree's buf before the return.

Addresses-Coverity: ("Resource leak")
Fixes: a558357b1b34 ("PCI: endpoint: functions/pci-epf-test: Add DMA support to transfer data")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/pci/endpoint/functions/pci-epf-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
index 3b4cf7e2bc60..60330f3e3751 100644
--- a/drivers/pci/endpoint/functions/pci-epf-test.c
+++ b/drivers/pci/endpoint/functions/pci-epf-test.c
@@ -347,7 +347,7 @@ static int pci_epf_test_read(struct pci_epf_test *epf_test)
 		if (!epf_test->dma_supported) {
 			dev_err(dev, "Cannot transfer data using DMA\n");
 			ret = -EINVAL;
-			goto err_map_addr;
+			goto err_dma_map;
 		}
 
 		dst_phys_addr = dma_map_single(dma_dev, buf, reg->size,
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH][next] PCI: endpoint: functions/pci-epf-test: fix memory leak of buf
  2020-04-01 22:35 [PATCH][next] PCI: endpoint: functions/pci-epf-test: fix memory leak of buf Colin King
@ 2020-04-03 19:51 ` Alan Mikhak
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Mikhak @ 2020-04-03 19:51 UTC (permalink / raw)
  To: kishon
  Cc: lorenzo.pieralisi, bhelgaas, linux-pci, kernel-janitors, linux-kernel

Hi Colin,

Please note a similar leak in pci_epf_test_write().

Regards,
Alan Mikhak


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-04-03 19:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-01 22:35 [PATCH][next] PCI: endpoint: functions/pci-epf-test: fix memory leak of buf Colin King
2020-04-03 19:51 ` Alan Mikhak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).