linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/3] dt-bindings: pci: rcar-pci-host: convert bindings to json-schema
@ 2020-10-30  5:29 Yoshihiro Shimoda
  2020-10-30  5:29 ` [PATCH v2 1/3] " Yoshihiro Shimoda
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Yoshihiro Shimoda @ 2020-10-30  5:29 UTC (permalink / raw)
  To: bhelgaas, marek.vasut+renesas, robh+dt
  Cc: prabhakar.mahadev-lad.rj, linux-pci, devicetree,
	linux-renesas-soc, Yoshihiro Shimoda

Convert bindings of rcar-pci.txt to json-schema.

Changes from v1:
 - In patch 1/3
 -- Fix indentation which yamllint detects.
 -- Fix typo which checkpatch.pl detects.
 -- Add ref: pci-bus.yaml
 -- Remove some properties which the pci-bus.yaml defines.
 -- Use unevaluatedProperties instead of additionalProperties.
 - In patch 2/3
 -- Add Reviewed-by from Geert-san.

Lad Prabhakar (1):
  dt-bindings: pci: rcar-pci: Add device tree support for r8a774e1

Yoshihiro Shimoda (2):
  dt-bindings: pci: rcar-pci-host: convert bindings to json-schema
  dt-bindings: pci: rcar-pci-host: document r8a77965 bindings

 .../devicetree/bindings/pci/rcar-pci-host.yaml     | 115 +++++++++++++++++++++
 Documentation/devicetree/bindings/pci/rcar-pci.txt |  72 -------------
 2 files changed, 115 insertions(+), 72 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/pci/rcar-pci-host.yaml
 delete mode 100644 Documentation/devicetree/bindings/pci/rcar-pci.txt

-- 
2.7.4


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 1/3] dt-bindings: pci: rcar-pci-host: convert bindings to json-schema
  2020-10-30  5:29 [PATCH v2 0/3] dt-bindings: pci: rcar-pci-host: convert bindings to json-schema Yoshihiro Shimoda
@ 2020-10-30  5:29 ` Yoshihiro Shimoda
  2020-10-30  5:29 ` [PATCH v2 2/3] dt-bindings: pci: rcar-pci-host: document r8a77965 bindings Yoshihiro Shimoda
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Yoshihiro Shimoda @ 2020-10-30  5:29 UTC (permalink / raw)
  To: bhelgaas, marek.vasut+renesas, robh+dt
  Cc: prabhakar.mahadev-lad.rj, linux-pci, devicetree,
	linux-renesas-soc, Yoshihiro Shimoda

Convert Renesas PCIe Host controller bindings documentation to
json-schema. Note that some compatible doesn't contain on
the original documentation so that incremental patches are required
for it.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 .../devicetree/bindings/pci/rcar-pci-host.yaml     | 113 +++++++++++++++++++++
 Documentation/devicetree/bindings/pci/rcar-pci.txt |  72 -------------
 2 files changed, 113 insertions(+), 72 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/pci/rcar-pci-host.yaml
 delete mode 100644 Documentation/devicetree/bindings/pci/rcar-pci.txt

diff --git a/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml b/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml
new file mode 100644
index 0000000..40c38a6
--- /dev/null
+++ b/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml
@@ -0,0 +1,113 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (C) 2020 Renesas Electronics Corp.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pci/rcar-pci-host.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Renesas R-Car PCIe Host
+
+maintainers:
+  - Marek Vasut <marek.vasut+renesas@gmail.com>
+  - Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
+
+allOf:
+  - $ref: pci-bus.yaml#
+
+properties:
+  compatible:
+    oneOf:
+      - items:
+          - enum:
+              - renesas,pcie-r8a7742      # RZ/G1H
+              - renesas,pcie-r8a7743      # RZ/G1M
+              - renesas,pcie-r8a7744      # RZ/G1N
+              - renesas,pcie-r8a7790      # R-Car H2
+              - renesas,pcie-r8a7791      # R-Car M2-W
+              - renesas,pcie-r8a7793      # R-Car M2-N
+          - const: renesas,pcie-rcar-gen2 # R-Car Gen2 and RZ/G1
+      - items:
+          - enum:
+              - renesas,pcie-r8a774a1     # RZ/G2M
+              - renesas,pcie-r8a774b1     # RZ/G2N
+              - renesas,pcie-r8a774c0     # RZ/G2E
+              - renesas,pcie-r8a7795      # R-Car H3
+              - renesas,pcie-r8a7796      # R-Car M3-W
+              - renesas,pcie-r8a77961     # R-Car M3-W+
+              - renesas,pcie-r8a77980     # R-Car V3H
+              - renesas,pcie-r8a77990     # R-Car E3
+          - const: renesas,pcie-rcar-gen3 # R-Car Gen3 and RZ/G2
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    minItems: 3
+    maxItems: 3
+
+  clocks:
+    maxItems: 2
+
+  clock-names:
+    items:
+      - const: pcie
+      - const: pcie_bus
+
+  power-domains:
+    maxItems: 1
+
+  resets:
+    maxItems: 1
+
+  phys:
+    maxItems: 1
+
+  phy-names:
+    const: pcie
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+  - power-domains
+  - resets
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/r8a7791-cpg-mssr.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/power/r8a7791-sysc.h>
+
+    soc {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        pcie: pcie@fe000000 {
+            compatible = "renesas,pcie-r8a7791", "renesas,pcie-rcar-gen2";
+            reg = <0 0xfe000000 0 0x80000>;
+             #address-cells = <3>;
+             #size-cells = <2>;
+             bus-range = <0x00 0xff>;
+             device_type = "pci";
+             ranges = <0x01000000 0 0x00000000 0 0xfe100000 0 0x00100000>,
+                      <0x02000000 0 0xfe200000 0 0xfe200000 0 0x00200000>,
+                      <0x02000000 0 0x30000000 0 0x30000000 0 0x08000000>,
+                      <0x42000000 0 0x38000000 0 0x38000000 0 0x08000000>;
+             dma-ranges = <0x42000000 0 0x40000000 0 0x40000000 0 0x40000000>,
+                          <0x42000000 2 0x00000000 2 0x00000000 0 0x40000000>;
+             interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>,
+                          <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>,
+                          <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>;
+             #interrupt-cells = <1>;
+             interrupt-map-mask = <0 0 0 0>;
+             interrupt-map = <0 0 0 0 &gic GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>;
+             clocks = <&cpg CPG_MOD 319>, <&pcie_bus_clk>;
+             clock-names = "pcie", "pcie_bus";
+             power-domains = <&sysc R8A7791_PD_ALWAYS_ON>;
+             resets = <&cpg 319>;
+         };
+    };
diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt b/Documentation/devicetree/bindings/pci/rcar-pci.txt
deleted file mode 100644
index 14d307d..0000000
--- a/Documentation/devicetree/bindings/pci/rcar-pci.txt
+++ /dev/null
@@ -1,72 +0,0 @@
-* Renesas R-Car PCIe interface
-
-Required properties:
-compatible: "renesas,pcie-r8a7742" for the R8A7742 SoC;
-	    "renesas,pcie-r8a7743" for the R8A7743 SoC;
-	    "renesas,pcie-r8a7744" for the R8A7744 SoC;
-	    "renesas,pcie-r8a774a1" for the R8A774A1 SoC;
-	    "renesas,pcie-r8a774b1" for the R8A774B1 SoC;
-	    "renesas,pcie-r8a774c0" for the R8A774C0 SoC;
-	    "renesas,pcie-r8a7779" for the R8A7779 SoC;
-	    "renesas,pcie-r8a7790" for the R8A7790 SoC;
-	    "renesas,pcie-r8a7791" for the R8A7791 SoC;
-	    "renesas,pcie-r8a7793" for the R8A7793 SoC;
-	    "renesas,pcie-r8a7795" for the R8A7795 SoC;
-	    "renesas,pcie-r8a7796" for the R8A77960 SoC;
-	    "renesas,pcie-r8a77961" for the R8A77961 SoC;
-	    "renesas,pcie-r8a77980" for the R8A77980 SoC;
-	    "renesas,pcie-r8a77990" for the R8A77990 SoC;
-	    "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 or
-				     RZ/G1 compatible device.
-	    "renesas,pcie-rcar-gen3" for a generic R-Car Gen3 or
-				     RZ/G2 compatible device.
-
-	    When compatible with the generic version, nodes must list the
-	    SoC-specific version corresponding to the platform first
-	    followed by the generic version.
-
-- reg: base address and length of the PCIe controller registers.
-- #address-cells: set to <3>
-- #size-cells: set to <2>
-- bus-range: PCI bus numbers covered
-- device_type: set to "pci"
-- ranges: ranges for the PCI memory and I/O regions.
-- dma-ranges: ranges for the inbound memory regions.
-- interrupts: two interrupt sources for MSI interrupts, followed by interrupt
-	source for hardware related interrupts (e.g. link speed change).
-- #interrupt-cells: set to <1>
-- interrupt-map-mask and interrupt-map: standard PCI properties
-	to define the mapping of the PCIe interface to interrupt numbers.
-- clocks: from common clock binding: clock specifiers for the PCIe controller
-	and PCIe bus clocks.
-- clock-names: from common clock binding: should be "pcie" and "pcie_bus".
-
-Optional properties:
-- phys: from common PHY binding: PHY phandle and specifier (only make sense
-	for R-Car gen3 SoCs where the PCIe PHYs have their own register blocks).
-- phy-names: from common PHY binding: should be "pcie".
-
-Example:
-
-SoC-specific DT Entry:
-
-	pcie: pcie@fe000000 {
-		compatible = "renesas,pcie-r8a7791", "renesas,pcie-rcar-gen2";
-		reg = <0 0xfe000000 0 0x80000>;
-		#address-cells = <3>;
-		#size-cells = <2>;
-		bus-range = <0x00 0xff>;
-		device_type = "pci";
-		ranges = <0x01000000 0 0x00000000 0 0xfe100000 0 0x00100000
-			  0x02000000 0 0xfe200000 0 0xfe200000 0 0x00200000
-			  0x02000000 0 0x30000000 0 0x30000000 0 0x08000000
-			  0x42000000 0 0x38000000 0 0x38000000 0 0x08000000>;
-		dma-ranges = <0x42000000 0 0x40000000 0 0x40000000 0 0x40000000
-			      0x42000000 2 0x00000000 2 0x00000000 0 0x40000000>;
-		interrupts = <0 116 4>, <0 117 4>, <0 118 4>;
-		#interrupt-cells = <1>;
-		interrupt-map-mask = <0 0 0 0>;
-		interrupt-map = <0 0 0 0 &gic 0 116 4>;
-		clocks = <&mstp3_clks R8A7791_CLK_PCIE>, <&pcie_bus_clk>;
-		clock-names = "pcie", "pcie_bus";
-	};
-- 
2.7.4


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 2/3] dt-bindings: pci: rcar-pci-host: document r8a77965 bindings
  2020-10-30  5:29 [PATCH v2 0/3] dt-bindings: pci: rcar-pci-host: convert bindings to json-schema Yoshihiro Shimoda
  2020-10-30  5:29 ` [PATCH v2 1/3] " Yoshihiro Shimoda
@ 2020-10-30  5:29 ` Yoshihiro Shimoda
  2020-10-30  5:29 ` [PATCH v2 3/3] dt-bindings: pci: rcar-pci: Add device tree support for r8a774e1 Yoshihiro Shimoda
  2020-11-03 22:37 ` [PATCH v2 0/3] dt-bindings: pci: rcar-pci-host: convert bindings to json-schema Bjorn Helgaas
  3 siblings, 0 replies; 6+ messages in thread
From: Yoshihiro Shimoda @ 2020-10-30  5:29 UTC (permalink / raw)
  To: bhelgaas, marek.vasut+renesas, robh+dt
  Cc: prabhakar.mahadev-lad.rj, linux-pci, devicetree,
	linux-renesas-soc, Yoshihiro Shimoda

Document the R-Car M3-N (R8A77965) SoC in the R-Car PCIe bindings.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 Documentation/devicetree/bindings/pci/rcar-pci-host.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml b/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml
index 40c38a6..c93b0d1 100644
--- a/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml
@@ -34,6 +34,7 @@ properties:
               - renesas,pcie-r8a7795      # R-Car H3
               - renesas,pcie-r8a7796      # R-Car M3-W
               - renesas,pcie-r8a77961     # R-Car M3-W+
+              - renesas,pcie-r8a77965     # R-Car M3-N
               - renesas,pcie-r8a77980     # R-Car V3H
               - renesas,pcie-r8a77990     # R-Car E3
           - const: renesas,pcie-rcar-gen3 # R-Car Gen3 and RZ/G2
-- 
2.7.4


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 3/3] dt-bindings: pci: rcar-pci: Add device tree support for r8a774e1
  2020-10-30  5:29 [PATCH v2 0/3] dt-bindings: pci: rcar-pci-host: convert bindings to json-schema Yoshihiro Shimoda
  2020-10-30  5:29 ` [PATCH v2 1/3] " Yoshihiro Shimoda
  2020-10-30  5:29 ` [PATCH v2 2/3] dt-bindings: pci: rcar-pci-host: document r8a77965 bindings Yoshihiro Shimoda
@ 2020-10-30  5:29 ` Yoshihiro Shimoda
  2020-11-03 22:37 ` [PATCH v2 0/3] dt-bindings: pci: rcar-pci-host: convert bindings to json-schema Bjorn Helgaas
  3 siblings, 0 replies; 6+ messages in thread
From: Yoshihiro Shimoda @ 2020-10-30  5:29 UTC (permalink / raw)
  To: bhelgaas, marek.vasut+renesas, robh+dt
  Cc: prabhakar.mahadev-lad.rj, linux-pci, devicetree,
	linux-renesas-soc, Yoshihiro Shimoda

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Add PCIe support for the RZ/G2H (a.k.a. R8A774E1).

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 Documentation/devicetree/bindings/pci/rcar-pci-host.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml b/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml
index c93b0d1..4a2bcc01 100644
--- a/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml
@@ -31,6 +31,7 @@ properties:
               - renesas,pcie-r8a774a1     # RZ/G2M
               - renesas,pcie-r8a774b1     # RZ/G2N
               - renesas,pcie-r8a774c0     # RZ/G2E
+              - renesas,pcie-r8a774e1     # RZ/G2H
               - renesas,pcie-r8a7795      # R-Car H3
               - renesas,pcie-r8a7796      # R-Car M3-W
               - renesas,pcie-r8a77961     # R-Car M3-W+
-- 
2.7.4


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 0/3] dt-bindings: pci: rcar-pci-host: convert bindings to json-schema
  2020-10-30  5:29 [PATCH v2 0/3] dt-bindings: pci: rcar-pci-host: convert bindings to json-schema Yoshihiro Shimoda
                   ` (2 preceding siblings ...)
  2020-10-30  5:29 ` [PATCH v2 3/3] dt-bindings: pci: rcar-pci: Add device tree support for r8a774e1 Yoshihiro Shimoda
@ 2020-11-03 22:37 ` Bjorn Helgaas
  2020-11-04  1:28   ` Yoshihiro Shimoda
  3 siblings, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2020-11-03 22:37 UTC (permalink / raw)
  To: Yoshihiro Shimoda
  Cc: bhelgaas, marek.vasut+renesas, robh+dt, prabhakar.mahadev-lad.rj,
	linux-pci, devicetree, linux-renesas-soc

Please follow the subject line convention, e.g.,

  dt-bindings: PCI: rcar-pci-host: Convert ...
  dt-bindings: PCI: rcar-pci-host: Document ...

On Fri, Oct 30, 2020 at 02:29:02PM +0900, Yoshihiro Shimoda wrote:
> Convert bindings of rcar-pci.txt to json-schema.
> 
> Changes from v1:
>  - In patch 1/3
>  -- Fix indentation which yamllint detects.
>  -- Fix typo which checkpatch.pl detects.
>  -- Add ref: pci-bus.yaml
>  -- Remove some properties which the pci-bus.yaml defines.
>  -- Use unevaluatedProperties instead of additionalProperties.
>  - In patch 2/3
>  -- Add Reviewed-by from Geert-san.
> 
> Lad Prabhakar (1):
>   dt-bindings: pci: rcar-pci: Add device tree support for r8a774e1
> 
> Yoshihiro Shimoda (2):
>   dt-bindings: pci: rcar-pci-host: convert bindings to json-schema
>   dt-bindings: pci: rcar-pci-host: document r8a77965 bindings
> 
>  .../devicetree/bindings/pci/rcar-pci-host.yaml     | 115 +++++++++++++++++++++
>  Documentation/devicetree/bindings/pci/rcar-pci.txt |  72 -------------
>  2 files changed, 115 insertions(+), 72 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/pci/rcar-pci-host.yaml
>  delete mode 100644 Documentation/devicetree/bindings/pci/rcar-pci.txt
> 
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH v2 0/3] dt-bindings: pci: rcar-pci-host: convert bindings to json-schema
  2020-11-03 22:37 ` [PATCH v2 0/3] dt-bindings: pci: rcar-pci-host: convert bindings to json-schema Bjorn Helgaas
@ 2020-11-04  1:28   ` Yoshihiro Shimoda
  0 siblings, 0 replies; 6+ messages in thread
From: Yoshihiro Shimoda @ 2020-11-04  1:28 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: bhelgaas, marek.vasut+renesas, robh+dt, Prabhakar Mahadev Lad,
	linux-pci, devicetree, linux-renesas-soc

Hi Bjorn,

> From: Bjorn Helgaas, Sent: Wednesday, November 4, 2020 7:38 AM
> 
> Please follow the subject line convention, e.g.,
> 
>   dt-bindings: PCI: rcar-pci-host: Convert ...
>   dt-bindings: PCI: rcar-pci-host: Document ...

I got it. I'll fix these subjects.

Best regards,
Yoshihiro Shimoda


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-11-04  1:29 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-30  5:29 [PATCH v2 0/3] dt-bindings: pci: rcar-pci-host: convert bindings to json-schema Yoshihiro Shimoda
2020-10-30  5:29 ` [PATCH v2 1/3] " Yoshihiro Shimoda
2020-10-30  5:29 ` [PATCH v2 2/3] dt-bindings: pci: rcar-pci-host: document r8a77965 bindings Yoshihiro Shimoda
2020-10-30  5:29 ` [PATCH v2 3/3] dt-bindings: pci: rcar-pci: Add device tree support for r8a774e1 Yoshihiro Shimoda
2020-11-03 22:37 ` [PATCH v2 0/3] dt-bindings: pci: rcar-pci-host: convert bindings to json-schema Bjorn Helgaas
2020-11-04  1:28   ` Yoshihiro Shimoda

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).