linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: keystone: Enable compile-testing on !ARM
@ 2020-09-04 18:56 Alex Dewar
  2020-09-06 12:19 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 8+ messages in thread
From: Alex Dewar @ 2020-09-04 18:56 UTC (permalink / raw)
  Cc: Alex Dewar, Lorenzo Pieralisi, Rob Herring, Bjorn Helgaas,
	Murali Karicheri, Thierry Reding, Andrew Murray, Vidya Sagar,
	Dilip Kota, Kunihiko Hayashi, Jonathan Chocron,
	Krzysztof Kozlowski, linux-pci, linux-kernel, linux-arm-kernel

Currently the Keystone driver can only be compile-tested on ARM, but
this restriction seems unnecessary. Get rid of it to increase test
coverage.

Build-tested on x86 with allyesconfig.

Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
---
 drivers/pci/controller/dwc/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index 044a3761c44f..ca36691314ed 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -107,7 +107,7 @@ config PCI_KEYSTONE
 
 config PCI_KEYSTONE_HOST
 	bool "PCI Keystone Host Mode"
-	depends on ARCH_KEYSTONE || ARCH_K3 || ((ARM || ARM64) && COMPILE_TEST)
+	depends on ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
 	depends on PCI_MSI_IRQ_DOMAIN
 	select PCIE_DW_HOST
 	select PCI_KEYSTONE
@@ -119,7 +119,7 @@ config PCI_KEYSTONE_HOST
 
 config PCI_KEYSTONE_EP
 	bool "PCI Keystone Endpoint Mode"
-	depends on ARCH_KEYSTONE || ARCH_K3 || ((ARM || ARM64) && COMPILE_TEST)
+	depends on ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
 	depends on PCI_ENDPOINT
 	select PCIE_DW_EP
 	select PCI_KEYSTONE
-- 
2.28.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] PCI: keystone: Enable compile-testing on !ARM
  2020-09-04 18:56 [PATCH] PCI: keystone: Enable compile-testing on !ARM Alex Dewar
@ 2020-09-06 12:19 ` Krzysztof Kozlowski
  2020-09-06 19:48   ` Alex Dewar
  0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-06 12:19 UTC (permalink / raw)
  To: Alex Dewar
  Cc: Lorenzo Pieralisi, Rob Herring, Bjorn Helgaas, Murali Karicheri,
	Thierry Reding, Andrew Murray, Vidya Sagar, Dilip Kota,
	Kunihiko Hayashi, Jonathan Chocron, linux-pci, linux-kernel,
	linux-arm-kernel

On Fri, 4 Sep 2020 at 20:56, Alex Dewar <alex.dewar90@gmail.com> wrote:
>
> Currently the Keystone driver can only be compile-tested on ARM, but
> this restriction seems unnecessary. Get rid of it to increase test
> coverage.
>
> Build-tested on x86 with allyesconfig.

You should at least build it on x86_64, powerpc and MIPS. These are
widely available (e.g. in most of distros, or here:
https://mirrors.edge.kernel.org/pub/tools/crosstool/). Useful is also
riscv and sh (specially sh lacks certain headers/features).

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] PCI: keystone: Enable compile-testing on !ARM
  2020-09-06 12:19 ` Krzysztof Kozlowski
@ 2020-09-06 19:48   ` Alex Dewar
  2020-09-06 19:51     ` [PATCH v2] " Alex Dewar
  0 siblings, 1 reply; 8+ messages in thread
From: Alex Dewar @ 2020-09-06 19:48 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Alex Dewar, Lorenzo Pieralisi, Rob Herring, Bjorn Helgaas,
	Murali Karicheri, Thierry Reding, Andrew Murray, Vidya Sagar,
	Dilip Kota, Kunihiko Hayashi, Jonathan Chocron, linux-pci,
	linux-kernel, linux-arm-kernel

On Sun, Sep 06, 2020 at 02:19:44PM +0200, Krzysztof Kozlowski wrote:
> On Fri, 4 Sep 2020 at 20:56, Alex Dewar <alex.dewar90@gmail.com> wrote:
> >
> > Currently the Keystone driver can only be compile-tested on ARM, but
> > this restriction seems unnecessary. Get rid of it to increase test
> > coverage.
> >
> > Build-tested on x86 with allyesconfig.
> 
> You should at least build it on x86_64, powerpc and MIPS. These are
> widely available (e.g. in most of distros, or here:
> https://mirrors.edge.kernel.org/pub/tools/crosstool/). Useful is also
> riscv and sh (specially sh lacks certain headers/features).

Good suggestion. I've built it on x86, ppc, mips and riscv. sh wouldn't
build because of some kbuild dependency, rather than a compiler error.
I'll send a v2 with an updated commit message.

> 
> Best regards,
> Krzysztof

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2] PCI: keystone: Enable compile-testing on !ARM
  2020-09-06 19:48   ` Alex Dewar
@ 2020-09-06 19:51     ` Alex Dewar
  2020-09-19 19:30       ` Alex Dewar
                         ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Alex Dewar @ 2020-09-06 19:51 UTC (permalink / raw)
  Cc: Alex Dewar, Lorenzo Pieralisi, Rob Herring, Bjorn Helgaas,
	Paul Walmsley, Palmer Dabbelt, Albert Ou, Andrew Murray,
	Gustavo Pimentel, Thierry Reding, Vidya Sagar, Kunihiko Hayashi,
	Krzysztof Kozlowski, Jonathan Chocron, Dilip Kota, linux-pci,
	linux-kernel, linux-riscv

Currently the Keystone driver can only be compile-tested on ARM, but
this restriction seems unnecessary. Get rid of it to increase test
coverage.

Build-tested with allyesconfig on x86, ppc, mips and riscv.

Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
---
 drivers/pci/controller/dwc/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index 044a3761c44f..ca36691314ed 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -107,7 +107,7 @@ config PCI_KEYSTONE
 
 config PCI_KEYSTONE_HOST
 	bool "PCI Keystone Host Mode"
-	depends on ARCH_KEYSTONE || ARCH_K3 || ((ARM || ARM64) && COMPILE_TEST)
+	depends on ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
 	depends on PCI_MSI_IRQ_DOMAIN
 	select PCIE_DW_HOST
 	select PCI_KEYSTONE
@@ -119,7 +119,7 @@ config PCI_KEYSTONE_HOST
 
 config PCI_KEYSTONE_EP
 	bool "PCI Keystone Endpoint Mode"
-	depends on ARCH_KEYSTONE || ARCH_K3 || ((ARM || ARM64) && COMPILE_TEST)
+	depends on ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
 	depends on PCI_ENDPOINT
 	select PCIE_DW_EP
 	select PCI_KEYSTONE
-- 
2.28.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] PCI: keystone: Enable compile-testing on !ARM
  2020-09-06 19:51     ` [PATCH v2] " Alex Dewar
@ 2020-09-19 19:30       ` Alex Dewar
  2020-09-30 18:21       ` Rob Herring
  2020-11-19 10:47       ` Lorenzo Pieralisi
  2 siblings, 0 replies; 8+ messages in thread
From: Alex Dewar @ 2020-09-19 19:30 UTC (permalink / raw)
  Cc: Lorenzo Pieralisi, Rob Herring, Bjorn Helgaas, Paul Walmsley,
	Palmer Dabbelt, Albert Ou, Andrew Murray, Gustavo Pimentel,
	Thierry Reding, Vidya Sagar, Kunihiko Hayashi,
	Krzysztof Kozlowski, Jonathan Chocron, Dilip Kota, linux-pci,
	linux-kernel, linux-riscv

On 2020-09-06 20:51, Alex Dewar wrote:
> Currently the Keystone driver can only be compile-tested on ARM, but
> this restriction seems unnecessary. Get rid of it to increase test
> coverage.
Friendly ping?
>
> Build-tested with allyesconfig on x86, ppc, mips and riscv.
>
> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
> ---
>   drivers/pci/controller/dwc/Kconfig | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 044a3761c44f..ca36691314ed 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -107,7 +107,7 @@ config PCI_KEYSTONE
>   
>   config PCI_KEYSTONE_HOST
>   	bool "PCI Keystone Host Mode"
> -	depends on ARCH_KEYSTONE || ARCH_K3 || ((ARM || ARM64) && COMPILE_TEST)
> +	depends on ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
>   	depends on PCI_MSI_IRQ_DOMAIN
>   	select PCIE_DW_HOST
>   	select PCI_KEYSTONE
> @@ -119,7 +119,7 @@ config PCI_KEYSTONE_HOST
>   
>   config PCI_KEYSTONE_EP
>   	bool "PCI Keystone Endpoint Mode"
> -	depends on ARCH_KEYSTONE || ARCH_K3 || ((ARM || ARM64) && COMPILE_TEST)
> +	depends on ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
>   	depends on PCI_ENDPOINT
>   	select PCIE_DW_EP
>   	select PCI_KEYSTONE


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] PCI: keystone: Enable compile-testing on !ARM
  2020-09-06 19:51     ` [PATCH v2] " Alex Dewar
  2020-09-19 19:30       ` Alex Dewar
@ 2020-09-30 18:21       ` Rob Herring
  2020-10-10  9:04         ` Alex Dewar
  2020-11-19 10:47       ` Lorenzo Pieralisi
  2 siblings, 1 reply; 8+ messages in thread
From: Rob Herring @ 2020-09-30 18:21 UTC (permalink / raw)
  To: Alex Dewar
  Cc: Paul Walmsley, Dilip Kota, linux-pci, Krzysztof Kozlowski,
	Thierry Reding, Andrew Murray, Lorenzo Pieralisi,
	Kunihiko Hayashi, Jonathan Chocron, linux-riscv, Palmer Dabbelt,
	Bjorn Helgaas, Vidya Sagar, linux-kernel, Albert Ou,
	Gustavo Pimentel

On Sun, 06 Sep 2020 20:51:27 +0100, Alex Dewar wrote:
> Currently the Keystone driver can only be compile-tested on ARM, but
> this restriction seems unnecessary. Get rid of it to increase test
> coverage.
> 
> Build-tested with allyesconfig on x86, ppc, mips and riscv.
> 
> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
> ---
>  drivers/pci/controller/dwc/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] PCI: keystone: Enable compile-testing on !ARM
  2020-09-30 18:21       ` Rob Herring
@ 2020-10-10  9:04         ` Alex Dewar
  0 siblings, 0 replies; 8+ messages in thread
From: Alex Dewar @ 2020-10-10  9:04 UTC (permalink / raw)
  To: Lorenzo Pieralisi, Murali Karicheri
  Cc: Rob Herring, Paul Walmsley, Dilip Kota, linux-pci,
	Krzysztof Kozlowski, Thierry Reding, Andrew Murray,
	Kunihiko Hayashi, Jonathan Chocron, linux-riscv, Palmer Dabbelt,
	Bjorn Helgaas, Vidya Sagar, linux-kernel, Albert Ou,
	Gustavo Pimentel

On 30/09/2020 19:21, Rob Herring wrote:
> On Sun, 06 Sep 2020 20:51:27 +0100, Alex Dewar wrote:
>> Currently the Keystone driver can only be compile-tested on ARM, but
>> this restriction seems unnecessary. Get rid of it to increase test
>> coverage.
>>
>> Build-tested with allyesconfig on x86, ppc, mips and riscv.
>>
>> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
>> ---
>>   drivers/pci/controller/dwc/Kconfig | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
> Acked-by: Rob Herring <robh@kernel.org>

Ping ping? :-)

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] PCI: keystone: Enable compile-testing on !ARM
  2020-09-06 19:51     ` [PATCH v2] " Alex Dewar
  2020-09-19 19:30       ` Alex Dewar
  2020-09-30 18:21       ` Rob Herring
@ 2020-11-19 10:47       ` Lorenzo Pieralisi
  2 siblings, 0 replies; 8+ messages in thread
From: Lorenzo Pieralisi @ 2020-11-19 10:47 UTC (permalink / raw)
  To: Alex Dewar
  Cc: Lorenzo Pieralisi, linux-kernel, Rob Herring, linux-riscv,
	Krzysztof Kozlowski, Palmer Dabbelt, linux-pci, Vidya Sagar,
	Dilip Kota, Gustavo Pimentel, Andrew Murray, Thierry Reding,
	Kunihiko Hayashi, Jonathan Chocron, Bjorn Helgaas, Albert Ou,
	Paul Walmsley

On Sun, 6 Sep 2020 20:51:27 +0100, Alex Dewar wrote:
> Currently the Keystone driver can only be compile-tested on ARM, but
> this restriction seems unnecessary. Get rid of it to increase test
> coverage.
> 
> Build-tested with allyesconfig on x86, ppc, mips and riscv.

Applied to pci/keystone, thanks!

[1/1] PCI: keystone: Enable compile-testing on !ARM
      https://git.kernel.org/lpieralisi/pci/c/476b70b4d1

Thanks,
Lorenzo

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-11-19 10:47 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-04 18:56 [PATCH] PCI: keystone: Enable compile-testing on !ARM Alex Dewar
2020-09-06 12:19 ` Krzysztof Kozlowski
2020-09-06 19:48   ` Alex Dewar
2020-09-06 19:51     ` [PATCH v2] " Alex Dewar
2020-09-19 19:30       ` Alex Dewar
2020-09-30 18:21       ` Rob Herring
2020-10-10  9:04         ` Alex Dewar
2020-11-19 10:47       ` Lorenzo Pieralisi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).