From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: linux-pci@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
"Rafał Miłecki" <zajec5@gmail.com>,
"Jim Quinlan" <james.quinlan@broadcom.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
open list <linux-kernel@vger.kernel.org>,
Andrew Murray <amurray@thegoodpenguin.co.uk>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh@kernel.org>,
Jeremy Linton <jeremy.linton@arm.com>
Subject: Re: [PATCH v1] PCI: brcmstb: variable is missing proper initialization
Date: Fri, 20 Nov 2020 17:07:12 +0000 [thread overview]
Message-ID: <160589201520.1295.14447752492499400941.b4-ty@arm.com> (raw)
In-Reply-To: <20201102205712.23332-1-james.quinlan@broadcom.com>
On Mon, 2 Nov 2020 15:57:12 -0500, Jim Quinlan wrote:
> The variable 'tmp' is used multiple times in the brcm_pcie_setup()
> function. One such usage did not initialize 'tmp' to the current value of
> the target register. By luck the mistake does not currently affect
> behavior; regardless 'tmp' is now initialized properly.
Applied to pci/brcmstb, thanks!
[1/1] PCI: brcmstb: Initialize "tmp" before use
https://git.kernel.org/lpieralisi/pci/c/ddaff0af65
Thanks,
Lorenzo
prev parent reply other threads:[~2020-11-20 17:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 20:57 [PATCH v1] PCI: brcmstb: variable is missing proper initialization Jim Quinlan
2020-11-02 21:07 ` Florian Fainelli
2020-11-03 17:32 ` Nicolas Saenz Julienne
2020-11-03 19:38 ` Bjorn Helgaas
2020-11-03 19:40 ` Nicolas Saenz Julienne
2020-11-04 14:48 ` Jim Quinlan
2020-11-20 17:07 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160589201520.1295.14447752492499400941.b4-ty@arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=amurray@thegoodpenguin.co.uk \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=f.fainelli@gmail.com \
--cc=james.quinlan@broadcom.com \
--cc=jeremy.linton@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=robh@kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).