From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: tjoseph@cadence.com, linux-pci@vger.kernel.org, kishon@ti.com,
bhelgaas@google.com, robh@kernel.org,
linux-kernel@vger.kernel.org, Nadeem Athani <nadeem@cadence.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
mparab@cadence.com, pthombar@cadence.com, sjakhade@cadence.com
Subject: Re: [PATCH v8 0/2] PCI: cadence: Retrain Link to work around Gen2
Date: Wed, 10 Feb 2021 12:52:33 +0000 [thread overview]
Message-ID: <161296139640.22133.12504586706777255696.b4-ty@arm.com> (raw)
In-Reply-To: <20210209144622.26683-1-nadeem@cadence.com>
On Tue, 9 Feb 2021 15:46:20 +0100, Nadeem Athani wrote:
> Cadence controller will not initiate autonomous speed change if strapped
> as Gen2. The Retrain Link bit is set as quirk to enable this speed change.
> Adding a quirk flag for defective IP. In future IP revisions this will not
> be applicable.
>
> Version history:
> Changes in v8:
> - Adding a new function cdns_pcie_host_start_link().
> Changes in v7:
> - Changing the commit title of patch 1 in this series.
> - Added a return value for function cdns_pcie_retrain().
> Changes in v6:
> - Move the position of function cdns_pcie_host_wait_for_link to remove
> compilation error. No changes in code. Separate patch for this.
> Changes in v5:
> - Remove the compatible string based setting of quirk flag.
> - Removed additional Link Up Check
> - Removed quirk from pcie-cadence-plat.c and added in pci-j721e.c
> Changes in v4:
> - Added a quirk flag based on a new compatible string.
> - Change of api for link up: cdns_pcie_host_wait_for_link().
> Changes in v3:
> - To set retrain link bit,checking device capability & link status.
> - 32bit read in place of 8bit.
> - Minor correction in patch comment.
> - Change in variable & macro name.
> Changes in v2:
> - 16bit read in place of 8bit.
>
> [...]
Applied to pci/cadence, squashed two commits together since it makes
no sense to keep them separate. Also, please check:
git log --oneline
when writing patches to keep the changes uniform, I had to edit your
commit.
Thanks,
Lorenzo
prev parent reply other threads:[~2021-02-10 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 14:46 [PATCH v8 0/2] PCI: cadence: Retrain Link to work around Gen2 Nadeem Athani
2021-02-09 14:46 ` [PATCH v8 1/2] PCI: cadence: Shifting of a function to support new code Nadeem Athani
2021-02-09 14:46 ` [PATCH v8 2/2] PCI: cadence: Retrain Link to work around Gen2 training defect Nadeem Athani
2021-02-10 12:52 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161296139640.22133.12504586706777255696.b4-ty@arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mparab@cadence.com \
--cc=nadeem@cadence.com \
--cc=pthombar@cadence.com \
--cc=robh@kernel.org \
--cc=sjakhade@cadence.com \
--cc=tjoseph@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).