linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc()
@ 2021-03-03 14:22 Pali Rohár
  2021-03-03 15:07 ` Marc Zyngier
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Pali Rohár @ 2021-03-03 14:22 UTC (permalink / raw)
  To: Marc Zyngier, Lorenzo Pieralisi, Rob Herring, Sandor Bodo-Merle,
	Ray Jui, Bjorn Helgaas
  Cc: linux-pci, linux-kernel

IRQ domain alloc function should return zero on success. Non-zero value
indicates failure.

Signed-off-by: Pali Rohár <pali@kernel.org>
Fixes: fc54bae28818 ("PCI: iproc: Allow allocation of multiple MSIs")
---
 drivers/pci/controller/pcie-iproc-msi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pcie-iproc-msi.c b/drivers/pci/controller/pcie-iproc-msi.c
index 908475d27e0e..eede4e8f3f75 100644
--- a/drivers/pci/controller/pcie-iproc-msi.c
+++ b/drivers/pci/controller/pcie-iproc-msi.c
@@ -271,7 +271,7 @@ static int iproc_msi_irq_domain_alloc(struct irq_domain *domain,
 				    NULL, NULL);
 	}
 
-	return hwirq;
+	return 0;
 }
 
 static void iproc_msi_irq_domain_free(struct irq_domain *domain,
-- 
2.20.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc()
  2021-03-03 14:22 [PATCH] PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc() Pali Rohár
@ 2021-03-03 15:07 ` Marc Zyngier
  2021-03-03 17:25 ` Ray Jui
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Marc Zyngier @ 2021-03-03 15:07 UTC (permalink / raw)
  To: Pali Rohár
  Cc: Lorenzo Pieralisi, Rob Herring, Sandor Bodo-Merle, Ray Jui,
	Bjorn Helgaas, linux-pci, linux-kernel

On Wed, 03 Mar 2021 14:22:02 +0000,
Pali Rohár <pali@kernel.org> wrote:
> 
> IRQ domain alloc function should return zero on success. Non-zero value
> indicates failure.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Fixes: fc54bae28818 ("PCI: iproc: Allow allocation of multiple MSIs")
> ---
>  drivers/pci/controller/pcie-iproc-msi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pcie-iproc-msi.c b/drivers/pci/controller/pcie-iproc-msi.c
> index 908475d27e0e..eede4e8f3f75 100644
> --- a/drivers/pci/controller/pcie-iproc-msi.c
> +++ b/drivers/pci/controller/pcie-iproc-msi.c
> @@ -271,7 +271,7 @@ static int iproc_msi_irq_domain_alloc(struct irq_domain *domain,
>  				    NULL, NULL);
>  	}
>  
> -	return hwirq;
> +	return 0;
>  }
>  
>  static void iproc_msi_irq_domain_free(struct irq_domain *domain,

Acked-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc()
  2021-03-03 14:22 [PATCH] PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc() Pali Rohár
  2021-03-03 15:07 ` Marc Zyngier
@ 2021-03-03 17:25 ` Ray Jui
  2021-03-06 23:59 ` Krzysztof Wilczyński
  2021-03-22 14:19 ` Lorenzo Pieralisi
  3 siblings, 0 replies; 5+ messages in thread
From: Ray Jui @ 2021-03-03 17:25 UTC (permalink / raw)
  To: Pali Rohár, Marc Zyngier, Lorenzo Pieralisi, Rob Herring,
	Sandor Bodo-Merle, Bjorn Helgaas
  Cc: linux-pci, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 916 bytes --]



On 3/3/2021 6:22 AM, Pali Rohár wrote:
> IRQ domain alloc function should return zero on success. Non-zero value
> indicates failure.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Fixes: fc54bae28818 ("PCI: iproc: Allow allocation of multiple MSIs")
> ---
>  drivers/pci/controller/pcie-iproc-msi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pcie-iproc-msi.c b/drivers/pci/controller/pcie-iproc-msi.c
> index 908475d27e0e..eede4e8f3f75 100644
> --- a/drivers/pci/controller/pcie-iproc-msi.c
> +++ b/drivers/pci/controller/pcie-iproc-msi.c
> @@ -271,7 +271,7 @@ static int iproc_msi_irq_domain_alloc(struct irq_domain *domain,
>  				    NULL, NULL);
>  	}
>  
> -	return hwirq;
> +	return 0;
>  }
>  
>  static void iproc_msi_irq_domain_free(struct irq_domain *domain,
> 

Looks good to me. Thanks for the fix.

Acked-by: Ray Jui <ray.jui@broadcom.com>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4194 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc()
  2021-03-03 14:22 [PATCH] PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc() Pali Rohár
  2021-03-03 15:07 ` Marc Zyngier
  2021-03-03 17:25 ` Ray Jui
@ 2021-03-06 23:59 ` Krzysztof Wilczyński
  2021-03-22 14:19 ` Lorenzo Pieralisi
  3 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Wilczyński @ 2021-03-06 23:59 UTC (permalink / raw)
  To: Pali Rohár
  Cc: Marc Zyngier, Lorenzo Pieralisi, Rob Herring, Sandor Bodo-Merle,
	Ray Jui, Bjorn Helgaas, linux-pci, linux-kernel

Hi Pali,

> IRQ domain alloc function should return zero on success. Non-zero value
> indicates failure.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Fixes: fc54bae28818 ("PCI: iproc: Allow allocation of multiple MSIs")
[...]

Nice catch!

Reviewed-by: Krzysztof Wilczyński <kw@linux.com>

Krzysztof

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc()
  2021-03-03 14:22 [PATCH] PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc() Pali Rohár
                   ` (2 preceding siblings ...)
  2021-03-06 23:59 ` Krzysztof Wilczyński
@ 2021-03-22 14:19 ` Lorenzo Pieralisi
  3 siblings, 0 replies; 5+ messages in thread
From: Lorenzo Pieralisi @ 2021-03-22 14:19 UTC (permalink / raw)
  To: Pali Rohár, Marc Zyngier, Ray Jui, Rob Herring,
	Sandor Bodo-Merle, Bjorn Helgaas
  Cc: Lorenzo Pieralisi, linux-pci, linux-kernel

On Wed, 3 Mar 2021 15:22:02 +0100, Pali Rohár wrote:
> IRQ domain alloc function should return zero on success. Non-zero value
> indicates failure.

Applied to pci/iproc, thanks!

[1/1] PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc()
      https://git.kernel.org/lpieralisi/pci/c/1e83130f01

Thanks,
Lorenzo

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-03-22 14:20 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-03 14:22 [PATCH] PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc() Pali Rohár
2021-03-03 15:07 ` Marc Zyngier
2021-03-03 17:25 ` Ray Jui
2021-03-06 23:59 ` Krzysztof Wilczyński
2021-03-22 14:19 ` Lorenzo Pieralisi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).