linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: microchip: Remove dev_err() when handing an error from platform_get_irq()
@ 2021-03-10 13:19 Krzysztof Wilczyński
  2021-03-22 14:26 ` Lorenzo Pieralisi
  0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Wilczyński @ 2021-03-10 13:19 UTC (permalink / raw)
  To: Bjorn Helgaas; +Cc: Daire McNamara, Lorenzo Pieralisi, Rob Herring, linux-pci

There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

This change is as per suggestions from Coccinelle, e.g.,
  drivers/pci/controller/pcie-microchip-host.c:1027:2-9: line 1027 is
  redundant because platform_get_irq() already prints an error

Related commit caecb05c8000 ("PCI: Remove dev_err() when handing an
error from platform_get_irq()").

Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
 drivers/pci/controller/pcie-microchip-host.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pci/controller/pcie-microchip-host.c b/drivers/pci/controller/pcie-microchip-host.c
index 04c19ff81aff..80cef572c904 100644
--- a/drivers/pci/controller/pcie-microchip-host.c
+++ b/drivers/pci/controller/pcie-microchip-host.c
@@ -1023,10 +1023,8 @@ static int mc_platform_init(struct pci_config_window *cfg)
 	}
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(dev, "unable to request IRQ%d\n", irq);
+	if (irq < 0)
 		return -ENODEV;
-	}
 
 	for (i = 0; i < NUM_EVENTS; i++) {
 		event_irq = irq_create_mapping(port->event_domain, i);
-- 
2.30.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] PCI: microchip: Remove dev_err() when handing an error from platform_get_irq()
  2021-03-10 13:19 [PATCH] PCI: microchip: Remove dev_err() when handing an error from platform_get_irq() Krzysztof Wilczyński
@ 2021-03-22 14:26 ` Lorenzo Pieralisi
  0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Pieralisi @ 2021-03-22 14:26 UTC (permalink / raw)
  To: Bjorn Helgaas, Krzysztof Wilczyński
  Cc: Lorenzo Pieralisi, Rob Herring, Daire McNamara, linux-pci

On Wed, 10 Mar 2021 13:19:13 +0000, Krzysztof Wilczyński wrote:
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from either the platform_get_irq()
> or platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.
> 
> This change is as per suggestions from Coccinelle, e.g.,
>   drivers/pci/controller/pcie-microchip-host.c:1027:2-9: line 1027 is
>   redundant because platform_get_irq() already prints an error
> 
> [...]

Applied to pci/microchip, thanks!

[1/1] PCI: microchip: Remove dev_err() when handing an error from platform_get_irq()
      https://git.kernel.org/lpieralisi/pci/c/6e7628c8c3

Thanks,
Lorenzo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-22 14:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-10 13:19 [PATCH] PCI: microchip: Remove dev_err() when handing an error from platform_get_irq() Krzysztof Wilczyński
2021-03-22 14:26 ` Lorenzo Pieralisi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).