linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: layerscape: Correct syntax by changing comma to semicolon
@ 2021-03-11  3:37 Krzysztof Wilczyński
  2021-03-22 14:58 ` Roy Zang
  2021-03-22 17:25 ` Lorenzo Pieralisi
  0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Wilczyński @ 2021-03-11  3:37 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Zheng Yongjun, Minghuan Lian, Mingkai Hu, Roy Zang,
	Lorenzo Pieralisi, Rob Herring, linuxppc-dev, linux-pci,
	linux-arm-kernel

Replace command with a semicolon to correct syntax and to prevent
potential unspecified behaviour and/or unintended side effects.

Related:
  https://lore.kernel.org/linux-pci/20201216131944.14990-1-zhengyongjun3@huawei.com/

Co-authored-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
 drivers/pci/controller/dwc/pci-layerscape-ep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
index 39fe2ed5a6a2..39f4664bd84c 100644
--- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
+++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
@@ -154,7 +154,7 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)
 	pci->dev = dev;
 	pci->ops = pcie->drvdata->dw_pcie_ops;
 
-	ls_epc->bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4),
+	ls_epc->bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4);
 
 	pcie->pci = pci;
 	pcie->ls_epc = ls_epc;
-- 
2.30.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] PCI: layerscape: Correct syntax by changing comma to semicolon
  2021-03-11  3:37 [PATCH] PCI: layerscape: Correct syntax by changing comma to semicolon Krzysztof Wilczyński
@ 2021-03-22 14:58 ` Roy Zang
  2021-03-22 17:25 ` Lorenzo Pieralisi
  1 sibling, 0 replies; 3+ messages in thread
From: Roy Zang @ 2021-03-22 14:58 UTC (permalink / raw)
  To: Krzysztof Wilczyński, Bjorn Helgaas
  Cc: Zheng Yongjun, M.h. Lian, Mingkai Hu, Lorenzo Pieralisi,
	Rob Herring, linuxppc-dev, linux-pci, linux-arm-kernel

Acked-by: Roy Zang <roy.zang@nxp.com>

Roy
-----Original Message-----
From: Krzysztof Wilczyński <kw@linux.com> 
Sent: Wednesday, March 10, 2021 9:38 PM

Replace command with a semicolon to correct syntax and to prevent potential unspecified behaviour and/or unintended side effects.

Related:
  https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flinux-pci%2F20201216131944.14990-1-zhengyongjun3%40huawei.com%2F&amp;data=04%7C01%7Croy.zang%40nxp.com%7C8bc03d11ee3f47753d7e08d8e43f0c15%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637510306719022629%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&amp;sdata=coDaErstzzBiGcJUykscD38ogbGXQyvrxt7ZI8cBk%2Fs%3D&amp;reserved=0

Co-authored-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
 drivers/pci/controller/dwc/pci-layerscape-ep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
index 39fe2ed5a6a2..39f4664bd84c 100644
--- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
+++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
@@ -154,7 +154,7 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)
 	pci->dev = dev;
 	pci->ops = pcie->drvdata->dw_pcie_ops;
 
-	ls_epc->bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4),
+	ls_epc->bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4);
 
 	pcie->pci = pci;
 	pcie->ls_epc = ls_epc;
--
2.30.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI: layerscape: Correct syntax by changing comma to semicolon
  2021-03-11  3:37 [PATCH] PCI: layerscape: Correct syntax by changing comma to semicolon Krzysztof Wilczyński
  2021-03-22 14:58 ` Roy Zang
@ 2021-03-22 17:25 ` Lorenzo Pieralisi
  1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2021-03-22 17:25 UTC (permalink / raw)
  To: Bjorn Helgaas, Krzysztof Wilczyński
  Cc: Lorenzo Pieralisi, Rob Herring, linux-pci, Mingkai Hu,
	linux-arm-kernel, Zheng Yongjun, Minghuan Lian, linuxppc-dev,
	Roy Zang

On Thu, 11 Mar 2021 03:37:45 +0000, Krzysztof Wilczyński wrote:
> Replace command with a semicolon to correct syntax and to prevent
> potential unspecified behaviour and/or unintended side effects.
> 
> Related:
>   https://lore.kernel.org/linux-pci/20201216131944.14990-1-zhengyongjun3@huawei.com/

Applied to pci/layerscape, thanks!

[1/1] PCI: layerscape: Correct syntax by changing comma to semicolon
      https://git.kernel.org/lpieralisi/pci/c/1b7996a528

Thanks,
Lorenzo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-22 17:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-11  3:37 [PATCH] PCI: layerscape: Correct syntax by changing comma to semicolon Krzysztof Wilczyński
2021-03-22 14:58 ` Roy Zang
2021-03-22 17:25 ` Lorenzo Pieralisi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).