linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI:tegra:Correct typo for PCIe endpoint mode in Tegra194
@ 2020-12-31  3:25 Wesley Sheng
  2021-01-03  6:47 ` Vidya Sagar
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Wesley Sheng @ 2020-12-31  3:25 UTC (permalink / raw)
  To: lorenzo.pieralisi, robh, bhelgaas, gustavo.pimentel,
	andriy.shevchenko, treding, vidyas, eswara.kota,
	hayashi.kunihiko, linux-pci, linux-kernel
  Cc: wesleyshenggit, wesley.sheng, wesley.sheng, wesley.sheng

In config PCIE_TEGRA194_EP the mode incorrectly referred to
host mode.

Signed-off-by: Wesley Sheng <wesley.sheng@amd.com>
---
 drivers/pci/controller/dwc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index 044a3761c44f..6960babe6161 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -273,7 +273,7 @@ config PCIE_TEGRA194_EP
 	select PCIE_TEGRA194
 	help
 	  Enables support for the PCIe controller in the NVIDIA Tegra194 SoC to
-	  work in host mode. There are two instances of PCIe controllers in
+	  work in endpoint mode. There are two instances of PCIe controllers in
 	  Tegra194. This controller can work either as EP or RC. In order to
 	  enable host-specific features PCIE_TEGRA194_HOST must be selected and
 	  in order to enable device-specific features PCIE_TEGRA194_EP must be
-- 
2.16.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] PCI:tegra:Correct typo for PCIe endpoint mode in Tegra194
  2020-12-31  3:25 [PATCH] PCI:tegra:Correct typo for PCIe endpoint mode in Tegra194 Wesley Sheng
@ 2021-01-03  6:47 ` Vidya Sagar
  2021-03-07 18:03 ` Krzysztof Wilczyński
  2021-03-22 18:20 ` Lorenzo Pieralisi
  2 siblings, 0 replies; 4+ messages in thread
From: Vidya Sagar @ 2021-01-03  6:47 UTC (permalink / raw)
  To: Wesley Sheng, lorenzo.pieralisi, robh, bhelgaas,
	gustavo.pimentel, andriy.shevchenko, treding, eswara.kota,
	hayashi.kunihiko, linux-pci, linux-kernel
  Cc: wesleyshenggit, wesley.sheng, wesley.sheng

Thanks for the patch.

Acked-by: Vidya Sagar <vidyas@nvidia.com>

On 12/31/2020 8:55 AM, Wesley Sheng wrote:
> External email: Use caution opening links or attachments
> 
> 
> In config PCIE_TEGRA194_EP the mode incorrectly referred to
> host mode.
> 
> Signed-off-by: Wesley Sheng <wesley.sheng@amd.com>
> ---
>   drivers/pci/controller/dwc/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 044a3761c44f..6960babe6161 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -273,7 +273,7 @@ config PCIE_TEGRA194_EP
>          select PCIE_TEGRA194
>          help
>            Enables support for the PCIe controller in the NVIDIA Tegra194 SoC to
> -         work in host mode. There are two instances of PCIe controllers in
> +         work in endpoint mode. There are two instances of PCIe controllers in
>            Tegra194. This controller can work either as EP or RC. In order to
>            enable host-specific features PCIE_TEGRA194_HOST must be selected and
>            in order to enable device-specific features PCIE_TEGRA194_EP must be
> --
> 2.16.2
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] PCI:tegra:Correct typo for PCIe endpoint mode in Tegra194
  2020-12-31  3:25 [PATCH] PCI:tegra:Correct typo for PCIe endpoint mode in Tegra194 Wesley Sheng
  2021-01-03  6:47 ` Vidya Sagar
@ 2021-03-07 18:03 ` Krzysztof Wilczyński
  2021-03-22 18:20 ` Lorenzo Pieralisi
  2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Wilczyński @ 2021-03-07 18:03 UTC (permalink / raw)
  To: Wesley Sheng
  Cc: lorenzo.pieralisi, robh, helgaas, gustavo.pimentel,
	andriy.shevchenko, treding, vidyas, eswara.kota,
	hayashi.kunihiko, linux-pci, linux-kernel, wesleyshenggit,
	wesley.sheng, wesley.sheng

Hi,

A small nitpick.  There are spaces missing in the subject line.

[...]
>  	  Enables support for the PCIe controller in the NVIDIA Tegra194 SoC to
> -	  work in host mode. There are two instances of PCIe controllers in
> +	  work in endpoint mode. There are two instances of PCIe controllers in
>  	  Tegra194. This controller can work either as EP or RC. In order to
>  	  enable host-specific features PCIE_TEGRA194_HOST must be selected and
>  	  in order to enable device-specific features PCIE_TEGRA194_EP must be
[...]

Nice catch!  Thank you!

Reviewed-by: Krzysztof Wilczyński <kw@linux.com>

Krzysztof

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] PCI:tegra:Correct typo for PCIe endpoint mode in Tegra194
  2020-12-31  3:25 [PATCH] PCI:tegra:Correct typo for PCIe endpoint mode in Tegra194 Wesley Sheng
  2021-01-03  6:47 ` Vidya Sagar
  2021-03-07 18:03 ` Krzysztof Wilczyński
@ 2021-03-22 18:20 ` Lorenzo Pieralisi
  2 siblings, 0 replies; 4+ messages in thread
From: Lorenzo Pieralisi @ 2021-03-22 18:20 UTC (permalink / raw)
  To: bhelgaas, robh, gustavo.pimentel, eswara.kota, andriy.shevchenko,
	hayashi.kunihiko, linux-pci, vidyas, treding, linux-kernel,
	Wesley Sheng
  Cc: Lorenzo Pieralisi, wesley.sheng, wesleyshenggit, wesley.sheng

On Thu, 31 Dec 2020 11:25:39 +0800, Wesley Sheng wrote:
> In config PCIE_TEGRA194_EP the mode incorrectly referred to
> host mode.

Applied to pci/tegra, thanks!

[1/1] PCI: tegra: Fix typo for PCIe endpoint mode in Tegra194
      https://git.kernel.org/lpieralisi/pci/c/10739e2a5e

Thanks,
Lorenzo

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-03-22 18:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-31  3:25 [PATCH] PCI:tegra:Correct typo for PCIe endpoint mode in Tegra194 Wesley Sheng
2021-01-03  6:47 ` Vidya Sagar
2021-03-07 18:03 ` Krzysztof Wilczyński
2021-03-22 18:20 ` Lorenzo Pieralisi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).