linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xiaofei Tan <tanxiaofei@huawei.com>
To: <rjw@rjwysocki.net>, <lenb@kernel.org>, <rui.zhang@intel.com>,
	<bhelgaas@google.com>
Cc: Xiaofei Tan <tanxiaofei@huawei.com>, <linux-acpi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
	<linuxarm@openeuler.org>
Subject: [PATCH 06/15] ACPI: acpi_lpss: fix some coding style issues
Date: Sat, 27 Mar 2021 14:40:47 +0800	[thread overview]
Message-ID: <1616827256-51840-7-git-send-email-tanxiaofei@huawei.com> (raw)
In-Reply-To: <1616827256-51840-1-git-send-email-tanxiaofei@huawei.com>

Fix some coding style issues reported by checkpatch.pl, including
following types:

WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: Missing a blank line after declarations

Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
---
 drivers/acpi/acpi_lpss.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
index be73974..2df231e 100644
--- a/drivers/acpi/acpi_lpss.c
+++ b/drivers/acpi/acpi_lpss.c
@@ -187,7 +187,7 @@ static void byt_i2c_setup(struct lpss_private_data *pdata)
 
 	/* Expected to always be true, but better safe then sorry */
 	if (uid_str)
-		uid = simple_strtol(uid_str, NULL, 10);
+		uid = kstrtol(uid_str, NULL, 10);
 
 	/* Detect I2C bus shared with PUNIT and ignore its d3 status */
 	status = acpi_evaluate_integer(handle, "_SEM", NULL, &shared_host);
@@ -377,6 +377,7 @@ static const struct acpi_device_id acpi_lpss_device_ids[] = {
 static int is_memory(struct acpi_resource *res, void *not_used)
 {
 	struct resource r;
+
 	return !acpi_dev_resource_memory(res, &r);
 }
 
@@ -1200,6 +1201,7 @@ static int acpi_lpss_poweroff_noirq(struct device *dev)
 	if (pdata->dev_desc->resume_from_noirq) {
 		/* This is analogous to the acpi_lpss_suspend_noirq() case. */
 		int ret = acpi_lpss_do_poweroff_late(dev);
+
 		if (ret)
 			return ret;
 	}
-- 
2.8.1


  parent reply	other threads:[~2021-03-27  6:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-27  6:40 [PATCH 00/15] acpi: " Xiaofei Tan
2021-03-27  6:40 ` [PATCH 01/15] ACPI: APD: fix a block comment align issue Xiaofei Tan
2021-03-27  6:40 ` [PATCH 02/15] ACPI: processor: fix some coding style issues Xiaofei Tan
2021-03-27  6:40 ` [PATCH 03/15] ACPI: acpi_dbg: " Xiaofei Tan
2021-03-27  6:40 ` [PATCH 04/15] ACPI: acpi_fpdt: replace __attribute__((packed)) by __packed Xiaofei Tan
2021-03-27  6:40 ` [PATCH 05/15] remove useless return statement for void function Xiaofei Tan
2021-03-27  6:49   ` Xiaofei Tan
2021-03-27  6:40 ` Xiaofei Tan [this message]
2021-03-27  8:41   ` [PATCH 06/15] ACPI: acpi_lpss: fix some coding style issues kernel test robot
2021-03-27  6:40 ` [PATCH 07/15] ACPI: acpi_memhotplug: fix a coding style issue Xiaofei Tan
2021-03-27  6:40 ` [PATCH 08/15] ACPI: acpi_pad: " Xiaofei Tan
2021-03-27  6:40 ` [PATCH 09/15] ACPI: battery: fix some coding style issues Xiaofei Tan
2021-03-27  6:40 ` [PATCH 10/15] ACPI: button: " Xiaofei Tan
2021-03-27  6:40 ` [PATCH 11/15] ACPI: cppc_acpi: " Xiaofei Tan
2021-03-27  6:40 ` [PATCH 12/15] ACPI: custom_method: fix a coding style issue Xiaofei Tan
2021-03-27  6:40 ` [PATCH 13/15] ACPI: device_pm: fix some coding style issues Xiaofei Tan
2021-03-27  6:40 ` [PATCH 14/15] ACPI: device_sysfs: " Xiaofei Tan
2021-03-27  6:40 ` [PATCH 15/15] ACPI: dock: " Xiaofei Tan
2021-03-27  7:20 ` [PATCH 00/15] acpi: " Xiaofei Tan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1616827256-51840-7-git-send-email-tanxiaofei@huawei.com \
    --to=tanxiaofei@huawei.com \
    --cc=bhelgaas@google.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxarm@openeuler.org \
    --cc=rjw@rjwysocki.net \
    --cc=rui.zhang@intel.com \
    --subject='Re: [PATCH 06/15] ACPI: acpi_lpss: fix some coding style issues' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).