linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xiaofei Tan <tanxiaofei@huawei.com>
To: <rjw@rjwysocki.net>, <lenb@kernel.org>, <rui.zhang@intel.com>,
	<bhelgaas@google.com>
Cc: Xiaofei Tan <tanxiaofei@huawei.com>, <linux-acpi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
	<linuxarm@openeuler.org>
Subject: [PATCH v3 11/12] ACPI: sysfs: fix some coding style issues
Date: Sat, 27 Mar 2021 20:08:23 +0800	[thread overview]
Message-ID: <1616846904-25719-12-git-send-email-tanxiaofei@huawei.com> (raw)
In-Reply-To: <1616846904-25719-1-git-send-email-tanxiaofei@huawei.com>

Fix some coding style issues reported by checkpatch.pl, including
following types:

WARNING: Missing a blank line after declarations
WARNING: Block comments should align the * on each line
ERROR: open brace '{' following function definitions go on the next line

Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
---
 drivers/acpi/device_sysfs.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
index da4ff2a..a07d4ad 100644
--- a/drivers/acpi/device_sysfs.c
+++ b/drivers/acpi/device_sysfs.c
@@ -73,6 +73,7 @@ static const struct sysfs_ops acpi_data_node_sysfs_ops = {
 static void acpi_data_node_release(struct kobject *kobj)
 {
 	struct acpi_data_node *dn = to_data_node(kobj);
+
 	complete(&dn->kobj_done);
 }
 
@@ -130,7 +131,7 @@ static void acpi_hide_nondev_subnodes(struct acpi_device_data *data)
  * Return: 0: no _HID and no _CID
  *         -EINVAL: output error
  *         -ENOMEM: output is truncated
-*/
+ */
 static int create_pnp_modalias(struct acpi_device *acpi_dev, char *modalias,
 			       int size)
 {
@@ -431,7 +432,8 @@ static DEVICE_ATTR_RO(path);
 /* sysfs file that shows description text from the ACPI _STR method */
 static ssize_t description_show(struct device *dev,
 				struct device_attribute *attr,
-				char *buf) {
+				char *buf)
+{
 	struct acpi_device *acpi_dev = to_acpi_device(dev);
 	int result;
 
@@ -456,7 +458,8 @@ static DEVICE_ATTR_RO(description);
 
 static ssize_t
 sun_show(struct device *dev, struct device_attribute *attr,
-	 char *buf) {
+	 char *buf)
+{
 	struct acpi_device *acpi_dev = to_acpi_device(dev);
 	acpi_status status;
 	unsigned long long sun;
@@ -471,7 +474,8 @@ static DEVICE_ATTR_RO(sun);
 
 static ssize_t
 hrv_show(struct device *dev, struct device_attribute *attr,
-	 char *buf) {
+	 char *buf)
+{
 	struct acpi_device *acpi_dev = to_acpi_device(dev);
 	acpi_status status;
 	unsigned long long hrv;
@@ -485,7 +489,8 @@ hrv_show(struct device *dev, struct device_attribute *attr,
 static DEVICE_ATTR_RO(hrv);
 
 static ssize_t status_show(struct device *dev, struct device_attribute *attr,
-				char *buf) {
+				char *buf)
+{
 	struct acpi_device *acpi_dev = to_acpi_device(dev);
 	acpi_status status;
 	unsigned long long sta;
-- 
2.8.1


  parent reply	other threads:[~2021-03-27 12:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-27 12:08 [PATCH v3 00/12] acpi: " Xiaofei Tan
2021-03-27 12:08 ` [PATCH v3 01/12] ACPI: APD: fix a block comment align issue Xiaofei Tan
2021-03-27 12:08 ` [PATCH v3 02/12] ACPI: processor: fix some coding style issues Xiaofei Tan
2021-03-27 12:08 ` [PATCH v3 03/12] ACPI: ipmi: remove useless return statement for void function Xiaofei Tan
2021-03-27 12:08 ` [PATCH v3 04/12] ACPI: LPSS: add a missed blank line after declarations Xiaofei Tan
2021-03-27 12:08 ` [PATCH v3 05/12] ACPI: acpi_pad: " Xiaofei Tan
2021-03-27 12:08 ` [PATCH v3 06/12] ACPI: battery: fix some coding style issues Xiaofei Tan
2021-03-27 12:08 ` [PATCH v3 07/12] ACPI: button: " Xiaofei Tan
2021-03-27 12:08 ` [PATCH v3 08/12] ACPI: CPPC: " Xiaofei Tan
2021-03-27 12:08 ` [PATCH v3 09/12] ACPI: custom_method: fix a coding style issue Xiaofei Tan
2021-03-27 12:08 ` [PATCH v3 10/12] ACPI: PM: add a missed blank line after declarations Xiaofei Tan
2021-03-27 12:08 ` Xiaofei Tan [this message]
2021-03-27 12:08 ` [PATCH v3 12/12] ACPI: dock: fix some coding style issues Xiaofei Tan
2021-03-29 12:50 ` [PATCH v3 00/12] acpi: " Rafael J. Wysocki
2021-03-29 13:37   ` [Linuxarm] " Xiaofei Tan
2021-04-08 14:28 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1616846904-25719-12-git-send-email-tanxiaofei@huawei.com \
    --to=tanxiaofei@huawei.com \
    --cc=bhelgaas@google.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxarm@openeuler.org \
    --cc=rjw@rjwysocki.net \
    --cc=rui.zhang@intel.com \
    --subject='Re: [PATCH v3 11/12] ACPI: sysfs: fix some coding style issues' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).