* [PATCH] PCI: dwc: remove unused function
@ 2021-04-15 8:32 Jiapeng Chong
2021-04-15 13:32 ` Krzysztof Wilczyński
2021-04-15 15:16 ` Lorenzo Pieralisi
0 siblings, 2 replies; 3+ messages in thread
From: Jiapeng Chong @ 2021-04-15 8:32 UTC (permalink / raw)
To: lorenzo.pieralisi
Cc: robh, bhelgaas, p.zabel, linux-pci, linux-kernel, Jiapeng Chong
Fix the following clang warning:
drivers/pci/controller/dwc/pcie-intel-gw.c:84:19: warning: unused
function 'pcie_app_rd' [-Wunused-function].
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/pci/controller/dwc/pcie-intel-gw.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-intel-gw.c b/drivers/pci/controller/dwc/pcie-intel-gw.c
index 0cedd1f..f89a7d2 100644
--- a/drivers/pci/controller/dwc/pcie-intel-gw.c
+++ b/drivers/pci/controller/dwc/pcie-intel-gw.c
@@ -81,11 +81,6 @@ static void pcie_update_bits(void __iomem *base, u32 ofs, u32 mask, u32 val)
writel(val, base + ofs);
}
-static inline u32 pcie_app_rd(struct intel_pcie_port *lpp, u32 ofs)
-{
- return readl(lpp->app_base + ofs);
-}
-
static inline void pcie_app_wr(struct intel_pcie_port *lpp, u32 ofs, u32 val)
{
writel(val, lpp->app_base + ofs);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: dwc: remove unused function
2021-04-15 8:32 [PATCH] PCI: dwc: remove unused function Jiapeng Chong
@ 2021-04-15 13:32 ` Krzysztof Wilczyński
2021-04-15 15:16 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Wilczyński @ 2021-04-15 13:32 UTC (permalink / raw)
To: Jiapeng Chong
Cc: lorenzo.pieralisi, robh, bhelgaas, p.zabel, linux-pci, linux-kernel
Hi,
> Fix the following clang warning:
>
> drivers/pci/controller/dwc/pcie-intel-gw.c:84:19: warning: unused
> function 'pcie_app_rd' [-Wunused-function].
[...]
Nice catch! Thank you.
Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
By the way, next time capitalise the subject line.
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: dwc: remove unused function
2021-04-15 8:32 [PATCH] PCI: dwc: remove unused function Jiapeng Chong
2021-04-15 13:32 ` Krzysztof Wilczyński
@ 2021-04-15 15:16 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2021-04-15 15:16 UTC (permalink / raw)
To: Jiapeng Chong
Cc: Lorenzo Pieralisi, linux-kernel, p.zabel, bhelgaas, robh, linux-pci
On Thu, 15 Apr 2021 16:32:57 +0800, Jiapeng Chong wrote:
> Fix the following clang warning:
>
> drivers/pci/controller/dwc/pcie-intel-gw.c:84:19: warning: unused
> function 'pcie_app_rd' [-Wunused-function].
Applied to pci/dwc, thanks!
[1/1] PCI: dwc/intel-gw: Remove unused function
https://git.kernel.org/lpieralisi/pci/c/9534286be3
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-15 15:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-15 8:32 [PATCH] PCI: dwc: remove unused function Jiapeng Chong
2021-04-15 13:32 ` Krzysztof Wilczyński
2021-04-15 15:16 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).