From: Rob Herring <robh@kernel.org>
To: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Cc: "Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Frank Li" <Frank.Li@nxp.com>,
linux-pci@vger.kernel.org,
"Alexey Malahov" <Alexey.Malahov@baikalelectronics.ru>,
linux-kernel@vger.kernel.org,
"Serge Semin" <fancer.lancer@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
caihuoqing <caihuoqing@baidu.com>,
"Cai Huoqing" <cai.huoqing@linux.dev>,
"Robin Murphy" <robin.murphy@arm.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
devicetree@vger.kernel.org, "Vinod Koul" <vkoul@kernel.org>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Pavel Parkhomenko" <Pavel.Parkhomenko@baikalelectronics.ru>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: Re: [PATCH v6 09/20] dt-bindings: PCI: dwc: Add interrupts/interrupt-names common properties
Date: Thu, 10 Nov 2022 15:18:39 -0600 [thread overview]
Message-ID: <166811511627.1062682.15955440634711266362.robh@kernel.org> (raw)
In-Reply-To: <20221107204934.32655-10-Sergey.Semin@baikalelectronics.ru>
On Mon, 07 Nov 2022 23:49:23 +0300, Serge Semin wrote:
> Currently the 'interrupts' and 'interrupt-names' properties are defined
> being too generic to really describe any actual IRQ interface. Moreover
> the DW PCIe End-point devices are left with no IRQ signals. All of that
> can be fixed by adding the IRQ-related properties to the common DW PCIe
> DT-schemas in accordance with the hardware reference manual. The DW PCIe
> common DT-schema will contain the generic properties definitions with just
> a number of entries per property, while the DW PCIe RP/EP-specific schemas
> will have the particular number of items and the generic resource names
> listed.
>
> Note since there are DW PCI-based vendor-specific DT-bindings with the
> custom names assigned to the same IRQ resources we have no much choice but
> to add them to the generic DT-schemas in order to have the schemas being
> applicable for such devices. These names are marked as vendor-specific and
> should be avoided being used in new bindings in favor of the generic
> names.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>
> ---
>
> Note without the next dtschema tool fix
>
> --- a/lib.py 2022-09-29 15:17:13.100033810 +0300
> +++ b/lib.py 2022-09-29 15:19:54.886172794 +0300
> @@ -1307,7 +1307,7 @@
> def format_error(filename, error, prefix="", nodename=None, verbose=False):
> src = prefix + os.path.abspath(filename) + ':'
>
> - if error.linecol[0] >= 0:
> + if hasattr(error, 'linecol') and error.linecol[0] >= 0:
> src = src + '%i:%i: ' % (error.linecol[0]+1, error.linecol[1]+1)
> else:
> src += ' '
> @@ -1342,10 +1342,10 @@
> else:
> msg = error.message
>
> - if error.note:
> + if hasattr(error, 'note') and error.note:
> msg += '\n\t' + prefix + 'hint: ' + error.note
>
> - if error.schema_file:
> + if hasattr(error, 'schema_file') and error.schema_file:
> msg += '\n\t' + prefix + 'from schema $id: ' + error.schema_file
>
> return src + msg
>
> any DT-bindings error will cause the dt-schema script crash:
>
> Traceback (most recent call last):
> File "/home/fancer/.local/bin/dt-validate", line 175, in <module>
> sg.check_trees(filename, testtree)
> File "/home/fancer/.local/bin/dt-validate", line 122, in check_trees
> self.check_subtree(dt, subtree, False, "/", "/", filename)
> File "/home/fancer/.local/bin/dt-validate", line 111, in check_subtree
> self.check_subtree(tree, value, disabled, name, fullname + name, filename)
> File "/home/fancer/.local/bin/dt-validate", line 111, in check_subtree
> self.check_subtree(tree, value, disabled, name, fullname + name, filename)
> File "/home/fancer/.local/bin/dt-validate", line 106, in check_subtree
> self.check_node(tree, subtree, disabled, nodename, fullname, filename)
> File "/home/fancer/.local/bin/dt-validate", line 84, in check_node
> print(dtschema.format_error(filename, error, nodename=nodename, verbose=verbose) +
> File "/home/fancer/.local/lib/python3.8/site-packages/dtschema/lib.py", line 1332, in format_error
> msg += '\n' + format_error(filename, suberror, prefix=prefix+"\t", nodename=nodename, verbose=verbose)
> File "/home/fancer/.local/lib/python3.8/site-packages/dtschema/lib.py", line 1310, in format_error
> if error.linecol[0] >= 0:
> AttributeError: 'ValidationError' object has no attribute 'linecol'
>
> Changelog v3:
> - This is a new patch unpinned from the next one:
> https://lore.kernel.org/linux-pci/20220503214638.1895-2-Sergey.Semin@baikalelectronics.ru/
> by the Rob' request. (@Rob)
>
> Changelog v5:
> - Add platform-specific interrupt names, but mark them as deprecated.
>
> Changelog v6:
> - Move the common interrupt-names definitions to the RP/EP schemas.
> Thus drop the 'definitions' property. (@Rob)
> - Drop the 'deprecated' keywords from the vendor-specific names. (@Rob)
> ---
> .../bindings/pci/snps,dw-pcie-common.yaml | 19 ++++
> .../bindings/pci/snps,dw-pcie-ep.yaml | 52 +++++++++++
> .../devicetree/bindings/pci/snps,dw-pcie.yaml | 90 ++++++++++++++++++-
> 3 files changed, 158 insertions(+), 3 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2022-11-10 21:18 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 20:49 [PATCH v6 00/20] PCI: dwc: Add generic resources and Baikal-T1 support Serge Semin
2022-11-07 20:49 ` [PATCH v6 01/20] dt-bindings: imx6q-pcie: Fix clock names for imx6sx and imx8mq Serge Semin
2022-11-10 21:01 ` Rob Herring
2022-11-11 11:00 ` Serge Semin
2022-11-07 20:49 ` [PATCH v6 02/20] dt-bindings: visconti-pcie: Fix interrupts array max constraints Serge Semin
2022-11-07 20:49 ` [PATCH v6 03/20] dt-bindings: PCI: dwc: Detach common RP/EP DT bindings Serge Semin
2022-11-07 20:49 ` [PATCH v6 04/20] dt-bindings: PCI: dwc: Remove bus node from the examples Serge Semin
2022-11-07 20:49 ` [PATCH v6 05/20] dt-bindings: PCI: dwc: Add phys/phy-names common properties Serge Semin
2022-11-10 21:01 ` Rob Herring
2022-11-07 20:49 ` [PATCH v6 06/20] dt-bindings: PCI: dwc: Add max-link-speed common property Serge Semin
2022-11-07 20:49 ` [PATCH v6 07/20] dt-bindings: PCI: dwc: Apply generic schema for generic device only Serge Semin
2022-11-07 20:49 ` [PATCH v6 08/20] dt-bindings: PCI: dwc: Add max-functions EP property Serge Semin
2022-11-07 20:49 ` [PATCH v6 09/20] dt-bindings: PCI: dwc: Add interrupts/interrupt-names common properties Serge Semin
2022-11-08 12:40 ` Yoshihiro Shimoda
2022-11-08 13:52 ` Serge Semin
2022-11-08 22:32 ` Rob Herring
2022-11-10 12:26 ` Serge Semin
2022-11-10 21:18 ` Rob Herring [this message]
2022-11-07 20:49 ` [PATCH v6 10/20] dt-bindings: PCI: dwc: Add reg/reg-names " Serge Semin
2022-11-10 21:22 ` Rob Herring
2022-11-07 20:49 ` [PATCH v6 11/20] dt-bindings: PCI: dwc: Add clocks/resets " Serge Semin
2022-11-10 21:23 ` Rob Herring
2022-11-11 11:04 ` Serge Semin
2022-11-07 20:49 ` [PATCH v6 12/20] dt-bindings: PCI: dwc: Add dma-coherent property Serge Semin
2022-11-07 20:49 ` [PATCH v6 13/20] dt-bindings: PCI: dwc: Apply common schema to Rockchip DW PCIe nodes Serge Semin
2022-11-07 20:49 ` [PATCH v6 14/20] dt-bindings: PCI: dwc: Add Baikal-T1 PCIe Root Port bindings Serge Semin
2022-11-07 20:49 ` [PATCH v6 15/20] PCI: dwc: Introduce dma-ranges property support for RC-host Serge Semin
2022-11-07 20:49 ` [PATCH v6 16/20] PCI: dwc: Introduce generic controller capabilities interface Serge Semin
2022-11-07 20:49 ` [PATCH v6 17/20] PCI: dwc: Introduce generic resources getter Serge Semin
2022-11-09 2:17 ` Yoshihiro Shimoda
2022-11-10 13:10 ` Serge Semin
2022-11-07 20:49 ` [PATCH v6 18/20] PCI: dwc: Combine iATU detection procedures Serge Semin
2022-11-07 20:49 ` [PATCH v6 19/20] PCI: dwc: Introduce generic platform clocks and resets Serge Semin
2022-11-07 20:49 ` [PATCH v6 20/20] PCI: dwc: Add Baikal-T1 PCIe controller support Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166811511627.1062682.15955440634711266362.robh@kernel.org \
--to=robh@kernel.org \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Frank.Li@nxp.com \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=bhelgaas@google.com \
--cc=cai.huoqing@linux.dev \
--cc=caihuoqing@baidu.com \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).