linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: mt7621: Use dev_info for PCIe no card plugged on port trace
@ 2023-03-24  7:37 Sergio Paracuellos
  2023-03-24 15:41 ` Lorenzo Pieralisi
  0 siblings, 1 reply; 3+ messages in thread
From: Sergio Paracuellos @ 2023-03-24  7:37 UTC (permalink / raw)
  To: linux-pci; +Cc: lpieralisi, bhelgaas, robh, matthias.bgg, kw, linux-kernel

When there is no card plugged on PCIe port a trace that says the port will
be disabled appears. This is expected behaviour but currently is using
'dev_err' for doing that. Since this is not an error at all, change the
trace to use 'dev_info' instead.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
 drivers/pci/controller/pcie-mt7621.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/controller/pcie-mt7621.c b/drivers/pci/controller/pcie-mt7621.c
index 63a5f4463a9f..a445ec314375 100644
--- a/drivers/pci/controller/pcie-mt7621.c
+++ b/drivers/pci/controller/pcie-mt7621.c
@@ -378,8 +378,8 @@ static int mt7621_pcie_init_ports(struct mt7621_pcie *pcie)
 		u32 slot = port->slot;
 
 		if (!mt7621_pcie_port_is_linkup(port)) {
-			dev_err(dev, "pcie%d no card, disable it (RST & CLK)\n",
-				slot);
+			dev_info(dev, "pcie%d no card, disable it (RST & CLK)\n",
+				 slot);
 			mt7621_control_assert(port);
 			port->enabled = false;
 			num_disabled++;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI: mt7621: Use dev_info for PCIe no card plugged on port trace
  2023-03-24  7:37 [PATCH] PCI: mt7621: Use dev_info for PCIe no card plugged on port trace Sergio Paracuellos
@ 2023-03-24 15:41 ` Lorenzo Pieralisi
  2023-03-28  8:16   ` Sergio Paracuellos
  0 siblings, 1 reply; 3+ messages in thread
From: Lorenzo Pieralisi @ 2023-03-24 15:41 UTC (permalink / raw)
  To: linux-pci, Sergio Paracuellos
  Cc: Lorenzo Pieralisi, bhelgaas, robh, matthias.bgg, kw, linux-kernel

On Fri, 24 Mar 2023 08:37:33 +0100, Sergio Paracuellos wrote:
> When there is no card plugged on PCIe port a trace that says the port will
> be disabled appears. This is expected behaviour but currently is using
> 'dev_err' for doing that. Since this is not an error at all, change the
> trace to use 'dev_info' instead.
> 
> 

Applied to controller/mt7621, thanks!

[1/1] PCI: mt7621: Use dev_info for PCIe no card plugged on port trace
      https://git.kernel.org/pci/pci/c/50233e105a03

Thanks,
Lorenzo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI: mt7621: Use dev_info for PCIe no card plugged on port trace
  2023-03-24 15:41 ` Lorenzo Pieralisi
@ 2023-03-28  8:16   ` Sergio Paracuellos
  0 siblings, 0 replies; 3+ messages in thread
From: Sergio Paracuellos @ 2023-03-28  8:16 UTC (permalink / raw)
  To: Lorenzo Pieralisi
  Cc: linux-pci, bhelgaas, robh, matthias.bgg, kw, linux-kernel

On Fri, Mar 24, 2023 at 4:41 PM Lorenzo Pieralisi <lpieralisi@kernel.org> wrote:
>
> On Fri, 24 Mar 2023 08:37:33 +0100, Sergio Paracuellos wrote:
> > When there is no card plugged on PCIe port a trace that says the port will
> > be disabled appears. This is expected behaviour but currently is using
> > 'dev_err' for doing that. Since this is not an error at all, change the
> > trace to use 'dev_info' instead.
> >
> >
>
> Applied to controller/mt7621, thanks!
>
> [1/1] PCI: mt7621: Use dev_info for PCIe no card plugged on port trace
>       https://git.kernel.org/pci/pci/c/50233e105a03
>
> Thanks,
> Lorenzo

Thanks, Lorenzo!

Best regards,
    Sergio Paracuellos

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-03-28  8:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-24  7:37 [PATCH] PCI: mt7621: Use dev_info for PCIe no card plugged on port trace Sergio Paracuellos
2023-03-24 15:41 ` Lorenzo Pieralisi
2023-03-28  8:16   ` Sergio Paracuellos

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).